From 187d6492f8b6c1edb795977cf3abf459697fd872 Mon Sep 17 00:00:00 2001
From: arcticfly <41524992+arcticfly@users.noreply.github.com>
Date: Mon, 10 Jul 2023 12:51:40 -0700
Subject: [PATCH] Reevaluate all prompt stats when scenario is hidden (#32)

* Reevaluate when scenario is hidden

* Add newline
---
 src/components/OutputsTable/ScenarioEditor.tsx | 7 ++++---
 src/server/api/routers/scenarios.router.ts     | 8 +++++++-
 src/server/utils/evaluations.ts                | 8 ++++++++
 3 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/src/components/OutputsTable/ScenarioEditor.tsx b/src/components/OutputsTable/ScenarioEditor.tsx
index 79e1dc7..ef15b27 100644
--- a/src/components/OutputsTable/ScenarioEditor.tsx
+++ b/src/components/OutputsTable/ScenarioEditor.tsx
@@ -5,7 +5,7 @@ import { type Scenario } from "./types";
 import { useExperiment, useHandledAsyncCallback } from "~/utils/hooks";
 import { useState } from "react";
 
-import { Box, Button, Flex, HStack, Icon, Stack, Tooltip } from "@chakra-ui/react";
+import { Box, Button, Flex, HStack, Icon, Spinner, Stack, Tooltip } from "@chakra-ui/react";
 import { cellPadding } from "../constants";
 import { BsX } from "react-icons/bs";
 import { RiDraggable } from "react-icons/ri";
@@ -43,11 +43,12 @@ export default function ScenarioEditor({
   }, [mutation, values]);
 
   const hideMutation = api.scenarios.hide.useMutation();
-  const [onHide] = useHandledAsyncCallback(async () => {
+  const [onHide, hidingInProgress] = useHandledAsyncCallback(async () => {
     await hideMutation.mutateAsync({
       id: scenario.id,
     });
     await utils.scenarios.list.invalidate();
+    await utils.promptVariants.stats.invalidate();
   }, [hideMutation, scenario.id]);
 
   const reorderMutation = api.scenarios.reorder.useMutation();
@@ -106,7 +107,7 @@ export default function ScenarioEditor({
               cursor: "pointer",
             }}
           >
-            <Icon as={BsX} boxSize={6} />
+            <Icon as={hidingInProgress ? Spinner :BsX} boxSize={6} />
           </Button>
         </Tooltip>
         <Icon
diff --git a/src/server/api/routers/scenarios.router.ts b/src/server/api/routers/scenarios.router.ts
index f5b3d1e..601b831 100644
--- a/src/server/api/routers/scenarios.router.ts
+++ b/src/server/api/routers/scenarios.router.ts
@@ -3,6 +3,7 @@ import { createTRPCRouter, publicProcedure } from "~/server/api/trpc";
 import { prisma } from "~/server/db";
 import { autogenerateScenarioValues } from "../autogen";
 import { recordExperimentUpdated } from "~/server/utils/recordExperimentUpdated";
+import { reevaluateAll } from "~/server/utils/evaluations";
 
 export const scenariosRouter = createTRPCRouter({
   list: publicProcedure.input(z.object({ experimentId: z.string() })).query(async ({ input }) => {
@@ -54,10 +55,15 @@ export const scenariosRouter = createTRPCRouter({
     }),
 
   hide: publicProcedure.input(z.object({ id: z.string() })).mutation(async ({ input }) => {
-    return await prisma.testScenario.update({
+    const hiddenScenario =  await prisma.testScenario.update({
       where: { id: input.id },
       data: { visible: false, experiment: { update: { updatedAt: new Date() } } },
     });
+
+    // Reevaluate all evaluations now that this scenario is hidden
+    await reevaluateAll(hiddenScenario.experimentId);
+
+    return hiddenScenario;
   }),
 
   reorder: publicProcedure
diff --git a/src/server/utils/evaluations.ts b/src/server/utils/evaluations.ts
index bc5df23..24d519a 100644
--- a/src/server/utils/evaluations.ts
+++ b/src/server/utils/evaluations.ts
@@ -89,3 +89,11 @@ export const reevaluateEvaluation = async (evaluation: Evaluation) => {
     }),
   );
 };
+
+export const reevaluateAll = async (experimentId: string) => {
+  const evaluations = await prisma.evaluation.findMany({
+    where: { experimentId },
+  });
+
+  await Promise.all(evaluations.map(reevaluateEvaluation));
+}