From 70a1448d73b460730006cfed9508895f035d1cb1 Mon Sep 17 00:00:00 2001
From: Kyle Corbitt <kyle@corbt.com>
Date: Fri, 7 Jul 2023 06:34:00 -0700
Subject: [PATCH] header bar improvements

---
 src/components/nav/AppShell.tsx |  1 +
 src/pages/experiments/[id].tsx  | 66 +++++++++++++++++++++++++++------
 2 files changed, 55 insertions(+), 12 deletions(-)

diff --git a/src/components/nav/AppShell.tsx b/src/components/nav/AppShell.tsx
index b05b49b..95bada6 100644
--- a/src/components/nav/AppShell.tsx
+++ b/src/components/nav/AppShell.tsx
@@ -122,6 +122,7 @@ export default function AppShell(props: { children: React.ReactNode; title?: str
   return (
     <Grid
       h="100vh"
+      w="100vw"
       templateColumns="220px minmax(0, 1fr)"
       templateRows="max-content 1fr"
       templateAreas={'"warning warning"\n"sidebar main"'}
diff --git a/src/pages/experiments/[id].tsx b/src/pages/experiments/[id].tsx
index 0888c36..231170f 100644
--- a/src/pages/experiments/[id].tsx
+++ b/src/pages/experiments/[id].tsx
@@ -8,9 +8,17 @@ import {
   HStack,
   Icon,
   Input,
+  AlertDialog,
+  AlertDialogBody,
+  AlertDialogFooter,
+  AlertDialogHeader,
+  AlertDialogContent,
+  AlertDialogOverlay,
+  useDisclosure,
 } from "@chakra-ui/react";
+
 import { useRouter } from "next/router";
-import { useState, useEffect } from "react";
+import { useState, useEffect, useRef } from "react";
 import { BsGearFill, BsTrash } from "react-icons/bs";
 import { RiFlaskLine } from "react-icons/ri";
 import OutputsTable from "~/components/OutputsTable";
@@ -20,25 +28,57 @@ import { api } from "~/utils/api";
 import { useExperiment, useHandledAsyncCallback } from "~/utils/hooks";
 import { useStore } from "~/utils/store";
 
-const DeleteButton = (props: { experimentId: string }) => {
+const DeleteButton = () => {
+  const experiment = useExperiment();
   const mutation = api.experiments.delete.useMutation();
   const utils = api.useContext();
   const router = useRouter();
 
-  const [onClick] = useHandledAsyncCallback(async () => {
-    const nextExperiment = await mutation.mutateAsync({ id: props.experimentId });
+  const { isOpen, onOpen, onClose } = useDisclosure();
+  const cancelRef = useRef<HTMLButtonElement>(null);
+
+  const [onDeleteConfirm] = useHandledAsyncCallback(async () => {
+    if (!experiment.data?.id) return;
+    const nextExperiment = await mutation.mutateAsync({ id: experiment.data.id });
     await utils.experiments.list.invalidate();
 
     if (nextExperiment) {
       await router.push({ pathname: "/experiments/[id]", query: { id: nextExperiment } });
     }
-  }, [mutation, props.experimentId]);
+    onClose();
+  }, [mutation, experiment.data?.id, router]);
 
   return (
-    <Button size="sm" variant="ghost" colorScheme="gray" fontWeight="normal" onClick={onClick}>
-      <Icon as={BsTrash} boxSize={4} mr={2} />
-      Delete Experiment
-    </Button>
+    <>
+      <Button size="sm" variant="ghost" colorScheme="gray" fontWeight="normal" onClick={onOpen}>
+        <Icon as={BsTrash} boxSize={4} mr={2} />
+        Delete Experiment
+      </Button>
+
+      <AlertDialog isOpen={isOpen} leastDestructiveRef={cancelRef} onClose={onClose}>
+        <AlertDialogOverlay>
+          <AlertDialogContent>
+            <AlertDialogHeader fontSize="lg" fontWeight="bold">
+              Delete Experiment
+            </AlertDialogHeader>
+
+            <AlertDialogBody>
+              If you delete this experiment all the associated prompts and scenarios will be deleted
+              as well. Are you sure?
+            </AlertDialogBody>
+
+            <AlertDialogFooter>
+              <Button ref={cancelRef} onClick={onClose}>
+                Cancel
+              </Button>
+              <Button colorScheme="red" onClick={onDeleteConfirm} ml={3}>
+                Delete
+              </Button>
+            </AlertDialogFooter>
+          </AlertDialogContent>
+        </AlertDialogOverlay>
+      </AlertDialog>
+    </>
   );
 };
 
@@ -94,7 +134,7 @@ export default function Experiment() {
                 borderColor="transparent"
                 fontSize={16}
                 px={0}
-                minW={400}
+                minW={300}
                 flex={1}
                 _hover={{ borderColor: "gray.300" }}
                 _focus={{ borderColor: "blue.500", outline: "none" }}
@@ -111,10 +151,12 @@ export default function Experiment() {
           >
             Edit Vars & Evals
           </Button>
-          <DeleteButton experimentId={router.query.id as string} />
+          <DeleteButton />
         </HStack>
         <SettingsDrawer />
-        <OutputsTable experimentId={router.query.id as string | undefined} />
+        <Box w="100%" overflowX="auto">
+          <OutputsTable experimentId={router.query.id as string | undefined} />
+        </Box>
       </Box>
     </AppShell>
   );