Move experiment scrollbar to bottom of page, make scenarios header sticky (#29)

* Remove newline from promptVariants router

* Move horizontal scroll bar to bottom of OutputsTable

* Make scenarios header sticky
This commit is contained in:
arcticfly
2023-07-10 11:40:02 -07:00
committed by GitHub
parent e64a94e06e
commit 96dacb0378
3 changed files with 7 additions and 4 deletions

View File

@@ -53,6 +53,9 @@ export default function OutputsTable({ experimentId }: { experimentId: string |
rowSpan={headerRows} rowSpan={headerRows}
px={cellPadding.x} px={cellPadding.x}
py={cellPadding.y} py={cellPadding.y}
// TODO: This is a hack to get the sticky header to work. It's not ideal because it's not responsive to the height of the header,
// so if the header height changes, this will need to be updated.
sx={{...stickyHeaderStyle, top: "-336px"}}
> >
<HStack w="100%"> <HStack w="100%">
<Heading size="xs" fontWeight="bold" flex={1}> <Heading size="xs" fontWeight="bold" flex={1}>

View File

@@ -16,6 +16,7 @@ import {
useDisclosure, useDisclosure,
Text, Text,
HStack, HStack,
VStack,
} from "@chakra-ui/react"; } from "@chakra-ui/react";
import Link from "next/link"; import Link from "next/link";
@@ -123,7 +124,7 @@ export default function Experiment() {
return ( return (
<AppShell title={experiment.data?.label}> <AppShell title={experiment.data?.label}>
<Box minH="100%" pb={50}> <VStack h="full">
<Flex <Flex
px={4} px={4}
py={2} py={2}
@@ -172,10 +173,10 @@ export default function Experiment() {
</HStack> </HStack>
</Flex> </Flex>
<SettingsDrawer /> <SettingsDrawer />
<Box w="100%" overflowX="auto"> <Box w="100%" overflowX="auto" flex={1}>
<OutputsTable experimentId={router.query.id as string | undefined} /> <OutputsTable experimentId={router.query.id as string | undefined} />
</Box> </Box>
</Box> </VStack>
</AppShell> </AppShell>
); );
} }

View File

@@ -149,7 +149,6 @@ export const promptVariantsRouter = createTRPCRouter({
]); ]);
return updatedPromptVariant; return updatedPromptVariant;
}), }),
hide: publicProcedure hide: publicProcedure