code smell update

This commit is contained in:
Arda Sönmez
2022-04-21 16:44:27 +03:00
parent d643ca11e9
commit 17a6068e1c

View File

@@ -10,10 +10,10 @@ class RGBLed:
anode = 'anode' anode = 'anode'
cathode = 'cathode' cathode = 'cathode'
def __init__(self, rPin, gPin, bPin, ledType, currentValueR = 0, currentValueG = 0, currentValueB=0): def __init__(self, red_pin, green_pin, blue_pin, ledType, currentValueR = 0, currentValueG = 0, currentValueB=0):
self.rPin = rPin self.red_pin = red_pin
self.gPin = gPin self.green_pin = green_pin
self.bPin = bPin self.blue_pin = blue_pin
self.ledType = ledType self.ledType = ledType
self.currentValueR = currentValueR self.currentValueR = currentValueR
self.currentValueG = currentValueG self.currentValueG = currentValueG
@@ -21,15 +21,15 @@ class RGBLed:
self.Set(currentValueR,currentValueG,currentValueB) self.Set(currentValueR,currentValueG,currentValueB)
def show(self): def show(self):
print("Red Pin:", self.rPin) print("Red Pin:", self.red_pin)
print("Green Pin:", self.gPin) print("Green Pin:", self.green_pin)
print("Blue Pin:", self.bPin) print("Blue Pin:", self.blue_pin)
print("Led Type:",self.ledType) print("Led Type:",self.ledType)
print("Current Red Value:",self.currentValueR) print("Current Red Value:",self.currentValueR)
print("Current Green Value:",self.currentValueG) print("Current Green Value:",self.currentValueG)
print("Current Blue Value:",self.currentValueB) print("Current Blue Value:",self.currentValueB)
def set(self,r,g,b): def setColor(self,r,g,b):
if self.ledType == 'anode': if self.ledType == 'anode':
self.currentValueR = r self.currentValueR = r
self.currentValueG = g self.currentValueG = g
@@ -38,12 +38,12 @@ class RGBLed:
r = convert(r,0,255,65534,0) r = convert(r,0,255,65534,0)
g = convert(g,0,255,65534,0) g = convert(g,0,255,65534,0)
b = convert(b,0,255,65534,0) b = convert(b,0,255,65534,0)
rPWM = PWM(Pin(self.rPin)) red_pin_pwm = PWM(Pin(self.red_pin))
gPWM = PWM(Pin(self.gPin)) green_pin_pwm = PWM(Pin(self.green_pin))
bPWM = PWM(Pin(self.bPin)) blue_pin_pwm = PWM(Pin(self.blue_pin))
rPWM.duty_u16(r) red_pin_pwm.duty_u16(r)
gPWM.duty_u16(g) green_pin_pwm.duty_u16(g)
bPWM.duty_u16(b) blue_pin_pwm.duty_u16(b)
elif self.ledType == 'cathode': elif self.ledType == 'cathode':
self.currentValueR = r self.currentValueR = r
self.currentValueG = g self.currentValueG = g
@@ -52,27 +52,27 @@ class RGBLed:
r = convert(r,0,255,0,65534) r = convert(r,0,255,0,65534)
g = convert(g,0,255,0,65534) g = convert(g,0,255,0,65534)
b = convert(b,0,255,0,65534) b = convert(b,0,255,0,65534)
rPWM = PWM(Pin(self.rPin)) red_pin_pwm = PWM(Pin(self.red_pin))
gPWM = PWM(Pin(self.gPin)) green_pin_pwm = PWM(Pin(self.green_pin))
bPWM = PWM(Pin(self.bPin)) blue_pin_pwm = PWM(Pin(self.blue_pin))
rPWM.duty_u16(r) red_pin_pwm.duty_u16(r)
gPWM.duty_u16(g) green_pin_pwm.duty_u16(g)
bPWM.duty_u16(b) blue_pin_pwm.duty_u16(b)
def off(self): def off(self):
self.Set(0,0,0) self.setColor(0,0,0)
def white(self): def white(self):
self.Set(255,255,255) self.setColor(255,255,255)
def yellow(self): def yellow(self):
self.Set(255,255,0) self.setColor(255,255,0)
def magenta(self): def magenta(self):
self.Set(255,0,255) self.setColor(255,0,255)
def cyan(self): def cyan(self):
self.Set(0,255,255) self.setColor(0,255,255)
def slowSet(self,r,g,b,delay = 0.01): def slowSet(self,r,g,b,delay = 0.01):
if r>self.currentValueR: if r>self.currentValueR:
@@ -89,39 +89,39 @@ class RGBLed:
bStep = 1 bStep = 1
else: else:
bStep = -1 bStep = -1
if self.ledType == 'anode': if self.ledType == 'anode':
for i in range(self.currentValueR,r,rStep): for i in range(self.currentValueR,r,rStep):
x = convert(i,0,255,65534,0) x = convert(i,0,255,65534,0)
rPWM = PWM(Pin(self.rPin)) red_pin_pwm = PWM(Pin(self.red_pin))
rPWM.duty_u16(x) red_pin_pwm.duty_u16(x)
utime.sleep(delay) utime.sleep(delay)
for i in range(self.currentValueG,g,gStep): for i in range(self.currentValueG,g,gStep):
x = convert(i,0,255,65534,0) x = convert(i,0,255,65534,0)
gPWM = PWM(Pin(self.gPin)) green_pin_pwm = PWM(Pin(self.green_pin))
gPWM.duty_u16(x) green_pin_pwm.duty_u16(x)
utime.sleep(delay) utime.sleep(delay)
for i in range(self.currentValueB,b,bStep): for i in range(self.currentValueB,b,bStep):
x = convert(i,0,255,65534,0) x = convert(i,0,255,65534,0)
bPWM = PWM(Pin(self.bPin)) blue_pin_pwm = PWM(Pin(self.blue_pin))
bPWM.duty_u16(x) blue_pin_pwm.duty_u16(x)
utime.sleep(delay) utime.sleep(delay)
elif self.ledType == 'cathode': elif self.ledType == 'cathode':
for i in range(self.currentValueR,r,rStep): for i in range(self.currentValueR,r,rStep):
x = convert(i,0,255,0,65534) x = convert(i,0,255,0,65534)
rPWM = PWM(Pin(self.rPin)) red_pin_pwm = PWM(Pin(self.red_pin))
rPWM.duty_u16(x) red_pin_pwm.duty_u16(x)
utime.sleep(delay) utime.sleep(delay)
for i in range(self.currentValueG,g,gStep): for i in range(self.currentValueG,g,gStep):
x = convert(i,0,255,0,65534) x = convert(i,0,255,0,65534)
gPWM = PWM(Pin(self.gPin)) green_pin_pwm = PWM(Pin(self.green_pin))
gPWM.duty_u16(x) green_pin_pwm.duty_u16(x)
utime.sleep(delay) utime.sleep(delay)
for i in range(self.currentValueB,b,bStep): for i in range(self.currentValueB,b,bStep):
x = convert(i,0,255,0,65534) x = convert(i,0,255,0,65534)
bPWM = PWM(Pin(self.bPin)) blue_pin_pwm = PWM(Pin(self.blue_pin))
bPWM.duty_u16(x) blue_pin_pwm.duty_u16(x)
utime.sleep(delay) utime.sleep(delay)
self.currentValueR = r self.currentValueR = r