mirror of
https://github.com/baz-scm/awesome-reviewers.git
synced 2025-08-20 18:58:52 +03:00
172 lines
13 KiB
JSON
172 lines
13 KiB
JSON
[
|
|
{
|
|
"discussion_id": "2272833477",
|
|
"pr_number": 36553,
|
|
"pr_file": "frontend/src/scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed.tsx",
|
|
"created_at": "2025-08-13T10:14:26+00:00",
|
|
"commented_code": "</LemonButton>\n </div>\n {SaveFiltersModal()}\n+ <div className=\"flex flex-row gap-2 w-full mt-40\">\n+ <ReplayActiveUsersTable />\n+ <ReplayActiveScreensTable />\n+ </div>",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2272833477",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36553,
|
|
"pr_file": "frontend/src/scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed.tsx",
|
|
"discussion_id": "2272833477",
|
|
"commented_code": "@@ -487,6 +490,10 @@ export const RecordingsUniversalFiltersEmbed = ({\n </LemonButton>\n </div>\n {SaveFiltersModal()}\n+ <div className=\"flex flex-row gap-2 w-full mt-40\">\n+ <ReplayActiveUsersTable />\n+ <ReplayActiveScreensTable />\n+ </div>",
|
|
"comment_created_at": "2025-08-13T10:14:26+00:00",
|
|
"comment_author": "pauldambra",
|
|
"comment_body": "i wonder should we _move_ them rather than duplicate them\r\nfolk are clicking these in the figure out what to watch tab\r\nbut i'd actually love to get rid of that tab and fold everything into one experience",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2272915543",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36553,
|
|
"pr_file": "frontend/src/scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed.tsx",
|
|
"discussion_id": "2272833477",
|
|
"commented_code": "@@ -487,6 +490,10 @@ export const RecordingsUniversalFiltersEmbed = ({\n </LemonButton>\n </div>\n {SaveFiltersModal()}\n+ <div className=\"flex flex-row gap-2 w-full mt-40\">\n+ <ReplayActiveUsersTable />\n+ <ReplayActiveScreensTable />\n+ </div>",
|
|
"comment_created_at": "2025-08-13T10:41:40+00:00",
|
|
"comment_author": "veryayskiy",
|
|
"comment_body": "Like move everything inside the Filters tab?\r\n\r\nWhat would happen to the \"Figure out what to watch\" tab? As we also have \"Filter templates\" there and folks check it https://us.posthog.com/project/2/insights/7IYmcsie\r\n\r\n",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2272930465",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36553,
|
|
"pr_file": "frontend/src/scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed.tsx",
|
|
"discussion_id": "2272833477",
|
|
"commented_code": "@@ -487,6 +490,10 @@ export const RecordingsUniversalFiltersEmbed = ({\n </LemonButton>\n </div>\n {SaveFiltersModal()}\n+ <div className=\"flex flex-row gap-2 w-full mt-40\">\n+ <ReplayActiveUsersTable />\n+ <ReplayActiveScreensTable />\n+ </div>",
|
|
"comment_created_at": "2025-08-13T10:46:15+00:00",
|
|
"comment_author": "pauldambra",
|
|
"comment_body": "## yep, i'd move these from fowtw to filters\r\n\r\n<img width=\"1218\" height=\"473\" alt=\"Screenshot 2025-08-13 at 11 43 40\" src=\"https://github.com/user-attachments/assets/f5506eed-77ab-41ff-9c6b-39bfc175b17d\" />\r\n\r\n## i'd leave this there for now\r\n\r\n<img width=\"1413\" height=\"389\" alt=\"Screenshot 2025-08-13 at 11 44 43\" src=\"https://github.com/user-attachments/assets/0d310831-f5d4-4e5a-a5d6-f8edae1dd05a\" />\r\n\r\ni think it's cool, but i don't think people come back to it\r\n\r\n## and i'd leave filter templates\r\n\r\n<img width=\"1408\" height=\"504\" alt=\"Screenshot 2025-08-13 at 11 45 04\" src=\"https://github.com/user-attachments/assets/b0fffc8c-f1d7-4d2e-bb67-8a0f13f2f4b5\" />\r\n\r\n---\r\n\r\nremembering the last time i looked at the data here, i think people are interacting with the email and URL stuff more\r\n\r\n---\r\n",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2275822466",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36553,
|
|
"pr_file": "frontend/src/scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed.tsx",
|
|
"discussion_id": "2272833477",
|
|
"commented_code": "@@ -487,6 +490,10 @@ export const RecordingsUniversalFiltersEmbed = ({\n </LemonButton>\n </div>\n {SaveFiltersModal()}\n+ <div className=\"flex flex-row gap-2 w-full mt-40\">\n+ <ReplayActiveUsersTable />\n+ <ReplayActiveScreensTable />\n+ </div>",
|
|
"comment_created_at": "2025-08-14T08:09:20+00:00",
|
|
"comment_author": "pauldambra",
|
|
"comment_body": "and then we need to figure out the performance issue with the users box here too\r\n\r\nannoyingly they need to move together really or the UI is unbalanced \ud83e\udee0 \r\n",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2276727543",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36553,
|
|
"pr_file": "frontend/src/scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed.tsx",
|
|
"discussion_id": "2272833477",
|
|
"commented_code": "@@ -487,6 +490,10 @@ export const RecordingsUniversalFiltersEmbed = ({\n </LemonButton>\n </div>\n {SaveFiltersModal()}\n+ <div className=\"flex flex-row gap-2 w-full mt-40\">\n+ <ReplayActiveUsersTable />\n+ <ReplayActiveScreensTable />\n+ </div>",
|
|
"comment_created_at": "2025-08-14T14:00:19+00:00",
|
|
"comment_author": "veryayskiy",
|
|
"comment_body": "Good point. I removed them from fwtw to avoid duplication.",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2284802043",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36553,
|
|
"pr_file": "frontend/src/scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed.tsx",
|
|
"discussion_id": "2272833477",
|
|
"commented_code": "@@ -487,6 +490,10 @@ export const RecordingsUniversalFiltersEmbed = ({\n </LemonButton>\n </div>\n {SaveFiltersModal()}\n+ <div className=\"flex flex-row gap-2 w-full mt-40\">\n+ <ReplayActiveUsersTable />\n+ <ReplayActiveScreensTable />\n+ </div>",
|
|
"comment_created_at": "2025-08-19T10:17:53+00:00",
|
|
"comment_author": "veryayskiy",
|
|
"comment_body": "@pauldambra I think it's good to go, or do you want more adjustments?",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2033004440",
|
|
"pr_number": 29364,
|
|
"pr_file": "frontend/src/scenes/insights/filters/ActionFilter/ActionFilter.tsx",
|
|
"created_at": "2025-04-08T11:39:20+00:00",
|
|
"commented_code": ") : null}\n {!singleFilter && (\n <div className=\"ActionFilter-footer\">\n- {!singleFilter && (",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2033004440",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 29364,
|
|
"pr_file": "frontend/src/scenes/insights/filters/ActionFilter/ActionFilter.tsx",
|
|
"discussion_id": "2033004440",
|
|
"commented_code": "@@ -242,23 +242,21 @@ export const ActionFilter = React.forwardRef<HTMLDivElement, ActionFilterProps>(\n ) : null}\n {!singleFilter && (\n <div className=\"ActionFilter-footer\">\n- {!singleFilter && (",
|
|
"comment_created_at": "2025-04-08T11:39:20+00:00",
|
|
"comment_author": "thmsobrmlr",
|
|
"comment_body": "fly-by change: the `!singleFilter` check is already done a couple of lines above at the wrapping div. As such the check isn't needed again here.",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2251871281",
|
|
"pr_number": 36129,
|
|
"pr_file": "frontend/src/scenes/experiments/ExperimentView/components.tsx",
|
|
"created_at": "2025-08-04T15:43:08+00:00",
|
|
"commented_code": ">\n Create dashboard\n </LemonButton>\n+ <LemonButton\n+ onClick={() => {\n+ if (experiment.feature_flag?.id) {\n+ featureFlagLogic({ id: experiment.feature_flag.id }).mount()",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2251871281",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36129,
|
|
"pr_file": "frontend/src/scenes/experiments/ExperimentView/components.tsx",
|
|
"discussion_id": "2251871281",
|
|
"commented_code": "@@ -356,6 +357,21 @@ export function PageHeaderCustom(): JSX.Element {\n >\n Create dashboard\n </LemonButton>\n+ <LemonButton\n+ onClick={() => {\n+ if (experiment.feature_flag?.id) {\n+ featureFlagLogic({ id: experiment.feature_flag.id }).mount()",
|
|
"comment_created_at": "2025-08-04T15:43:08+00:00",
|
|
"comment_author": "marandaneto",
|
|
"comment_body": "reusing `featureFlagLogic` instead of duplicating the very same things. DRY",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2252270856",
|
|
"pr_number": 35986,
|
|
"pr_file": "frontend/src/scenes/billing/billingLogic.tsx",
|
|
"created_at": "2025-08-04T18:20:30+00:00",
|
|
"commented_code": "if (isHidden) {\n return\n }\n+\n+ // Check if this alert was dismissed for the current billing period\n+ const billingPeriodEnd = values.billing?.billing_period?.current_period_end?.format('YYYY-MM-DD')",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2252270856",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 35986,
|
|
"pr_file": "frontend/src/scenes/billing/billingLogic.tsx",
|
|
"discussion_id": "2252270856",
|
|
"commented_code": "@@ -720,6 +760,29 @@ export const billingLogic = kea<billingLogicType>([\n if (isHidden) {\n return\n }\n+\n+ // Check if this alert was dismissed for the current billing period\n+ const billingPeriodEnd = values.billing?.billing_period?.current_period_end?.format('YYYY-MM-DD')",
|
|
"comment_created_at": "2025-08-04T18:20:30+00:00",
|
|
"comment_author": "zlwaterfield",
|
|
"comment_body": "Nit: this is duplicated exactly except for the dismissKey so it should be moved into a function",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2252271207",
|
|
"pr_number": 35986,
|
|
"pr_file": "frontend/src/scenes/billing/billingLogic.tsx",
|
|
"created_at": "2025-08-04T18:20:42+00:00",
|
|
"commented_code": "productApproachingLimit.usage_key && productApproachingLimit.usage_key.toLowerCase()\n } allocation.`,\n dismissKey: 'usage-limit-approaching',\n+ onClose: () => {\n+ // Store dismissal in localStorage\n+ const billingPeriodEnd =",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2252271207",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 35986,
|
|
"pr_file": "frontend/src/scenes/billing/billingLogic.tsx",
|
|
"discussion_id": "2252271207",
|
|
"commented_code": "@@ -729,6 +792,21 @@ export const billingLogic = kea<billingLogicType>([\n productApproachingLimit.usage_key && productApproachingLimit.usage_key.toLowerCase()\n } allocation.`,\n dismissKey: 'usage-limit-approaching',\n+ onClose: () => {\n+ // Store dismissal in localStorage\n+ const billingPeriodEnd =",
|
|
"comment_created_at": "2025-08-04T18:20:42+00:00",
|
|
"comment_author": "zlwaterfield",
|
|
"comment_body": "Nit: this is duplicated exactly except for the dismissKey so it should be moved into a function",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
}
|
|
] |