mirror of
https://github.com/baz-scm/awesome-reviewers.git
synced 2025-08-20 18:58:52 +03:00
70 lines
4.9 KiB
JSON
70 lines
4.9 KiB
JSON
[
|
|
{
|
|
"discussion_id": "2219466081",
|
|
"pr_number": 35030,
|
|
"pr_file": "frontend/src/scenes/funnels/FunnelBarHorizontal/FunnelBarHorizontal.scss",
|
|
"created_at": "2025-07-21T14:54:22+00:00",
|
|
"commented_code": "padding-left: 1rem;\n }\n \n+ // When there are optional steps, indent all content to make room for the layout\n+ &.has-optional-steps {",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2219466081",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 35030,
|
|
"pr_file": "frontend/src/scenes/funnels/FunnelBarHorizontal/FunnelBarHorizontal.scss",
|
|
"discussion_id": "2219466081",
|
|
"commented_code": "@@ -13,6 +13,13 @@ $glyph_height: 23px; // Based on .funnel-step-glyph\n padding-left: 1rem;\n }\n \n+ // When there are optional steps, indent all content to make room for the layout\n+ &.has-optional-steps {",
|
|
"comment_created_at": "2025-07-21T14:54:22+00:00",
|
|
"comment_author": "thmsobrmlr",
|
|
"comment_body": "nit: we mostly use BEM-style class names, so `&.FunnelBarHorizontal--has-optional-steps` would fit that pattern better",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2253520336",
|
|
"pr_number": 36116,
|
|
"pr_file": "products/error_tracking/frontend/ErrorTracking.scss",
|
|
"created_at": "2025-08-05T08:16:38+00:00",
|
|
"commented_code": "background-color: inherit;\n }\n }\n+\n+body[theme='light'] .ErrorTrackingIssue {\n+ --gray-1: var(--primitive-neutral-50);\n+ --gray-2: var(--primitive-neutral-100);\n+ --gray-3: var(--primitive-neutral-150);\n+}\n+\n+body[theme='dark'] .ErrorTrackingIssue {\n+ --gray-1: var(--primitive-neutral-cool-900);\n+ --gray-2: var(--primitive-neutral-cool-850);\n+ --gray-3: var(--primitive-neutral-cool-800);\n+}",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2253520336",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36116,
|
|
"pr_file": "products/error_tracking/frontend/ErrorTracking.scss",
|
|
"discussion_id": "2253520336",
|
|
"commented_code": "@@ -7,3 +7,15 @@\n background-color: inherit;\n }\n }\n+\n+body[theme='light'] .ErrorTrackingIssue {\n+ --gray-1: var(--primitive-neutral-50);\n+ --gray-2: var(--primitive-neutral-100);\n+ --gray-3: var(--primitive-neutral-150);\n+}\n+\n+body[theme='dark'] .ErrorTrackingIssue {\n+ --gray-1: var(--primitive-neutral-cool-900);\n+ --gray-2: var(--primitive-neutral-cool-850);\n+ --gray-3: var(--primitive-neutral-cool-800);\n+}",
|
|
"comment_created_at": "2025-08-05T08:16:38+00:00",
|
|
"comment_author": "daibhin",
|
|
"comment_body": "What's the thinking behind these custom colours? And specifically renaming them?",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2254061538",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36116,
|
|
"pr_file": "products/error_tracking/frontend/ErrorTracking.scss",
|
|
"discussion_id": "2253520336",
|
|
"commented_code": "@@ -7,3 +7,15 @@\n background-color: inherit;\n }\n }\n+\n+body[theme='light'] .ErrorTrackingIssue {\n+ --gray-1: var(--primitive-neutral-50);\n+ --gray-2: var(--primitive-neutral-100);\n+ --gray-3: var(--primitive-neutral-150);\n+}\n+\n+body[theme='dark'] .ErrorTrackingIssue {\n+ --gray-1: var(--primitive-neutral-cool-900);\n+ --gray-2: var(--primitive-neutral-cool-850);\n+ --gray-3: var(--primitive-neutral-cool-800);\n+}",
|
|
"comment_created_at": "2025-08-05T11:30:16+00:00",
|
|
"comment_author": "hpouillot",
|
|
"comment_body": "The goal is to not worry about the theme when using those colors (as they will switch automatically) and have convenient shortcuts for tailwind. Naming is inspired by [radix colors](https://www.radix-ui.com/colors).",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2254877711",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36116,
|
|
"pr_file": "products/error_tracking/frontend/ErrorTracking.scss",
|
|
"discussion_id": "2253520336",
|
|
"commented_code": "@@ -7,3 +7,15 @@\n background-color: inherit;\n }\n }\n+\n+body[theme='light'] .ErrorTrackingIssue {\n+ --gray-1: var(--primitive-neutral-50);\n+ --gray-2: var(--primitive-neutral-100);\n+ --gray-3: var(--primitive-neutral-150);\n+}\n+\n+body[theme='dark'] .ErrorTrackingIssue {\n+ --gray-1: var(--primitive-neutral-cool-900);\n+ --gray-2: var(--primitive-neutral-cool-850);\n+ --gray-3: var(--primitive-neutral-cool-800);\n+}",
|
|
"comment_created_at": "2025-08-05T17:04:19+00:00",
|
|
"comment_author": "daibhin",
|
|
"comment_body": "Fair enough. I have little context on where we're at with colour but @adamleithp might have some suggestions about how we want to implement this kind of thing",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
}
|
|
] |