mirror of
https://github.com/baz-scm/awesome-reviewers.git
synced 2025-08-20 18:58:52 +03:00
94 lines
7.5 KiB
JSON
94 lines
7.5 KiB
JSON
[
|
|
{
|
|
"discussion_id": "2273119714",
|
|
"pr_number": 36561,
|
|
"pr_file": "bin/start",
|
|
"created_at": "2025-08-13T11:41:43+00:00",
|
|
"commented_code": "fi\n fi\n \n-# Use minimal config if --minimal flag is passed\n-if [[ \"$*\" == *\"--minimal\"* ]]; then\n+# Check for conflicting flags\n+if [[ \"$*\" == *\"--custom\"* ]] && ([[ \"$*\" == *\"--minimal\"* ]] || [[ \"$*\" == *\"--vite\"* ]]); then\n+ echo \"Error: Cannot use --custom with --minimal or --vite\"\n+ exit 1\n+fi\n+\n+# Use custom config, if provided (e.g. bin/start --custom bin/mprocs-custom.yaml)",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2273119714",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36561,
|
|
"pr_file": "bin/start",
|
|
"discussion_id": "2273119714",
|
|
"commented_code": "@@ -57,9 +57,36 @@ if ! command -v mprocs &>/dev/null; then\n fi\n fi\n \n-# Use minimal config if --minimal flag is passed\n-if [[ \"$*\" == *\"--minimal\"* ]]; then\n+# Check for conflicting flags\n+if [[ \"$*\" == *\"--custom\"* ]] && ([[ \"$*\" == *\"--minimal\"* ]] || [[ \"$*\" == *\"--vite\"* ]]); then\n+ echo \"Error: Cannot use --custom with --minimal or --vite\"\n+ exit 1\n+fi\n+\n+# Use custom config, if provided (e.g. bin/start --custom bin/mprocs-custom.yaml)",
|
|
"comment_created_at": "2025-08-13T11:41:43+00:00",
|
|
"comment_author": "skoob13",
|
|
"comment_body": "Should we exclude in git custom configs? Like `bin/mprocs*.local.yaml` in gitignore.",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2273133457",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36561,
|
|
"pr_file": "bin/start",
|
|
"discussion_id": "2273119714",
|
|
"commented_code": "@@ -57,9 +57,36 @@ if ! command -v mprocs &>/dev/null; then\n fi\n fi\n \n-# Use minimal config if --minimal flag is passed\n-if [[ \"$*\" == *\"--minimal\"* ]]; then\n+# Check for conflicting flags\n+if [[ \"$*\" == *\"--custom\"* ]] && ([[ \"$*\" == *\"--minimal\"* ]] || [[ \"$*\" == *\"--vite\"* ]]); then\n+ echo \"Error: Cannot use --custom with --minimal or --vite\"\n+ exit 1\n+fi\n+\n+# Use custom config, if provided (e.g. bin/start --custom bin/mprocs-custom.yaml)",
|
|
"comment_created_at": "2025-08-13T11:46:15+00:00",
|
|
"comment_author": "rossgray",
|
|
"comment_body": "this is a good idea",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2273137531",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36561,
|
|
"pr_file": "bin/start",
|
|
"discussion_id": "2273119714",
|
|
"commented_code": "@@ -57,9 +57,36 @@ if ! command -v mprocs &>/dev/null; then\n fi\n fi\n \n-# Use minimal config if --minimal flag is passed\n-if [[ \"$*\" == *\"--minimal\"* ]]; then\n+# Check for conflicting flags\n+if [[ \"$*\" == *\"--custom\"* ]] && ([[ \"$*\" == *\"--minimal\"* ]] || [[ \"$*\" == *\"--vite\"* ]]); then\n+ echo \"Error: Cannot use --custom with --minimal or --vite\"\n+ exit 1\n+fi\n+\n+# Use custom config, if provided (e.g. bin/start --custom bin/mprocs-custom.yaml)",
|
|
"comment_created_at": "2025-08-13T11:47:37+00:00",
|
|
"comment_author": "sortafreel",
|
|
"comment_body": "I assume, it depends on where you store your configs. I have a `playground` directory (inside each project) added to the global `gitignore` where I put stuff like this. \r\n\r\nAdding it to `.gitignore` in the suggested way would force a location/naming preference, as I see it. But it won't hurt, also. Happy to add.",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2273144126",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36561,
|
|
"pr_file": "bin/start",
|
|
"discussion_id": "2273119714",
|
|
"commented_code": "@@ -57,9 +57,36 @@ if ! command -v mprocs &>/dev/null; then\n fi\n fi\n \n-# Use minimal config if --minimal flag is passed\n-if [[ \"$*\" == *\"--minimal\"* ]]; then\n+# Check for conflicting flags\n+if [[ \"$*\" == *\"--custom\"* ]] && ([[ \"$*\" == *\"--minimal\"* ]] || [[ \"$*\" == *\"--vite\"* ]]); then\n+ echo \"Error: Cannot use --custom with --minimal or --vite\"\n+ exit 1\n+fi\n+\n+# Use custom config, if provided (e.g. bin/start --custom bin/mprocs-custom.yaml)",
|
|
"comment_created_at": "2025-08-13T11:49:41+00:00",
|
|
"comment_author": "sortafreel",
|
|
"comment_body": "https://github.com/PostHog/posthog/pull/36561/commits/592983115c37ca019a4eccd17ff8fb6b7de7d396",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2257407472",
|
|
"pr_number": 36254,
|
|
"pr_file": "bin/posthog-worktree",
|
|
"created_at": "2025-08-06T14:35:16+00:00",
|
|
"commented_code": "cp \"${main_repo}/.flox/env/manifest.toml\" \"${worktree_path}/.flox/env/\"\n cp \"${main_repo}/.envrc\" \"${worktree_path}/\"\n \n+ # Copy .vscode/settings.json if it exists\n+ if [[ -f \"${main_repo}/.vscode/settings.json\" ]]; then\n+ print_color blue \"Copying .vscode/settings.json\u2026\"\n+ mkdir -p \"${worktree_path}/.vscode\"\n+ cp \"${main_repo}/.vscode/settings.json\" \"${worktree_path}/.vscode/\"\n+ fi\n+ \n+ # Copy any .env files if they exist\n+ if find \"${main_repo}\" -maxdepth 1 -name \".env*\" -type f | grep -q .; then",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2257407472",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36254,
|
|
"pr_file": "bin/posthog-worktree",
|
|
"discussion_id": "2257407472",
|
|
"commented_code": "@@ -183,6 +183,19 @@ setup_worktree_environment() {\n cp \"${main_repo}/.flox/env/manifest.toml\" \"${worktree_path}/.flox/env/\"\n cp \"${main_repo}/.envrc\" \"${worktree_path}/\"\n \n+ # Copy .vscode/settings.json if it exists\n+ if [[ -f \"${main_repo}/.vscode/settings.json\" ]]; then\n+ print_color blue \"Copying .vscode/settings.json\u2026\"\n+ mkdir -p \"${worktree_path}/.vscode\"\n+ cp \"${main_repo}/.vscode/settings.json\" \"${worktree_path}/.vscode/\"\n+ fi\n+ \n+ # Copy any .env files if they exist\n+ if find \"${main_repo}\" -maxdepth 1 -name \".env*\" -type f | grep -q .; then",
|
|
"comment_created_at": "2025-08-06T14:35:16+00:00",
|
|
"comment_author": "haacked",
|
|
"comment_body": "Should this be more strict and copy `.env` and `.env.*`?",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2257417700",
|
|
"repo_full_name": "PostHog/posthog",
|
|
"pr_number": 36254,
|
|
"pr_file": "bin/posthog-worktree",
|
|
"discussion_id": "2257407472",
|
|
"commented_code": "@@ -183,6 +183,19 @@ setup_worktree_environment() {\n cp \"${main_repo}/.flox/env/manifest.toml\" \"${worktree_path}/.flox/env/\"\n cp \"${main_repo}/.envrc\" \"${worktree_path}/\"\n \n+ # Copy .vscode/settings.json if it exists\n+ if [[ -f \"${main_repo}/.vscode/settings.json\" ]]; then\n+ print_color blue \"Copying .vscode/settings.json\u2026\"\n+ mkdir -p \"${worktree_path}/.vscode\"\n+ cp \"${main_repo}/.vscode/settings.json\" \"${worktree_path}/.vscode/\"\n+ fi\n+ \n+ # Copy any .env files if they exist\n+ if find \"${main_repo}\" -maxdepth 1 -name \".env*\" -type f | grep -q .; then",
|
|
"comment_created_at": "2025-08-06T14:38:37+00:00",
|
|
"comment_author": "kappa90",
|
|
"comment_body": "Updated :)",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
}
|
|
] |