mirror of
https://github.com/baz-scm/awesome-reviewers.git
synced 2025-08-20 18:58:52 +03:00
46 lines
4.7 KiB
JSON
46 lines
4.7 KiB
JSON
[
|
|
{
|
|
"discussion_id": "396624797",
|
|
"pr_number": 3171,
|
|
"pr_file": ".github/ISSUE_TEMPLATE/---bug-report.md",
|
|
"created_at": "2020-03-23T17:25:09+00:00",
|
|
"commented_code": "* For browsers, the SDK version number is in the script tag <pre>src=\".../aws-sdk-<b>2.466.0</b>.min.js\"</pre>\n* For Node.js, get SDK version by\n * running command `npm list aws-sdk` from your root directory\n * printing the output of `AWS.VERSION` in your code where `AWS = require(\"aws-sdk\");`\n * printing the output of `console.log(AWS.VERSION)` in your code where `AWS = require(\"aws-sdk\");`\n * if running on Lambda, Lambda runtimes can be found [here](https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html)",
|
|
"repo_full_name": "aws/aws-sdk-js",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "396624797",
|
|
"repo_full_name": "aws/aws-sdk-js",
|
|
"pr_number": 3171,
|
|
"pr_file": ".github/ISSUE_TEMPLATE/---bug-report.md",
|
|
"discussion_id": "396624797",
|
|
"commented_code": "@@ -28,7 +28,8 @@ Example: v2.466.0\n * For browsers, the SDK version number is in the script tag <pre>src=\".../aws-sdk-<b>2.466.0</b>.min.js\"</pre>\n * For Node.js, get SDK version by\n * running command `npm list aws-sdk` from your root directory\n- * printing the output of `AWS.VERSION` in your code where `AWS = require(\"aws-sdk\");`\n+ * printing the output of `console.log(AWS.VERSION)` in your code where `AWS = require(\"aws-sdk\");`\n+ * if running on Lambda, Lambda runtimes can be found [here](https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html) ",
|
|
"comment_created_at": "2020-03-23T17:25:09+00:00",
|
|
"comment_author": "AllanZhengYP",
|
|
"comment_body": "People can bundle their own AWS to the Lambda. You can ask something like `If running on Lambda and using SDK provided by Lambda runtime, you can find the SDK versions here`",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "297439672",
|
|
"pr_number": 2742,
|
|
"pr_file": ".github/ISSUE_TEMPLATE/---known-issues.md",
|
|
"created_at": "2019-06-26T00:00:43+00:00",
|
|
"commented_code": "---\nname: \"\\U0001F6E0 Know issues\"\nabout: Read me before opening an issue!\ntitle: ''\nassignees: ''\n\n---\n\nThis is a list of know issues and how can you work around them:\n\n1. **Exceptions contains `Unexpected key...` or `... is not a function`**\n\n AWS APIs are updating constantly, you might be calling a new API with an older version is SDK. In\n this case you should try installing the newest `aws-sdk`like: \n\n `npm install aws-sdk@latest`\n\n If you are using the SDK in AWS Lambda, you are likely using old SDK version too. AWS Lambda bundled\n SDK version is shown in [this document](https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html).\n You can import the latest version of SDK by following \n [these guidelines](https://docs.aws.amazon.com/lambda/latest/dg/nodejs-create-deployment-pkg.html#nodejs-package-dependencies).\n\n Go ahead and open an issue is you are still seeing this exception.",
|
|
"repo_full_name": "aws/aws-sdk-js",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "297439672",
|
|
"repo_full_name": "aws/aws-sdk-js",
|
|
"pr_number": 2742,
|
|
"pr_file": ".github/ISSUE_TEMPLATE/---known-issues.md",
|
|
"discussion_id": "297439672",
|
|
"commented_code": "@@ -0,0 +1,23 @@\n+---\n+name: \"\\U0001F6E0 Know issues\"\n+about: Read me before opening an issue!\n+title: ''\n+assignees: ''\n+\n+---\n+\n+This is a list of know issues and how can you work around them:\n+\n+1. **Exceptions contains `Unexpected key...` or `... is not a function`**\n+\n+ AWS APIs are updating constantly, you might be calling a new API with an older version is SDK. In\n+ this case you should try installing the newest `aws-sdk`like: \n+\n+ `npm install aws-sdk@latest`\n+\n+ If you are using the SDK in AWS Lambda, you are likely using old SDK version too. AWS Lambda bundled\n+ SDK version is shown in [this document](https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html).\n+ You can import the latest version of SDK by following \n+ [these guidelines](https://docs.aws.amazon.com/lambda/latest/dg/nodejs-create-deployment-pkg.html#nodejs-package-dependencies).\n+\n+ Go ahead and open an issue is you are still seeing this exception.",
|
|
"comment_created_at": "2019-06-26T00:00:43+00:00",
|
|
"comment_author": "trivikr",
|
|
"comment_body": "```suggestion\r\nIf you still like to open an issue, change [ ] to [x] below:\r\n- [ ] I've confirmed that I'm using latest version of SDK, and issue is still reproducible\r\n```",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
}
|
|
] |