Files
awesome-reviewers/_reviewers/azure-sdk-for-net-address-not-mask.json
2025-07-03 10:48:16 +03:00

58 lines
3.6 KiB
JSON
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

[
{
"discussion_id": "2164733100",
"pr_number": 50834,
"pr_file": "sdk/netapp/Azure.ResourceManager.NetApp/src/Azure.ResourceManager.NetApp.csproj",
"created_at": "2025-06-24T19:20:37+00:00",
"commented_code": "<Project Sdk=\"Microsoft.NET.Sdk\">\n<Project Sdk=\"Microsoft.NET.Sdk\">",
"repo_full_name": "Azure/azure-sdk-for-net",
"discussion_comments": [
{
"comment_id": "2164733100",
"repo_full_name": "Azure/azure-sdk-for-net",
"pr_number": 50834,
"pr_file": "sdk/netapp/Azure.ResourceManager.NetApp/src/Azure.ResourceManager.NetApp.csproj",
"discussion_id": "2164733100",
"commented_code": "@@ -1,6 +1,6 @@\n-<Project Sdk=\"Microsoft.NET.Sdk\">\n+<Project Sdk=\"Microsoft.NET.Sdk\">",
"comment_created_at": "2025-06-24T19:20:37+00:00",
"comment_author": "Copilot",
"comment_body": "There is a hidden BOM character at the start of the file. Removing it will prevent encoding-related issues in CI and editors.\n```suggestion\n<Project Sdk=\"Microsoft.NET.Sdk\">\n```",
"pr_file_module": null
}
]
},
{
"discussion_id": "2151210517",
"pr_number": 49826,
"pr_file": "sdk/managednetworkfabric/Azure.ResourceManager.ManagedNetworkFabric/src/Azure.ResourceManager.ManagedNetworkFabric.csproj",
"created_at": "2025-06-17T02:43:55+00:00",
"commented_code": "<Project Sdk=\"Microsoft.NET.Sdk\">\n<Project Sdk=\"Microsoft.NET.Sdk\">\n <PropertyGroup>\n <Version>1.2.0-beta.1</Version>\n <!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->\n <ApiCompatVersion>1.1.2</ApiCompatVersion>",
"repo_full_name": "Azure/azure-sdk-for-net",
"discussion_comments": [
{
"comment_id": "2151210517",
"repo_full_name": "Azure/azure-sdk-for-net",
"pr_number": 49826,
"pr_file": "sdk/managednetworkfabric/Azure.ResourceManager.ManagedNetworkFabric/src/Azure.ResourceManager.ManagedNetworkFabric.csproj",
"discussion_id": "2151210517",
"commented_code": "@@ -1,10 +1,8 @@\n-<Project Sdk=\"Microsoft.NET.Sdk\">\n+<Project Sdk=\"Microsoft.NET.Sdk\">\n <PropertyGroup>\n <Version>1.2.0-beta.1</Version>\n- <!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->\n- <ApiCompatVersion>1.1.2</ApiCompatVersion>",
"comment_created_at": "2025-06-17T02:43:55+00:00",
"comment_author": "ArcturusZhang",
"comment_body": "I believe you have met build failures about the apicompat and found out removing this would \"fix\" the error.\r\nBut this is only hiding the issue instead of resolving it.\r\nPlease revert this back and let the pipeline fails. We will find other ways to introduce real fixes to those errors.",
"pr_file_module": null
},
{
"comment_id": "2152337212",
"repo_full_name": "Azure/azure-sdk-for-net",
"pr_number": 49826,
"pr_file": "sdk/managednetworkfabric/Azure.ResourceManager.ManagedNetworkFabric/src/Azure.ResourceManager.ManagedNetworkFabric.csproj",
"discussion_id": "2151210517",
"commented_code": "@@ -1,10 +1,8 @@\n-<Project Sdk=\"Microsoft.NET.Sdk\">\n+<Project Sdk=\"Microsoft.NET.Sdk\">\n <PropertyGroup>\n <Version>1.2.0-beta.1</Version>\n- <!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->\n- <ApiCompatVersion>1.1.2</ApiCompatVersion>",
"comment_created_at": "2025-06-17T13:51:09+00:00",
"comment_author": "nafizhaider32",
"comment_body": "done",
"pr_file_module": null
}
]
}
]