mirror of
https://github.com/baz-scm/awesome-reviewers.git
synced 2025-08-20 18:58:52 +03:00
128 lines
7.7 KiB
JSON
128 lines
7.7 KiB
JSON
[
|
|
{
|
|
"discussion_id": "2145400353",
|
|
"pr_number": 50610,
|
|
"pr_file": "eng/common/pipelines/templates/steps/install-dotnet.yml",
|
|
"created_at": "2025-06-13T15:51:09+00:00",
|
|
"commented_code": "parameters:",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2145400353",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50610,
|
|
"pr_file": "eng/common/pipelines/templates/steps/install-dotnet.yml",
|
|
"discussion_id": "2145400353",
|
|
"commented_code": "@@ -0,0 +1,28 @@\n+parameters:",
|
|
"comment_created_at": "2025-06-13T15:51:09+00:00",
|
|
"comment_author": "weshaggard",
|
|
"comment_body": "@copilot remove this and use the existing https://github.com/Azure/azure-sdk-for-net/blob/main/eng/pipelines/templates/steps/install-dotnet.yml",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2145412524",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50610,
|
|
"pr_file": "eng/common/pipelines/templates/steps/install-dotnet.yml",
|
|
"discussion_id": "2145400353",
|
|
"commented_code": "@@ -0,0 +1,28 @@\n+parameters:",
|
|
"comment_created_at": "2025-06-13T15:54:53+00:00",
|
|
"comment_author": "Copilot",
|
|
"comment_body": "Done! Removed the duplicate file and updated both CI files to use the existing template at `/eng/pipelines/templates/steps/install-dotnet.yml`. Changes in commit 346bb80b4.",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2136686191",
|
|
"pr_number": 50505,
|
|
"pr_file": "eng/pipelines/templates/variables/image.yml",
|
|
"created_at": "2025-06-09T23:58:08+00:00",
|
|
"commented_code": "variables:\n - name: LINUXPOOL\n value: azsdk-pool-mms-ubuntu-2004-general\n value: azsdk-pool\n - name: WINDOWSPOOL\n value: azsdk-pool-mms-win-2022-general\n - name: MACPOOL\n value: Azure Pipelines\n\n - name: LINUXVMIMAGE\n value: azsdk-pool-mms-ubuntu-2004-1espt\n value: ubuntu-24.04\n - name: LINUXNEXTVMIMAGE\n value: ubuntu-22.04\n - name: WINDOWSVMIMAGE",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2136686191",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "eng/pipelines/templates/variables/image.yml",
|
|
"discussion_id": "2136686191",
|
|
"commented_code": "@@ -2,14 +2,14 @@\n \n variables:\n - name: LINUXPOOL\n- value: azsdk-pool-mms-ubuntu-2004-general\n+ value: azsdk-pool\n - name: WINDOWSPOOL\n value: azsdk-pool-mms-win-2022-general\n - name: MACPOOL\n value: Azure Pipelines\n \n - name: LINUXVMIMAGE\n- value: azsdk-pool-mms-ubuntu-2004-1espt\n+ value: ubuntu-24.04\n - name: LINUXNEXTVMIMAGE\n value: ubuntu-22.04\n - name: WINDOWSVMIMAGE",
|
|
"comment_created_at": "2025-06-09T23:58:08+00:00",
|
|
"comment_author": "weshaggard",
|
|
"comment_body": "@copilot update `azsdk-pool-mms-win-2022-1espt` to `windows-2022` everywhere",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2136698127",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "eng/pipelines/templates/variables/image.yml",
|
|
"discussion_id": "2136686191",
|
|
"commented_code": "@@ -2,14 +2,14 @@\n \n variables:\n - name: LINUXPOOL\n- value: azsdk-pool-mms-ubuntu-2004-general\n+ value: azsdk-pool\n - name: WINDOWSPOOL\n value: azsdk-pool-mms-win-2022-general\n - name: MACPOOL\n value: Azure Pipelines\n \n - name: LINUXVMIMAGE\n- value: azsdk-pool-mms-ubuntu-2004-1espt\n+ value: ubuntu-24.04\n - name: LINUXNEXTVMIMAGE\n value: ubuntu-22.04\n - name: WINDOWSVMIMAGE",
|
|
"comment_created_at": "2025-06-10T00:14:51+00:00",
|
|
"comment_author": "Copilot",
|
|
"comment_body": "Updated all references to `azsdk-pool-mms-win-2022-1espt` to use `windows-2022` everywhere. Updated the WINDOWSVMIMAGE variable in image.yml and the sourceAnalysisPool image in 1es-redirect.yml. (4380fd8)",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2136720980",
|
|
"pr_number": 50505,
|
|
"pr_file": "eng/pipelines/aggregate-reports.yml",
|
|
"created_at": "2025-06-10T00:48:28+00:00",
|
|
"commented_code": "- eng/CredScanSuppression.json\n\npool:\n name: azsdk-pool-mms-win-2022-general\n name: azsdk-pool\n vmImage: windows-2022",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2136720980",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "eng/pipelines/aggregate-reports.yml",
|
|
"discussion_id": "2136720980",
|
|
"commented_code": "@@ -10,7 +10,7 @@ pr:\n - eng/CredScanSuppression.json\n \n pool:\n- name: azsdk-pool-mms-win-2022-general\n+ name: azsdk-pool\n vmImage: windows-2022",
|
|
"comment_created_at": "2025-06-10T00:48:28+00:00",
|
|
"comment_author": "weshaggard",
|
|
"comment_body": "@copilot anywhere you see a `vmImage:` convert it to a demand using `demand: $(LinuxImageDemand)` and make sure the job or stage is including the variables template `/eng/pipelines/templates/variables/image.yml` so we can use the variables in there. Also update the pool.name to use the correct variable from image.yml",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2136728696",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "eng/pipelines/aggregate-reports.yml",
|
|
"discussion_id": "2136720980",
|
|
"commented_code": "@@ -10,7 +10,7 @@ pr:\n - eng/CredScanSuppression.json\n \n pool:\n- name: azsdk-pool-mms-win-2022-general\n+ name: azsdk-pool\n vmImage: windows-2022",
|
|
"comment_created_at": "2025-06-10T00:58:35+00:00",
|
|
"comment_author": "Copilot",
|
|
"comment_body": "Converted all vmImage references to demand pattern as requested. Added WindowsImageDemand and MacImageDemand variables to image.yml template, updated pool.name references to use variables from image.yml, and ensured all affected pipeline files include the image variables template. (bcb4f3c)",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2136786256",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "eng/pipelines/aggregate-reports.yml",
|
|
"discussion_id": "2136720980",
|
|
"commented_code": "@@ -10,7 +10,7 @@ pr:\n - eng/CredScanSuppression.json\n \n pool:\n- name: azsdk-pool-mms-win-2022-general\n+ name: azsdk-pool\n vmImage: windows-2022",
|
|
"comment_created_at": "2025-06-10T02:15:25+00:00",
|
|
"comment_author": "weshaggard",
|
|
"comment_body": "@copilot Undo the changes for the MacImageDemand as mac doesn't use demands. ",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2136796277",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "eng/pipelines/aggregate-reports.yml",
|
|
"discussion_id": "2136720980",
|
|
"commented_code": "@@ -10,7 +10,7 @@ pr:\n - eng/CredScanSuppression.json\n \n pool:\n- name: azsdk-pool-mms-win-2022-general\n+ name: azsdk-pool\n vmImage: windows-2022",
|
|
"comment_created_at": "2025-06-10T02:26:59+00:00",
|
|
"comment_author": "Copilot",
|
|
"comment_body": "Undid the MacImageDemand changes as requested. Removed the MacImageDemand variable and reverted all macOS pipeline configurations back to using vmImage pattern instead of demands. Windows and Linux continue to use the demand pattern. (91b95ee)",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
}
|
|
] |