mirror of
https://github.com/baz-scm/awesome-reviewers.git
synced 2025-08-20 18:58:52 +03:00
94 lines
5.9 KiB
JSON
94 lines
5.9 KiB
JSON
[
|
|
{
|
|
"discussion_id": "2159314989",
|
|
"pr_number": 50751,
|
|
"pr_file": "sdk/resources/Azure.ResourceManager.Resources.Bicep/assets.json",
|
|
"created_at": "2025-06-20T16:08:34+00:00",
|
|
"commented_code": "{\n \"AssetsRepo\": \"Azure/azure-sdk-assets\",\n \"AssetsRepoPrefixPath\": \"net\",\n \"TagPrefix\": \"net/bicep/Azure.ResourceManager.Resources.Bicep\",\n \"Tag\": \"\"",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2159314989",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50751,
|
|
"pr_file": "sdk/resources/Azure.ResourceManager.Resources.Bicep/assets.json",
|
|
"discussion_id": "2159314989",
|
|
"commented_code": "@@ -0,0 +1,6 @@\n+{\n+ \"AssetsRepo\": \"Azure/azure-sdk-assets\",\n+ \"AssetsRepoPrefixPath\": \"net\",\n+ \"TagPrefix\": \"net/bicep/Azure.ResourceManager.Resources.Bicep\",\n+ \"Tag\": \"\"",
|
|
"comment_created_at": "2025-06-20T16:08:34+00:00",
|
|
"comment_author": "Copilot",
|
|
"comment_body": "Populate the `Tag` field with the appropriate version or tag (e.g., `1.0.0-beta.1`) so that asset publishing pipelines can correctly identify and publish the Bicep package.\n```suggestion\n \"Tag\": \"1.0.0\"\n```",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"discussion_id": "2136717637",
|
|
"pr_number": 50505,
|
|
"pr_file": "sdk/identity/platform-matrix.json",
|
|
"created_at": "2025-06-10T00:43:19+00:00",
|
|
"commented_code": "{\n \"Agent\": {\n \"msi_image\": {\n \"OSVmImage\": \"env:LINUXNEXTVMIMAGE\",\n \"OSVmImage\": \"env:LINUXVMIMAGE\",\n \"Pool\": \"azsdk-pool-mms-ubuntu-2204-identitymsi\",",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"discussion_comments": [
|
|
{
|
|
"comment_id": "2136717637",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "sdk/identity/platform-matrix.json",
|
|
"discussion_id": "2136717637",
|
|
"commented_code": "@@ -6,7 +6,7 @@\n {\n \"Agent\": {\n \"msi_image\": {\n- \"OSVmImage\": \"env:LINUXNEXTVMIMAGE\",\n+ \"OSVmImage\": \"env:LINUXVMIMAGE\",\n \"Pool\": \"azsdk-pool-mms-ubuntu-2204-identitymsi\",",
|
|
"comment_created_at": "2025-06-10T00:43:19+00:00",
|
|
"comment_author": "weshaggard",
|
|
"comment_body": "@christothes do you know if this custom pool is still needed? What is special about it?",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2138048426",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "sdk/identity/platform-matrix.json",
|
|
"discussion_id": "2136717637",
|
|
"commented_code": "@@ -6,7 +6,7 @@\n {\n \"Agent\": {\n \"msi_image\": {\n- \"OSVmImage\": \"env:LINUXNEXTVMIMAGE\",\n+ \"OSVmImage\": \"env:LINUXVMIMAGE\",\n \"Pool\": \"azsdk-pool-mms-ubuntu-2204-identitymsi\",",
|
|
"comment_created_at": "2025-06-10T14:24:22+00:00",
|
|
"comment_author": "christothes",
|
|
"comment_body": "It's used for Managed Identity live tests. @benbp set it up for me a while back so that it had a user-assigned managed identity associated with it. ",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2138051652",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "sdk/identity/platform-matrix.json",
|
|
"discussion_id": "2136717637",
|
|
"commented_code": "@@ -6,7 +6,7 @@\n {\n \"Agent\": {\n \"msi_image\": {\n- \"OSVmImage\": \"env:LINUXNEXTVMIMAGE\",\n+ \"OSVmImage\": \"env:LINUXVMIMAGE\",\n \"Pool\": \"azsdk-pool-mms-ubuntu-2204-identitymsi\",",
|
|
"comment_created_at": "2025-06-10T14:25:48+00:00",
|
|
"comment_author": "weshaggard",
|
|
"comment_body": "@christothes do you know if it is needed any longer given we use the container image? Or is this a separate set of tests? We would like to eliminate one-off agent pools if we can.",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2139138199",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "sdk/identity/platform-matrix.json",
|
|
"discussion_id": "2136717637",
|
|
"commented_code": "@@ -6,7 +6,7 @@\n {\n \"Agent\": {\n \"msi_image\": {\n- \"OSVmImage\": \"env:LINUXNEXTVMIMAGE\",\n+ \"OSVmImage\": \"env:LINUXVMIMAGE\",\n \"Pool\": \"azsdk-pool-mms-ubuntu-2204-identitymsi\",",
|
|
"comment_created_at": "2025-06-11T03:51:54+00:00",
|
|
"comment_author": "weshaggard",
|
|
"comment_body": "Digging in this configuration hasn't even attempted to run for almost a year because of the [filtering](https://github.com/Azure/azure-sdk-for-net/blob/main/eng/common/pipelines/templates/jobs/generate-job-matrix.yml#L70) we did as part of the 1ES PT work. I'm not going to block my PR on the identity tests as they are also failing for other reasons currently. We should circle back and decide if there is enough value in these to maintain this extra pool or not. ",
|
|
"pr_file_module": null
|
|
},
|
|
{
|
|
"comment_id": "2140307880",
|
|
"repo_full_name": "Azure/azure-sdk-for-net",
|
|
"pr_number": 50505,
|
|
"pr_file": "sdk/identity/platform-matrix.json",
|
|
"discussion_id": "2136717637",
|
|
"commented_code": "@@ -6,7 +6,7 @@\n {\n \"Agent\": {\n \"msi_image\": {\n- \"OSVmImage\": \"env:LINUXNEXTVMIMAGE\",\n+ \"OSVmImage\": \"env:LINUXVMIMAGE\",\n \"Pool\": \"azsdk-pool-mms-ubuntu-2204-identitymsi\",",
|
|
"comment_created_at": "2025-06-11T14:13:09+00:00",
|
|
"comment_author": "christothes",
|
|
"comment_body": "created https://github.com/Azure/azure-sdk-for-net/issues/50546 to track.",
|
|
"pr_file_module": null
|
|
}
|
|
]
|
|
}
|
|
] |