From 1fa4e8a385ba34cda5ee6907a2d15aa31c24a675 Mon Sep 17 00:00:00 2001 From: Andrey Nering Date: Mon, 30 Jun 2025 17:32:37 -0300 Subject: [PATCH] ci: fix linting --- cmd/root.go | 12 ++++++------ internal/db/connect.go | 7 ++++--- internal/history/file.go | 2 +- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/cmd/root.go b/cmd/root.go index 7832da98..2b5f79cf 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -77,16 +77,16 @@ to assist developers in writing, debugging, and understanding code directly from return err } - // Connect DB, this will also run migrations - conn, err := db.Connect() - if err != nil { - return err - } - // Create main context for the application ctx, cancel := context.WithCancel(context.Background()) defer cancel() + // Connect DB, this will also run migrations + conn, err := db.Connect(ctx) + if err != nil { + return err + } + app, err := app.New(ctx, conn) if err != nil { logging.Error("Failed to create app: %v", err) diff --git a/internal/db/connect.go b/internal/db/connect.go index ed48ddcb..9212ce1f 100644 --- a/internal/db/connect.go +++ b/internal/db/connect.go @@ -1,6 +1,7 @@ package db import ( + "context" "database/sql" "fmt" "os" @@ -15,7 +16,7 @@ import ( "github.com/pressly/goose/v3" ) -func Connect() (*sql.DB, error) { +func Connect(ctx context.Context) (*sql.DB, error) { dataDir := config.Get().Data.Directory if dataDir == "" { return nil, fmt.Errorf("data.dir is not set") @@ -31,7 +32,7 @@ func Connect() (*sql.DB, error) { } // Verify connection - if err = db.Ping(); err != nil { + if err = db.PingContext(ctx); err != nil { db.Close() return nil, fmt.Errorf("failed to connect to database: %w", err) } @@ -46,7 +47,7 @@ func Connect() (*sql.DB, error) { } for _, pragma := range pragmas { - if _, err = db.Exec(pragma); err != nil { + if _, err = db.ExecContext(ctx, pragma); err != nil { logging.Error("Failed to set pragma", pragma, err) } else { logging.Debug("Set pragma", "pragma", pragma) diff --git a/internal/history/file.go b/internal/history/file.go index d8fe6088..7317f012 100644 --- a/internal/history/file.go +++ b/internal/history/file.go @@ -83,7 +83,7 @@ func (s *service) createWithVersion(ctx context.Context, sessionID, path, conten // Retry loop for transaction conflicts for attempt := range maxRetries { // Start a transaction - tx, txErr := s.db.Begin() + tx, txErr := s.db.BeginTx(ctx, nil) if txErr != nil { return File{}, fmt.Errorf("failed to begin transaction: %w", txErr) }