review feedback

This commit is contained in:
Owen Cliffe
2017-09-06 15:05:47 +01:00
parent 33060bcb9e
commit 3a231d6296

View File

@@ -103,10 +103,10 @@ func FromRequest(appName, path string, req *http.Request) CallOpt {
envVars[toEnvName("PARAM", param.Key)] = param.Value
}
var headerVars = make(map[string]string)
headerVars := make(map[string]string,len(req.Header))
for k, v := range req.Header {
joinedHeader := strings.Join(v,",")
headerVars[toEnvName("HEADER",k)] = joinedHeader
headerVars[toEnvName("HEADER",k)] = strings.Join(v, ", ")
}
// add all the env vars we build to the request headers
@@ -119,8 +119,6 @@ func FromRequest(appName, path string, req *http.Request) CallOpt {
envVars[k] = v
}
// TODO this relies on ordering of opts, but tests make sure it works, probably re-plumb/destroy headers
if rw, ok := c.w.(http.ResponseWriter); ok {
rw.Header().Add("FN_CALL_ID", id)