alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Check runner connection before sending requests (#831)

Browse Source 
If a runner disconnect not gracefully it could happen that the
connection gets stuck in connecting mode, this change verifies the state
of the connection before starting to execute a call, if the client
connection is not ready we fail fast to give a change to the next runner
(if any) to execute the call.
This commit is contained in:
Andrea Rosa
2018-03-12 09:38:27 +00:00
committed by GitHub
parent 47383d9ff7
commit 43547a572f
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
api/agent/nodepool/grpc/grpc_pool.go
View File

@@ -9,6 +9,7 @@ import (
"time" "time"
"google.golang.org/grpc" "google.golang.org/grpc"
"google.golang.org/grpc/connectivity"
"google.golang.org/grpc/credentials" "google.golang.org/grpc/credentials"
"github.com/fnproject/fn/api/agent" "github.com/fnproject/fn/api/agent"
@@ -281,6 +282,15 @@ func (r *gRPCRunner) TryExec(ctx context.Context, call agent.Call) (bool, error)
logrus.WithField("runner_addr", r.address).Debug("Attempting to place call") logrus.WithField("runner_addr", r.address).Debug("Attempting to place call")
r.wg.Add(1) r.wg.Add(1)
defer r.wg.Done() defer r.wg.Done()
// If the connection is not READY, we want to fail-fast.
// There are some cases where the connection stays in CONNECTING, for example if the
// runner dies not gracefully (e.g. unplug the cable), the connection get stuck until
// the context times out.
// https://github.com/grpc/grpc/blob/master/doc/connectivity-semantics-and-api.md
if r.conn.GetState() != connectivity.Ready {
logrus.WithField("runner_address", r.address).Debug("Runner connection is not ready")
return false, nil
}
// Get app and route information // Get app and route information
// Construct model.Call with CONFIG in it already // Construct model.Call with CONFIG in it already