mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
Stream test commence (#1224)
* initial invoke testing this assures that Content-Type and Fn-Http-Status are set for an http-stream function. it took some fixing up of the test utils code for the plumbing to work, looking forward to deleting most stuff in fn-test-utils.go file around each format -- had to update fdk-go to latest for http-stream support. this only adds 1 test, since there's some machinery here, and would like to unblock working on the http gateway simultaneously while adding a full suite of invoke tests (this work can be parallelized)... i added debug logs back to the debugging output. turns out this is useful, but it can get noisy (only when things fail, hopefully). * fix oom tests?
This commit is contained in:
@@ -64,9 +64,9 @@ func FromHTTPTriggerRequest(app *models.App, fn *models.Fn, trigger *models.Trig
|
||||
// Expected Content-Type for a CloudEvent: application/cloudevents+json; charset=UTF-8
|
||||
contentType := req.Header.Get("Content-Type")
|
||||
t, _, err := mime.ParseMediaType(contentType)
|
||||
if err != nil {
|
||||
if err != nil && contentType != "" {
|
||||
// won't fail here, but log
|
||||
log.Debugf("Could not parse Content-Type header: %v", err)
|
||||
log.Debugf("Could not parse Content-Type header: %v %v", contentType, err)
|
||||
} else {
|
||||
if t == ceMimeType {
|
||||
c.IsCloudEvent = true
|
||||
@@ -135,9 +135,9 @@ func FromHTTPFnRequest(app *models.App, fn *models.Fn, req *http.Request) CallOp
|
||||
// Expected Content-Type for a CloudEvent: application/cloudevents+json; charset=UTF-8
|
||||
contentType := req.Header.Get("Content-Type")
|
||||
t, _, err := mime.ParseMediaType(contentType)
|
||||
if err != nil {
|
||||
if err != nil && contentType != "" {
|
||||
// won't fail here, but log
|
||||
log.Debugf("Could not parse Content-Type header: %v", err)
|
||||
log.Debugf("Could not parse Content-Type header: %v %v", contentType, err)
|
||||
} else {
|
||||
if t == ceMimeType {
|
||||
c.IsCloudEvent = true
|
||||
|
||||
Reference in New Issue
Block a user