mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
Simplifying app delete per review comments
This commit is contained in:
@@ -28,7 +28,6 @@ type Datastore interface {
|
||||
|
||||
// RemoveApp removes the App named appName. Returns ErrDatastoreEmptyAppName if appName is empty.
|
||||
// Returns ErrAppsNotFound if an App is not found.
|
||||
// TODO remove routes automatically? #528
|
||||
RemoveApp(ctx context.Context, appName string) error
|
||||
|
||||
// GetRoute looks up a matching Route for appName and the literal request route routePath.
|
||||
@@ -68,8 +67,6 @@ type Datastore interface {
|
||||
// calls exist, an empty list and a nil error are returned.
|
||||
GetCalls(ctx context.Context, filter *CallFilter) ([]*Call, error)
|
||||
|
||||
BatchDeleteCalls(ctx context.Context, appName string) error
|
||||
BatchDeleteRoutes(ctx context.Context, appName string) error
|
||||
// Implement LogStore methods for convenience
|
||||
LogStore
|
||||
|
||||
|
||||
@@ -20,6 +20,4 @@ type LogStore interface {
|
||||
// DeleteLog will remove the log at callID, it will not return an error if
|
||||
// the log does not exist before removal.
|
||||
DeleteLog(ctx context.Context, appName, callID string) error
|
||||
|
||||
BatchDeleteLogs(ctx context.Context, appName string) error
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user