From 72a2eb933f30d3659765eab85d68123dc7a25ce3 Mon Sep 17 00:00:00 2001 From: Andrea Rosa Date: Fri, 30 Mar 2018 18:15:55 +0200 Subject: [PATCH] Returning Agent on exported func for pureRunner (#905) pureRunner is a not exported struct and it was set as return value for few exported method, in this change we return Agent which is the interface implemented by pureRunner to avoid to leak an unexprted type. --- api/agent/pure_runner.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/api/agent/pure_runner.go b/api/agent/pure_runner.go index 73168a912..e37a4c4a6 100644 --- a/api/agent/pure_runner.go +++ b/api/agent/pure_runner.go @@ -554,15 +554,15 @@ func (pr *pureRunner) Start() error { return err } -func UnsecuredPureRunner(cancel context.CancelFunc, addr string, da DataAccess) (*pureRunner, error) { +func UnsecuredPureRunner(cancel context.CancelFunc, addr string, da DataAccess) (Agent, error) { return NewPureRunner(cancel, addr, da, "", "", "", nil) } -func DefaultPureRunner(cancel context.CancelFunc, addr string, da DataAccess, cert string, key string, ca string) (*pureRunner, error) { +func DefaultPureRunner(cancel context.CancelFunc, addr string, da DataAccess, cert string, key string, ca string) (Agent, error) { return NewPureRunner(cancel, addr, da, cert, key, ca, nil) } -func NewPureRunner(cancel context.CancelFunc, addr string, da DataAccess, cert string, key string, ca string, gate CapacityGate) (*pureRunner, error) { +func NewPureRunner(cancel context.CancelFunc, addr string, da DataAccess, cert string, key string, ca string, gate CapacityGate) (Agent, error) { a := createAgent(da, true) var pr *pureRunner var err error