alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Split queries to make them work on Postgres and MySQL

Browse Source 
Only SQLite supports multiple deletes in one transaction/statement,
 but other are not.
This commit is contained in:
Denis Makogon
2017-09-21 00:52:33 +03:00
parent 0280df0cdf
commit 7a9591fd45
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
api/datastore/sql/sql.go
View File

@@ -222,10 +222,7 @@ func (ds *sqlStore) UpdateApp(ctx context.Context, newapp *models.App) (*models.
func (ds *sqlStore) RemoveApp(ctx context.Context, appName string) error {
res, err := ds.db.ExecContext(ctx, ds.db.Rebind(
`DELETE FROM apps WHERE name = ?;
DELETE FROM logs WHERE app_name=?;
DELETE FROM calls WHERE app_name=?;
DELETE FROM routes WHERE app_name=?;`), appName, appName, appName, appName)
`DELETE FROM apps WHERE name = ?`), appName)
if err != nil {
return err
}
@@ -233,8 +230,22 @@ func (ds *sqlStore) RemoveApp(ctx context.Context, appName string) error {
if err == sql.ErrNoRows {
return models.ErrAppsNotFound
}
deletes := []string{
`DELETE FROM logs WHERE app_name=?`,
`DELETE FROM calls WHERE app_name=?`,
`DELETE FROM routes WHERE app_name=?`,
}
for _, stmt := range deletes {
_, err = ds.db.ExecContext(ctx, ds.db.Rebind(stmt), appName)
if err != nil {
return err
}
}
return nil
}
func (ds *sqlStore) GetApp(ctx context.Context, name string) (*models.App, error) {
query := ds.db.Rebind(`SELECT name, config FROM apps WHERE name=?`)