alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

fn: hot container launcher adjustment (#673)

Browse Source 
Latency stats are not always read-time updated and
if calls are stuck in waiting state, isNewContainerNeeded()
needs to be a bit more aggresive if the wait queue grows.
This commit is contained in:
Tolga Ceylan
2018-01-10 14:14:19 -08:00
committed by Reed Allman
parent 5608f05290
commit 7c91b98a72
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
api/agent/slots.go
View File

@@ -204,12 +204,24 @@ func (a *slotQueue) isNewContainerNeeded() (bool, slotQueueStats) {
return false, stats
}
// no executors? Start a container now.
// this is a bit aggresive and assumes that we only
// want to queue as much as num of containers.
executors := starters + stats.states[SlotQueueRunner]
if executors == 0 {
if executors < waiters {
return true, stats
}
// WARNING: Below is a few heuristics that are
// speculative, which may (and will) likely need
// adjustments.
// WARNING: latencies below are updated after a call
// switches to/from different states. Do not assume
// the metrics below are always up-to-date. For example,
// a sudden burst of incoming requests will increase
// waiter count but not necessarily wait latency until
// those requests switch from waiter state.
runLat := stats.latencies[SlotQueueRunner]
waitLat := stats.latencies[SlotQueueWaiter]
startLat := stats.latencies[SlotQueueStarter]