mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
Addresing new comments
This commit is contained in:
@@ -287,7 +287,10 @@ func (c *call) End(ctx context.Context, err error) {
|
||||
// XXX (reed): delete MQ message, eventually
|
||||
}
|
||||
|
||||
if err := c.ds.InsertCall(opentracing.ContextWithSpan(ctx, span), c.Call); err != nil {
|
||||
// this means that we could potentially store an error / timeout status for a
|
||||
// call that ran successfully [by a user's perspective]
|
||||
// TODO: this should be update, really
|
||||
if err := c.ds.InsertCall(ctx, c.Call); err != nil {
|
||||
logrus.WithError(err).Error("error inserting call into datastore")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user