go vet yourself (#397)

go vet caught some nifty bugs. so fixed those here, and also made it so that
we vet everything from now on since the robots seem to do a better job of
vetting than we have managed to.

also adds gofmt check to circle. could move this to the test.sh script (didn't
want a script calling a script, because $reasons) and it's nice and isolated
in its own little land as it is. side note, changed the script so it runs in
100ms instead of 3s, i think find is a lot faster than go list.

attempted some minor cleanup of various scripts
This commit is contained in:
Reed Allman
2017-10-06 08:42:33 -07:00
committed by Travis Reeder
parent d16d449626
commit 8a59654582
13 changed files with 25 additions and 46 deletions

View File

@@ -171,7 +171,7 @@ func Test(t *testing.T, dsf func() models.Datastore) {
t.Fatalf("Test GetCalls(ctx, filter): unexpected length `%v`", len(calls))
} else if calls[0].ID != c2.ID {
t.Log(buf.String())
t.Fatalf("Test GetCalls: call id not expected", calls[0].ID, c2.ID)
t.Fatalf("Test GetCalls: call id not expected %s vs %s", calls[0].ID, c2.ID)
}
})
@@ -387,7 +387,7 @@ func Test(t *testing.T, dsf func() models.Datastore) {
_, err := ds.InsertApp(ctx, testApp)
if err != nil && err != models.ErrAppsAlreadyExists {
t.Log(buf.String())
t.Fatalf("Test InsertRoute Prep: failed to insert app: ", err)
t.Fatal("Test InsertRoute Prep: failed to insert app: ", err)
}
// Testing insert route