added context for runnerpool interface (#1320)

* added context for runnerpool interface

* added context for runnerpool interface
This commit is contained in:
Shreya Garge
2018-11-20 17:02:47 +00:00
committed by GitHub
parent 47dab09996
commit 91f6ef3402
7 changed files with 8 additions and 8 deletions

View File

@@ -40,7 +40,7 @@ func (p *chPlacer) PlaceCall(ctx context.Context, rp RunnerPool, call RunnerCall
var runnerPoolErr error
for {
var runners []Runner
runners, runnerPoolErr = rp.Runners(call)
runners, runnerPoolErr = rp.Runners(ctx, call)
i := int(jumpConsistentHash(sum64, int32(len(runners))))
for j := 0; j < len(runners) && !state.IsDone(); j++ {

View File

@@ -34,7 +34,7 @@ func (sp *naivePlacer) PlaceCall(ctx context.Context, rp RunnerPool, call Runner
var runnerPoolErr error
for {
var runners []Runner
runners, runnerPoolErr = rp.Runners(call)
runners, runnerPoolErr = rp.Runners(ctx, call)
for j := 0; j < len(runners) && !state.IsDone(); j++ {

View File

@@ -20,7 +20,7 @@ type Placer interface {
// RunnerPool is the abstraction for getting an ordered list of runners to try for a call
type RunnerPool interface {
// returns an error for unrecoverable errors that should not be retried
Runners(call RunnerCall) ([]Runner, error)
Runners(ctx context.Context, call RunnerCall) ([]Runner, error)
Shutdown(ctx context.Context) error
}