From 965630af1561de242d32af9bdc0ef5b614f4c54c Mon Sep 17 00:00:00 2001 From: Travis Reeder Date: Thu, 26 Oct 2017 11:12:08 +0200 Subject: [PATCH] Remove error returns. --- api/agent/call.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/agent/call.go b/api/agent/call.go index 155b02af1..f8a29b60d 100644 --- a/api/agent/call.go +++ b/api/agent/call.go @@ -350,12 +350,12 @@ func (c *call) End(ctx context.Context, errIn error, t callTrigger) error { // TODO: this should be update, really if err := c.ds.InsertCall(ctx, c.Call); err != nil { common.Logger(ctx).WithError(err).Error("error inserting call into datastore") - return err + // note: Not returning err here since the job could have already finished successfully. } if err := c.ds.InsertLog(ctx, c.AppName, c.ID, c.stderr); err != nil { common.Logger(ctx).WithError(err).Error("error uploading log") - return err + // note: Not returning err here since the job could have already finished successfully. } // NOTE call this after InsertLog or the buffer will get reset