Speed up API tests (#624)

* Adjust API tests internal API

* Refactor API tests to take less time

 - sqlite: tests 15s, overall time: 1m
 - mysql: tests 15s, overall time: 59s

* Use retry func to survive in faulty places

* Use retry func while trying to ping SQL datastore

 - implements retry func specifically for SQL datastore ping
 - fmt fixes
 - using sqlx.Db.PingContext instead of sqlx.Db.Ping
 - propogate context to SQL datastore

* Simplify TestCanCauseTimeout retry loop

* Call retry with sane timeout

* Fix TestOversizedLog, use retry func

* Increase number of attempts

 2 test cases are really faulty in CI, so they need a lot more time to finish.

* Increase TestCanCauseTimeout timeout

* Use retry at TestMultiLog to speed it up

* Use retry at TestCanWriteLogs to speed it up

* Use retry at TestGetCallsSuccess to speed it up

* Use retry at TestCanGetAsyncState to speed it up

* Use retry at TestListCallsSuccess to speed it up

* Remove sleep calls

* Remove dup test case

* Cleaup Calls API test

* Build API tests binary once

 This patch lets CI to build API tests binary once and reuse that whenever it needs it

* Swap API tests checks

* Build API test binary by default

 dirty fix for CircleCI

* Use retry func to determine if datastore is alive in tests

* go install should also reduce build time

* Fix rebase issues

.gitignore

@@ -30,6 +30,6 @@ fnlb/fnlb
 /fn
 .DS_Store
 /fnserver
-.idea/
 *iml
 target/
+fn-api-tests.test

Makefile

@@ -31,11 +31,14 @@ test-basic: checkfmt pull-images fn-test-utils
 test: checkfmt pull-images test-basic test-middleware test-extensions
 
 test-api: test-basic
-	./api_test.sh mysql 4
-	./api_test.sh postgres 4
 	./api_test.sh sqlite3 4
+	./api_test.sh mysql 4 0
+	./api_test.sh postgres 4 0
 
-full-test: test test-api
+build-static:
+	go install
+
+full-test: build-static test test-api
 
 img-sleeper:
 	docker pull fnproject/sleeper

api_test.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-set -exuo pipefail
+set -exo pipefail
 
 function host {
     case ${DOCKER_LOCATION:-localhost} in
@@ -24,17 +24,16 @@ case "$1" in
     "sqlite3" )
     rm -fr /tmp/fn_integration_tests.db
     touch /tmp/fn_integration_tests.db
-    FN_DB_URL="sqlite3:///tmp/fn_integration_tests.db"
+    export FN_DB_URL="sqlite3:///tmp/fn_integration_tests.db"
     ;;
 
     "mysql" )
     DB_CONTAINER="func-mysql-test"
     docker rm -fv ${DB_CONTAINER} || echo No prev mysql test db container
     docker run --name ${DB_CONTAINER} -p 3306:3306 -e MYSQL_DATABASE=funcs -e MYSQL_ROOT_PASSWORD=root -d mysql
-    sleep 15
     MYSQL_HOST=`host ${DB_CONTAINER}`
     MYSQL_PORT=3306
-    FN_DB_URL="mysql://root:root@tcp(${MYSQL_HOST}:${MYSQL_PORT})/funcs"
+    export FN_DB_URL="mysql://root:root@tcp(${MYSQL_HOST}:${MYSQL_PORT})/funcs"
 
     ;;
 
@@ -42,12 +41,29 @@ case "$1" in
     DB_CONTAINER="func-postgres-test"
     docker rm -fv ${DB_CONTAINER} || echo No prev test db container
     docker run --name ${DB_CONTAINER} -e "POSTGRES_DB=funcs" -e "POSTGRES_PASSWORD=root"  -p 5432:5432 -d postgres
-    sleep 15
     POSTGRES_HOST=`host ${DB_CONTAINER}`
     POSTGRES_PORT=5432
-    FN_DB_URL="postgres://postgres:root@${POSTGRES_HOST}:${POSTGRES_PORT}/funcs?sslmode=disable"
+    export FN_DB_URL="postgres://postgres:root@${POSTGRES_HOST}:${POSTGRES_PORT}/funcs?sslmode=disable"
 
     ;;
 esac
 
+#test test/fn-api-tests/fn-api-tests.test
+#status=`echo $?`
+#rebuild="${3:-1}"
+#circleci=`echo ${CIRCLECI}`
+#cd test/fn-api-tests
+#if [[ $status -ne 0 ]] || [[ $rebuild -ne 0 ]] ; then
+#    if [[ $circleci == "true" ]]; then
+#        # dirty things to make CI pass
+#        ls -lah /usr/local/go/pkg/linux_amd64/runtime
+#        sudo chown -R `whoami`:root /usr/local/go
+#        sudo chmod -R 777 /usr/local/go/pkg/linux_amd64
+#        ls -lah /usr/local/go/pkg/linux_amd64/runtime
+#    fi
+#    pwd
+#    go test -i -a -o fn-api-tests.test
+#fi
+#pwd
+#./fn-api-tests.test -test.v  -test.parallel ${2:-1} ./...; cd ../../
 cd test/fn-api-tests && FN_API_URL="http://localhost:8080"  FN_DB_URL=${FN_DB_URL} go test -v  -parallel ${2:-1} ./...; cd ../../

test/fn-api-tests/apps_test.go

@@ -9,9 +9,7 @@ import (
 	"github.com/fnproject/fn_go/client/apps"
 )
 
-func TestApps(t *testing.T) {
+func TestAppDeleteNotFound(t *testing.T) {
-
-	t.Run("delete-app-not-found-test", func(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	cfg := &apps.DeleteAppsAppParams{
@@ -23,9 +21,9 @@ func TestApps(t *testing.T) {
 	if err == nil {
 		t.Errorf("Error during app delete: we should get HTTP 404, but got: %s", err.Error())
 	}
-	})
+}
 
-	t.Run("app-not-found-test", func(t *testing.T) {
+func TestAppGetNotFound(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	cfg := &apps.GetAppsAppParams{
@@ -35,23 +33,23 @@ func TestApps(t *testing.T) {
 	cfg.WithTimeout(time.Second * 60)
 	_, err := s.Client.Apps.GetAppsApp(cfg)
 	CheckAppResponseError(t, err)
-	})
+}
 
-	t.Run("create-app-and-delete-no-config-test", func(t *testing.T) {
+func TestAppCreateNoConfigSuccess(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("create-app-with-config-test", func(t *testing.T) {
+func TestAppCreateWithConfigSuccess(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{"A": "a"})
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("inspect-app-with-config-test", func(t *testing.T) {
+func TestAppInsect(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{"A": "a"})
@@ -64,9 +62,9 @@ func TestApps(t *testing.T) {
 		t.Errorf("App config value is different. Expected: `a`. Actual %v", val)
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("patch-app-with-exact-same-config-data", func(t *testing.T) {
+func TestAppPatchSameConfig(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	config := map[string]string{
@@ -80,9 +78,9 @@ func TestApps(t *testing.T) {
 	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("patch-override-app-config", func(t *testing.T) {
+func TestAppPatchOverwriteConfig(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	config := map[string]string{
@@ -97,9 +95,9 @@ func TestApps(t *testing.T) {
 		t.Errorf("App config value is different. Expected: `b`. Actual %v", val)
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("patch-add-app-config", func(t *testing.T) {
+func TestAppsPatchConfigAddValue(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	config := map[string]string{
@@ -114,9 +112,9 @@ func TestApps(t *testing.T) {
 		t.Errorf("App config value is different. Expected: `b`. Actual %v", val)
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("crete-app-duplicate", func(t *testing.T) {
+func TestAppDuplicate(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
@@ -125,5 +123,4 @@ func TestApps(t *testing.T) {
 		CheckAppResponseError(t, err)
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
 }

test/fn-api-tests/calls_test.go

@@ -10,9 +10,7 @@ import (
 	"github.com/fnproject/fn_go/client/call"
 )
 
-func TestCalls(t *testing.T) {
+func TestCallsMissingApp(t *testing.T) {
-
-	t.Run("list-calls-for-missing-app", func(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	cfg := &call.GetAppsAppCallsParams{
@@ -24,14 +22,14 @@ func TestCalls(t *testing.T) {
 	if err == nil {
 		t.Errorf("Must fail with missing app error, but got %s", err)
 	}
-	})
+}
 
-	t.Run("get-dummy-call", func(t *testing.T) {
+func TestCallsDummy(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	cfg := &call.GetAppsAppCallsCallParams{
 		Call:    "dummy",
@@ -45,14 +43,14 @@ func TestCalls(t *testing.T) {
 	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("get-real-call", func(t *testing.T) {
+func TestGetExactCall(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -60,56 +58,23 @@ func TestCalls(t *testing.T) {
 	}
 	u.Path = path.Join(u.Path, "r", s.AppName, s.RoutePath)
 
-		time.Sleep(time.Second * 5)
+	callID := CallAsync(t, u, &bytes.Buffer{})
-		_, err := s.Client.Call.GetAppsAppCalls(&call.GetAppsAppCallsParams{
+
+	cfg := &call.GetAppsAppCallsCallParams{
+		Call:    callID,
 		App:     s.AppName,
-			Path: &s.RoutePath,
-		})
-		if err != nil {
-			switch err.(type) {
-			case *call.GetAppsAppCallsCallNotFound:
-				msg := err.(*call.GetAppsAppCallsCallNotFound).Payload.Error.Message
-				t.Errorf("Unexpected error occurred: %v.", msg)
-			}
-		}
-		DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
-
-	t.Run("list-calls", func(t *testing.T) {
-		t.Parallel()
-		s := SetupDefaultSuite()
-		CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
-		CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
-
-		u := url.URL{
-			Scheme: "http",
-			Host:   Host(),
-		}
-		u.Path = path.Join(u.Path, "r", s.AppName, s.RoutePath)
-
-		CallAsync(t, u, &bytes.Buffer{})
-		time.Sleep(time.Second * 8)
-
-		cfg := &call.GetAppsAppCallsParams{
-			App:     s.AppName,
-			Path:    &s.RoutePath,
 		Context: s.Context,
 	}
-		calls, err := s.Client.Call.GetAppsAppCalls(cfg)
+	cfg.WithTimeout(time.Second * 60)
-		if err != nil {
+
-			t.Errorf("Unexpected error: %s", err)
+	retryErr := APICallWithRetry(t, 10, time.Second*2, func() (err error) {
-		}
+		_, err = s.Client.Call.GetAppsAppCallsCall(cfg)
-		if calls == nil || calls.Payload == nil || calls.Payload.Calls == nil || len(calls.Payload.Calls) == 0 {
+		return err
-			t.Errorf("Must fail. There should be at least one call to `%v` route.", s.RoutePath)
-			return
-		}
-		for _, c := range calls.Payload.Calls {
-			if c.Path != s.RoutePath {
-				t.Errorf("Call path mismatch.\n\tExpected: %v\n\tActual: %v", c.Path, s.RoutePath)
-			}
-		}
-		DeleteApp(t, s.Context, s.Client, s.AppName)
 	})
 
+	if retryErr != nil {
+		t.Error(retryErr.Error())
+	}
+
+	DeleteApp(t, s.Context, s.Client, s.AppName)
 }

test/fn-api-tests/exec_test.go

@@ -14,15 +14,6 @@ import (
 	"github.com/fnproject/fn_go/client/operations"
 )
 
-type ErrMsg struct {
-	Message string `json:"message"`
-}
-
-type TimeoutBody struct {
-	Error  ErrMsg `json:"error"`
-	CallID string `json:"request_id"`
-}
-
 func CallAsync(t *testing.T, u url.URL, content io.Reader) string {
 	output := &bytes.Buffer{}
 	_, err := CallFN(u.String(), content, output, "POST", []string{})
@@ -49,15 +40,12 @@ func CallAsync(t *testing.T, u url.URL, content io.Reader) string {
 	return callID.CallID
 }
 
-func TestRouteExecutions(t *testing.T) {
+func TestCanCallfunction(t *testing.T) {
-	newRouteType := "async"
-
-	t.Run("run-sync-fnproject/hello-no-input", func(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, "sync",
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -76,14 +64,14 @@ func TestRouteExecutions(t *testing.T) {
 		t.Errorf("Assertion error.\n\tExpected: %v\n\tActual: %v", expectedOutput, output.String())
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("run-sync-fnproject/hello-with-input", func(t *testing.T) {
+func TestCallOutputMatch(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, "sync",
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -105,15 +93,15 @@ func TestRouteExecutions(t *testing.T) {
 		t.Errorf("Assertion error.\n\tExpected: %v\n\tActual: %v", expectedOutput, output.String())
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
+}
 
-	})
+func TestCanCallAsync(t *testing.T) {
-
+	newRouteType := "async"
-	t.Run("run-async-fnproject/hello", func(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, "sync",
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -131,14 +119,15 @@ func TestRouteExecutions(t *testing.T) {
 
 	CallAsync(t, u, &bytes.Buffer{})
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("run-async-fnproject/hello-with-status-check", func(t *testing.T) {
+func TestCanGetAsyncState(t *testing.T) {
+	newRouteType := "async"
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, "sync",
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -155,13 +144,21 @@ func TestRouteExecutions(t *testing.T) {
 	CheckRouteResponseError(t, err)
 
 	callID := CallAsync(t, u, &bytes.Buffer{})
-		time.Sleep(time.Second * 10)
 	cfg := &call.GetAppsAppCallsCallParams{
 		Call:    callID,
 		App:     s.AppName,
 		Context: s.Context,
 	}
 	cfg.WithTimeout(time.Second * 60)
+
+	retryErr := APICallWithRetry(t, 10, time.Second*2, func() (err error) {
+		_, err = s.Client.Call.GetAppsAppCallsCall(cfg)
+		return err
+	})
+
+	if retryErr != nil {
+		t.Error(retryErr.Error())
+	} else {
 		callResponse, err := s.Client.Call.GetAppsAppCallsCall(cfg)
 		if err != nil {
 			switch err.(type) {
@@ -184,12 +181,12 @@ func TestRouteExecutions(t *testing.T) {
 		if callObject.Status != "success" {
 			t.Errorf("Call object status mismatch.\n\tExpected: %v\n\tActual:%v", "success", callObject.Status)
 		}
+	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
+}
 
-	})
+func TestCanCauseTimeout(t *testing.T) {
-
-	t.Run("exec-timeout-test", func(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	routePath := "/" + RandStringBytes(10)
@@ -198,7 +195,7 @@ func TestRouteExecutions(t *testing.T) {
 
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, routePath, image, routeType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, int32(10), s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -209,7 +206,7 @@ func TestRouteExecutions(t *testing.T) {
 	content := &bytes.Buffer{}
 	json.NewEncoder(content).Encode(struct {
 		Seconds int64 `json:"seconds"`
-		}{Seconds: 31})
+	}{Seconds: 11})
 	output := &bytes.Buffer{}
 
 	headers, _ := CallFN(u.String(), content, output, "POST", []string{})
@@ -217,13 +214,21 @@ func TestRouteExecutions(t *testing.T) {
 	if !strings.Contains(output.String(), "Timed out") {
 		t.Errorf("Must fail because of timeout, but got error message: %v", output.String())
 	}
-
 	cfg := &call.GetAppsAppCallsCallParams{
 		Call:    headers.Get("FN_CALL_ID"),
 		App:     s.AppName,
 		Context: s.Context,
 	}
 	cfg.WithTimeout(time.Second * 60)
+
+	retryErr := APICallWithRetry(t, 10, time.Second*2, func() (err error) {
+		_, err = s.Client.Call.GetAppsAppCallsCall(cfg)
+		return err
+	})
+
+	if retryErr != nil {
+		t.Error(retryErr.Error())
+	} else {
 		callObj, err := s.Client.Call.GetAppsAppCallsCall(cfg)
 		if err != nil {
 			t.Errorf("Unexpected error: %s", err)
@@ -232,11 +237,11 @@ func TestRouteExecutions(t *testing.T) {
 			t.Errorf("Call status mismatch.\n\tExpected: %v\n\tActual: %v",
 				"output", "callObj.Payload.Call.Status")
 		}
-
+	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("exec-multi-log-test", func(t *testing.T) {
+func TestMultiLog(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	routePath := "/multi-log"
@@ -245,7 +250,7 @@ func TestRouteExecutions(t *testing.T) {
 
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, routePath, image, routeType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -254,7 +259,6 @@ func TestRouteExecutions(t *testing.T) {
 	u.Path = path.Join(u.Path, "r", s.AppName, routePath)
 
 	callID := CallAsync(t, u, &bytes.Buffer{})
-		time.Sleep(15 * time.Second)
 
 	cfg := &operations.GetAppsAppCallsCallLogParams{
 		Call:    callID,
@@ -262,6 +266,14 @@ func TestRouteExecutions(t *testing.T) {
 		Context: s.Context,
 	}
 
+	retryErr := APICallWithRetry(t, 10, time.Second*2, func() (err error) {
+		_, err = s.Client.Operations.GetAppsAppCallsCallLog(cfg)
+		return err
+	})
+
+	if retryErr != nil {
+		t.Error(retryErr.Error())
+	} else {
 		logObj, err := s.Client.Operations.GetAppsAppCallsCallLog(cfg)
 		if err != nil {
 			t.Errorf("Unexpected error: %s", err)
@@ -277,11 +289,12 @@ func TestRouteExecutions(t *testing.T) {
 			t.Errorf("Log entry must contain `Second line` "+
 				"string, but got: %v", logObj.Payload.Log.Log)
 		}
+	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("verify-headers-separator", func(t *testing.T) {
+func TestCallResponseHeadersMatch(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
@@ -289,7 +302,7 @@ func TestRouteExecutions(t *testing.T) {
 	image := "denismakogon/os.environ"
 	routeType := "sync"
 	CreateRoute(t, s.Context, s.Client, s.AppName, routePath, image, routeType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -310,11 +323,9 @@ func TestRouteExecutions(t *testing.T) {
 	}
 	DeleteRoute(t, s.Context, s.Client, s.AppName, routePath)
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("exec-log-test", func(t *testing.T) {
+func TestCanWriteLogs(t *testing.T) {
-		//XXX: Fix this test.
-		t.Skip("Flaky test needs to be rewritten. https://github.com/fnproject/fn/issues/253")
 	t.Parallel()
 	s := SetupDefaultSuite()
 	routePath := "/log"
@@ -323,7 +334,7 @@ func TestRouteExecutions(t *testing.T) {
 
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, routePath, image, routeType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -336,7 +347,6 @@ func TestRouteExecutions(t *testing.T) {
 	}{Size: 20})
 
 	callID := CallAsync(t, u, content)
-		time.Sleep(10 * time.Second)
 
 	cfg := &operations.GetAppsAppCallsCallLogParams{
 		Call:    callID,
@@ -344,19 +354,20 @@ func TestRouteExecutions(t *testing.T) {
 		Context: s.Context,
 	}
 
-		_, err := s.Client.Operations.GetAppsAppCallsCallLog(cfg)
+	retryErr := APICallWithRetry(t, 10, time.Second*2, func() (err error) {
+		_, err = s.Client.Operations.GetAppsAppCallsCallLog(cfg)
+		return err
+	})
 
-		if err != nil {
+	if retryErr != nil {
-			t.Errorf("Unexpected error: %s", err)
+		t.Error(retryErr.Error())
 	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("exec-oversized-log-test", func(t *testing.T) {
+func TestOversizedLog(t *testing.T) {
 	t.Parallel()
-		t.Skip("Skipped until fix for https://gitlab-odx.oracle.com/odx/functions/issues/86.")
-
 	s := SetupDefaultSuite()
 	routePath := "/log"
 	image := "funcy/log:0.0.1"
@@ -364,7 +375,7 @@ func TestRouteExecutions(t *testing.T) {
 
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, routePath, image, routeType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	size := 1 * 1024 * 1024 * 1024
 	u := url.URL{
@@ -378,7 +389,6 @@ func TestRouteExecutions(t *testing.T) {
 	}{Size: size}) //exceeding log by 1 symbol
 
 	callID := CallAsync(t, u, content)
-		time.Sleep(5 * time.Second)
 
 	cfg := &operations.GetAppsAppCallsCallLogParams{
 		Call:    callID,
@@ -386,6 +396,13 @@ func TestRouteExecutions(t *testing.T) {
 		Context: s.Context,
 	}
 
+	retryErr := APICallWithRetry(t, 10, time.Second*2, func() (err error) {
+		_, err = s.Client.Operations.GetAppsAppCallsCallLog(cfg)
+		return err
+	})
+	if retryErr != nil {
+		t.Error(retryErr.Error())
+	} else {
 		logObj, err := s.Client.Operations.GetAppsAppCallsCallLog(cfg)
 		if err != nil {
 			t.Errorf("Unexpected error: %s", err)
@@ -394,7 +411,7 @@ func TestRouteExecutions(t *testing.T) {
 			t.Errorf("Log entry suppose to be truncated up to expected size %v, got %v",
 				size/1024, len(logObj.Payload.Log.Log))
 		}
-		DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
 
+	}
+	DeleteApp(t, s.Context, s.Client, s.AppName)
 }

test/fn-api-tests/formats_test.go

@@ -14,9 +14,7 @@ type JSONResponse struct {
 	Message string `json:"message"`
 }
 
-func TestFnFormats(t *testing.T) {
+func TestFnJSONFormats(t *testing.T) {
-
-	t.Run("test-json-format", func(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 
@@ -27,7 +25,7 @@ func TestFnFormats(t *testing.T) {
 
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, route, image, "sync",
-			format, s.RouteConfig, s.RouteHeaders)
+		format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	u := url.URL{
 		Scheme: "http",
@@ -66,7 +64,4 @@ func TestFnFormats(t *testing.T) {
 	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-
-	})
-
 }

test/fn-api-tests/routes_api.go

@@ -89,7 +89,7 @@ func assertRouteFields(t *testing.T, routeObject *models.Route, path, image, rou
 
 }
 
-func createRoute(ctx context.Context, fnclient *client.Fn, appName, image, routePath, routeType, routeFormat string, routeConfig map[string]string, headers map[string][]string) (*routes.PostAppsAppRoutesOK, error) {
+func createRoute(ctx context.Context, fnclient *client.Fn, appName, image, routePath, routeType, routeFormat string, timeout, idleTimeout int32, routeConfig map[string]string, headers map[string][]string) (*routes.PostAppsAppRoutesOK, error) {
 	cfg := &routes.PostAppsAppRoutesParams{
 		App: appName,
 		Body: &models.RouteWrapper{
@@ -100,6 +100,8 @@ func createRoute(ctx context.Context, fnclient *client.Fn, appName, image, route
 				Path:        routePath,
 				Type:        routeType,
 				Format:      routeFormat,
+				Timeout:     &timeout,
+				IDLETimeout: &idleTimeout,
 			},
 		},
 		Context: ctx,
@@ -119,8 +121,8 @@ func createRoute(ctx context.Context, fnclient *client.Fn, appName, image, route
 
 }
 
-func CreateRoute(t *testing.T, ctx context.Context, fnclient *client.Fn, appName, routePath, image, routeType, routeFormat string, routeConfig map[string]string, headers map[string][]string) {
+func CreateRoute(t *testing.T, ctx context.Context, fnclient *client.Fn, appName, routePath, image, routeType, routeFormat string, timeout, idleTimeout int32, routeConfig map[string]string, headers map[string][]string) {
-	routeResponse, err := createRoute(ctx, fnclient, appName, image, routePath, routeType, routeFormat, routeConfig, headers)
+	routeResponse, err := createRoute(ctx, fnclient, appName, image, routePath, routeType, routeFormat, timeout, idleTimeout, routeConfig, headers)
 	CheckRouteResponseError(t, err)
 
 	assertRouteFields(t, routeResponse.Payload.Route, routePath, image, routeType, routeFormat)

test/fn-api-tests/routes_test.go

@@ -4,52 +4,49 @@ import (
 	"testing"
 
 	"github.com/fnproject/fn/api/id"
-	api_models "github.com/fnproject/fn/api/models"
 	"github.com/fnproject/fn_go/models"
+	"reflect"
 )
 
-func TestRoutes(t *testing.T) {
+func TestCreateRouteEmptyType(t *testing.T) {
-	newRouteType := "sync"
-	newRoutePath := id.New().String()
-	t.Run("create-route-with-empty-type", func(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
-		_, err := createRoute(s.Context, s.Client, s.AppName, s.RoutePath, s.Image, "", s.Format,
+	_, err := createRoute(s.Context, s.Client, s.AppName, s.RoutePath, s.Image, "",
-			s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 	if err == nil {
 		t.Errorf("Should fail with Invalid route Type.")
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("create-route", func(t *testing.T) {
+func TestCanCreateRoute(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("list-and-find-route", func(t *testing.T) {
+func TestListRoutes(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 	if !assertContainsRoute(ListRoutes(t, s.Context, s.Client, s.AppName), s.RoutePath) {
 		t.Errorf("Unable to find corresponding route `%v` in list", s.RoutePath)
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("can-get-corresponding-route", func(t *testing.T) {
+func TestInspectRoute(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	rObjects := []*models.Route{GetRoute(t, s.Context, s.Client, s.AppName, s.RoutePath)}
 	if !assertContainsRoute(rObjects, s.RoutePath) {
@@ -57,14 +54,15 @@ func TestRoutes(t *testing.T) {
 	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("can-update-route-info", func(t *testing.T) {
+func TestCanUpdateRouteType(t *testing.T) {
+	newRouteType := "sync"
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	routeResp, err := UpdateRoute(
 		t, s.Context, s.Client,
@@ -76,14 +74,14 @@ func TestRoutes(t *testing.T) {
 	assertRouteFields(t, routeResp.Payload.Route, s.RoutePath, s.Image, newRouteType, s.Format)
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("patch-route-with-config", func(t *testing.T) {
+func TestCanUpdateRouteConfig(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	newRouteConf := map[string]string{
 		"A": "a",
@@ -99,14 +97,16 @@ func TestRoutes(t *testing.T) {
 	assertRouteFields(t, routeResp.Payload.Route, s.RoutePath, s.Image, s.RouteType, s.Format)
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
+
+func TestCantUpdateRoutePath(t *testing.T) {
 
-	t.Run("fail-to-update-route-path", func(t *testing.T) {
 	t.Parallel()
+	newRoutePath := id.New().String()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	_, err := UpdateRoute(
 		t, s.Context, s.Client,
@@ -118,36 +118,37 @@ func TestRoutes(t *testing.T) {
 	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("create-route-duplicate", func(t *testing.T) {
+func TestRouteDuplicate(t *testing.T) {
 	t.Parallel()
+	newRouteType := "async"
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	_, err := createRoute(s.Context, s.Client, s.AppName, s.Image, s.RoutePath,
-			newRouteType, s.Format, s.RouteConfig, s.RouteHeaders)
+		newRouteType, s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 	if err == nil {
 		t.Errorf("Route duplicate error should appear, but it didn't")
 	}
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("can-delete-route", func(t *testing.T) {
+func TestCanDeleteRoute(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	DeleteRoute(t, s.Context, s.Client, s.AppName, s.RoutePath)
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("fail-to-delete-missing-route", func(t *testing.T) {
+func TestCantDeleteRoute(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
@@ -157,32 +158,32 @@ func TestRoutes(t *testing.T) {
 		t.Error("Delete from missing route must fail.")
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("deploy-route-without-existing-app", func(T *testing.T) {
+func TestDeployNewApp(t *testing.T) {
 	t.Parallel()
 	s := SetupDefaultSuite()
 	DeployRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType, s.Format, s.RouteConfig, s.RouteHeaders)
 	GetApp(t, s.Context, s.Client, s.AppName)
 	GetRoute(t, s.Context, s.Client, s.AppName, s.RoutePath)
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("deploy-route-with-existing-app", func(T *testing.T) {
+func TestDeployExistingApp(t *testing.T) {
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	DeployRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType, s.Format, s.RouteConfig, s.RouteHeaders)
 	GetApp(t, s.Context, s.Client, s.AppName)
 	GetRoute(t, s.Context, s.Client, s.AppName, s.RoutePath)
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("deploy-update-with-existing-route-and-app", func(T *testing.T) {
+func TestDeployUpdate(t *testing.T) {
 	newRouteType := "sync"
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	CreateRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType,
-			s.Format, s.RouteConfig, s.RouteHeaders)
+		s.Format, s.Timeout, s.IdleTimeout, s.RouteConfig, s.RouteHeaders)
 
 	updatedRoute := DeployRoute(
 		t, s.Context, s.Client,
@@ -192,9 +193,9 @@ func TestRoutes(t *testing.T) {
 	assertRouteFields(t, updatedRoute, s.RoutePath, s.Image, newRouteType, s.Format)
 
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
+}
 
-	t.Run("multiple-deploy-route-with-headers", func(T *testing.T) {
+func TestMulpileDeployExistingApp(t *testing.T) {
 	s := SetupDefaultSuite()
 	CreateApp(t, s.Context, s.Client, s.AppName, map[string]string{})
 	routeHeaders := map[string][]string{}
@@ -202,10 +203,8 @@ func TestRoutes(t *testing.T) {
 	routeHeaders["B"] = []string{"b"}
 	DeployRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType, s.Format, s.RouteConfig, routeHeaders)
 	sameRoute := DeployRoute(t, s.Context, s.Client, s.AppName, s.RoutePath, s.Image, s.RouteType, s.Format, s.RouteConfig, routeHeaders)
-		if !api_models.Headers(sameRoute.Headers).Equals(api_models.Headers(routeHeaders)) {
+	if ok := reflect.DeepEqual(sameRoute.Headers, routeHeaders); !ok {
 		t.Error("Route headers should remain the same after multiple deploys with exact the same parameters")
 	}
 	DeleteApp(t, s.Context, s.Client, s.AppName)
-	})
-
 }

test/fn-api-tests/utils.go

@@ -12,6 +12,7 @@ import (
 	"runtime"
 	"strings"
 	"sync"
+	"testing"
 	"time"
 
 	"github.com/fnproject/fn/api/common"
@@ -104,6 +105,8 @@ type SuiteSetup struct {
 	RouteType    string
 	Format       string
 	Memory       uint64
+	Timeout      int32
+	IdleTimeout  int32
 	RouteConfig  map[string]string
 	RouteHeaders map[string][]string
 	Cancel       context.CancelFunc
@@ -131,6 +134,8 @@ func SetupDefaultSuite() *SuiteSetup {
 		RouteHeaders: map[string][]string{},
 		Cancel:       cancel,
 		Memory:       uint64(256),
+		Timeout:      int32(30),
+		IdleTimeout:  int32(30),
 	}
 
 	if Host() != "localhost:8080" {
@@ -224,3 +229,16 @@ func MyCaller() string {
 	f, l := fun.FileLine(fpcs[0] - 1)
 	return fmt.Sprintf("%s:%d", f, l)
 }
+
+func APICallWithRetry(t *testing.T, attempts int, sleep time.Duration, callback func() error) (err error) {
+	for i := 0; i < attempts; i++ {
+		err = callback()
+		if err == nil {
+			t.Log("Exiting retry loop, API call was successful")
+			return nil
+		}
+		time.Sleep(sleep)
+		t.Logf("[%v] - Retryting API call after unsuccessful attemt with error: %v", i, err.Error())
+	}
+	return err
+}