alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix assert check in system tests (#952)

Browse Source 
In the case the function execution fails the output returned is empty, an
empty output satisfies the "string.Contanis()" checks, as an empty string
is always contained in any string.
The change adds a check on the length of the actual output.
This commit is contained in:
Andrea Rosa
2018-04-23 17:59:07 +01:00
committed by Reed Allman
parent 6337a08a8b
commit b922d2f348
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/fn-system-tests/exec_test.go
View File

@@ -51,7 +51,8 @@ func TestCanExecuteFunction(t *testing.T) {
t.Errorf("Got unexpected error: %v", err) t.Errorf("Got unexpected error: %v", err)
} }
expectedOutput := "Hello World!\n" expectedOutput := "Hello World!\n"
if !strings.Contains(expectedOutput, output.String()) { actual := output.String()
if !strings.Contains(expectedOutput, actual) || len(expectedOutput) != len(actual) {
t.Errorf("Assertion error.\n\tExpected: %v\n\tActual: %v", expectedOutput, output.String()) t.Errorf("Assertion error.\n\tExpected: %v\n\tActual: %v", expectedOutput, output.String())
} }
} }
@@ -92,7 +93,8 @@ func TestBasicConcurrentExecution(t *testing.T) {
return return
} }
expectedOutput := "Hello World!\n" expectedOutput := "Hello World!\n"
if !strings.Contains(expectedOutput, output.String()) { actual := output.String()
if !strings.Contains(expectedOutput, actual) || len(expectedOutput) != len(actual) {
results <- fmt.Errorf("Assertion error.\n\tExpected: %v\n\tActual: %v", expectedOutput, output.String()) results <- fmt.Errorf("Assertion error.\n\tExpected: %v\n\tActual: %v", expectedOutput, output.String())
return return
} }
@@ -142,7 +144,8 @@ func TestSaturatedSystem(t *testing.T) {
} }
} }
expectedOutput := "{\"error\":{\"message\":\"Timed out - server too busy\"}}\n" expectedOutput := "{\"error\":{\"message\":\"Timed out - server too busy\"}}\n"
if !strings.Contains(expectedOutput, output.String()) { actual := output.String()
if !strings.Contains(expectedOutput, actual) || len(expectedOutput) != len(actual) {
t.Errorf("Assertion error.\n\tExpected: %v\n\tActual: %v", expectedOutput, output.String()) t.Errorf("Assertion error.\n\tExpected: %v\n\tActual: %v", expectedOutput, output.String())
} }
} }