alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Minor to fix comments in PR.

Browse Source
This commit is contained in:
Travis Reeder
2016-10-13 12:32:38 -07:00
parent 3f5af686b1
commit c40ef433d8
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
api/runner/async_runner.go
View File

@@ -19,9 +19,6 @@ import (
) )
func getTask(ctx context.Context, url string) (*models.Task, error) { func getTask(ctx context.Context, url string) (*models.Task, error) {
// log := common.Logger(ctx)
// log.Infoln("Getting task from URL:", url)
resp, err := http.Get(url) resp, err := http.Get(url)
if err != nil { if err != nil {
return nil, err return nil, err
@@ -164,7 +161,7 @@ func startAsyncRunners(ctx context.Context, wg *sync.WaitGroup, i int, url strin
continue continue
} }
log.Info("Task complete:") log.Info("Task complete")
} }
} }
} }

5
api/runner/async_runner_test.go
View File

@@ -192,13 +192,8 @@ func TestTasksrvURL(t *testing.T) {
tests := []struct { tests := []struct {
in, out string in, out string
}{ }{
// we shouldn't be swapping out no port with 8080, those would be 80. Also, we shouldn't accept anything but a full URL (base URL) in API_URL
// {"//localhost", "http://localhost:8080/tasks"},
// {"//localhost/", "http://localhost:8080/tasks"},
{"//localhost:8081", "http://localhost:8081/tasks"}, {"//localhost:8081", "http://localhost:8081/tasks"},
{"//localhost:8081/", "http://localhost:8081/tasks"}, {"//localhost:8081/", "http://localhost:8081/tasks"},
// {"http://localhost", "http://localhost:8080/tasks"},
// {"http://localhost/", "http://localhost:8080/tasks"},
{"http://localhost:8081", "http://localhost:8081/tasks"}, {"http://localhost:8081", "http://localhost:8081/tasks"},
{"http://localhost:8081/", "http://localhost:8081/tasks"}, {"http://localhost:8081/", "http://localhost:8081/tasks"},
{"http://localhost:8081/endpoint", "http://localhost:8081/endpoint"}, {"http://localhost:8081/endpoint", "http://localhost:8081/endpoint"},