alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add app and route validation to calls API handler

Browse Source 
This patch adds check for app and route to ensure
 that they exist before listing calls
This commit is contained in:
Denis Makogon
2017-06-22 18:23:31 +03:00
parent 9a46222280
commit c80746bf56
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
api/server/call_list.go
View File

@@ -17,11 +17,23 @@ func (s *Server) handleCallList(c *gin.Context) {
c.JSON(http.StatusBadRequest, models.ErrRoutesValidationMissingAppName) c.JSON(http.StatusBadRequest, models.ErrRoutesValidationMissingAppName)
return return
} }
_, err := s.Datastore.GetApp(c, appName)
if err != nil {
c.JSON(http.StatusNotFound, models.ErrAppsNotFound)
return
}
appRoute, ok := c.MustGet(api.Path).(string) appRoute, ok := c.MustGet(api.Path).(string)
if ok && appRoute == "" { if ok && appRoute == "" {
c.JSON(http.StatusBadRequest, models.ErrRoutesValidationMissingPath) c.JSON(http.StatusBadRequest, models.ErrRoutesValidationMissingPath)
return return
} }
_, err = s.Datastore.GetRoute(c, appName, appRoute)
if err != nil {
c.JSON(http.StatusNotFound, models.ErrRoutesNotFound)
return
}
filter := models.CallFilter{AppName:appName, Path:appRoute} filter := models.CallFilter{AppName:appName, Path:appRoute}