alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

fn: rename vars for clarity (#992)

Browse Source
This commit is contained in:
Tolga Ceylan
2018-05-11 14:35:13 -07:00
committed by GitHub
parent 6226f54f58
commit cba3fc14e7
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
api/common/logging.go
View File

@@ -44,12 +44,12 @@ func SetLogDest(to, prefix string) {
// expect: [scheme://][host][:port][/path] // expect: [scheme://][host][:port][/path]
// default scheme to udp:// if none given // default scheme to udp:// if none given
url, err := url.Parse(to) parsed, err := url.Parse(to)
if url.Host == "" && url.Path == "" { if parsed.Host == "" && parsed.Path == "" {
logrus.WithFields(logrus.Fields{"to": to}).Warn("No scheme on logging url, adding udp://") logrus.WithFields(logrus.Fields{"to": to}).Warn("No scheme on logging url, adding udp://")
// this happens when no scheme like udp:// is present // this happens when no scheme like udp:// is present
to = "udp://" + to to = "udp://" + to
url, err = url.Parse(to) parsed, err = url.Parse(to)
} }
if err != nil { if err != nil {
logrus.WithError(err).WithFields(logrus.Fields{"to": to}).Error("could not parse logging URI, defaulting to stderr") logrus.WithError(err).WithFields(logrus.Fields{"to": to}).Error("could not parse logging URI, defaulting to stderr")
@@ -57,26 +57,26 @@ func SetLogDest(to, prefix string) {
} }
// File URL must contain only `url.Path`. Syslog location must contain only `url.Host` // File URL must contain only `url.Path`. Syslog location must contain only `url.Host`
if (url.Host == "" && url.Path == "") || (url.Host != "" && url.Path != "") { if (parsed.Host == "" && parsed.Path == "") || (parsed.Host != "" && parsed.Path != "") {
logrus.WithFields(logrus.Fields{"to": to, "uri": url}).Error("invalid logging location, defaulting to stderr") logrus.WithFields(logrus.Fields{"to": to, "uri": parsed}).Error("invalid logging location, defaulting to stderr")
return return
} }
switch url.Scheme { switch parsed.Scheme {
case "udp", "tcp": case "udp", "tcp":
err = NewSyslogHook(url, prefix) err = NewSyslogHook(parsed, prefix)
if err != nil { if err != nil {
logrus.WithFields(logrus.Fields{"uri": url, "to": to}).WithError(err).Error("unable to connect to syslog, defaulting to stderr") logrus.WithFields(logrus.Fields{"uri": parsed, "to": to}).WithError(err).Error("unable to connect to syslog, defaulting to stderr")
return return
} }
case "file": case "file":
f, err := os.OpenFile(url.Path, os.O_RDWR|os.O_APPEND|os.O_CREATE, 0666) f, err := os.OpenFile(parsed.Path, os.O_RDWR|os.O_APPEND|os.O_CREATE, 0666)
if err != nil { if err != nil {
logrus.WithError(err).WithFields(logrus.Fields{"to": to, "path": url.Path}).Error("cannot open file, defaulting to stderr") logrus.WithError(err).WithFields(logrus.Fields{"to": to, "path": parsed.Path}).Error("cannot open file, defaulting to stderr")
return return
} }
logrus.SetOutput(f) logrus.SetOutput(f)
default: default:
logrus.WithFields(logrus.Fields{"scheme": url.Scheme, "to": to}).Error("unknown logging location scheme, defaulting to stderr") logrus.WithFields(logrus.Fields{"scheme": parsed.Scheme, "to": to}).Error("unknown logging location scheme, defaulting to stderr")
} }
} }