Middleware (#502)

* API endpoint extensions working.

extensions example.

extensions example.

* Added server.NewEnv and some docs for the API extensions example.

extensions example.

extensions example.

* Uncommented special handler stuff.

* First example of middleware.

easier to use.

* Added a special Middleware context to make middleware easier to use.

* Fix tests.

* Cleanup based on PR comments.
This commit is contained in:
Travis Reeder
2017-01-30 14:43:23 -08:00
committed by C Cirello
parent 37efa47bdf
commit ce26f665ea
10 changed files with 213 additions and 48 deletions

102
api/server/middleware.go Normal file
View File

@@ -0,0 +1,102 @@
// TODO: it would be nice to move these into the top level folder so people can use these with the "functions" package, eg: functions.AddMiddleware(...)
package server
import (
"context"
"net/http"
"github.com/Sirupsen/logrus"
"github.com/gin-gonic/gin"
"github.com/iron-io/functions/api/models"
)
// Middleware is the interface required for implementing functions middlewar
type Middleware interface {
// Serve is what the Middleware must implement. Can modify the request, write output, etc.
// todo: should we abstract the HTTP out of this? In case we want to support other protocols.
Serve(ctx MiddlewareContext, w http.ResponseWriter, r *http.Request, app *models.App) error
}
// MiddlewareFunc func form of Middleware
type MiddlewareFunc func(ctx MiddlewareContext, w http.ResponseWriter, r *http.Request, app *models.App) error
// Serve wrapper
func (f MiddlewareFunc) Serve(ctx MiddlewareContext, w http.ResponseWriter, r *http.Request, app *models.App) error {
return f(ctx, w, r, app)
}
// MiddlewareContext extends context.Context for Middleware
type MiddlewareContext interface {
context.Context
// Middleware can call Next() explicitly to call the next middleware in the chain. If Next() is not called and an error is not returned, Next() will automatically be called.
Next()
// Index returns the index of where we're at in the chain
Index() int
}
type middlewareContextImpl struct {
context.Context
ginContext *gin.Context
nextCalled bool
index int
middlewares []Middleware
}
func (c *middlewareContextImpl) Next() {
c.nextCalled = true
c.index++
c.serveNext()
}
func (c *middlewareContextImpl) serveNext() {
if c.Index() >= len(c.middlewares) {
return
}
// make shallow copy:
fctx2 := *c
fctx2.nextCalled = false
r := c.ginContext.Request.WithContext(fctx2)
err := c.middlewares[c.Index()].Serve(&fctx2, c.ginContext.Writer, r, nil)
if err != nil {
logrus.WithError(err).Warnln("Middleware error")
// todo: might be a good idea to check if anything is written yet, and if not, output the error: simpleError(err)
// see: http://stackoverflow.com/questions/39415827/golang-http-check-if-responsewriter-has-been-written
c.ginContext.Abort()
return
}
if !fctx2.nextCalled {
// then we automatically call next
fctx2.Next()
}
}
func (c *middlewareContextImpl) Index() int {
return c.index
}
func (s *Server) middlewareWrapperFunc(ctx context.Context) gin.HandlerFunc {
return func(c *gin.Context) {
if len(s.middlewares) == 0 {
return
}
ctx = c.MustGet("ctx").(context.Context)
fctx := &middlewareContextImpl{Context: ctx}
fctx.index = -1
fctx.ginContext = c
fctx.middlewares = s.middlewares
// start the chain:
fctx.Next()
}
}
// AddAppEndpoint adds an endpoints to /v1/apps/:app/x
func (s *Server) AddMiddleware(m Middleware) {
s.middlewares = append(s.middlewares, m)
}
// AddAppEndpoint adds an endpoints to /v1/apps/:app/x
func (s *Server) AddMiddlewareFunc(m func(ctx MiddlewareContext, w http.ResponseWriter, r *http.Request, app *models.App) error) {
s.AddMiddleware(MiddlewareFunc(m))
}