alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

fn: fixup possible go-routine leak (#1265)

Browse Source
This commit is contained in:
Tolga Ceylan
2018-10-05 17:02:18 -07:00
committed by GitHub
parent b7d53332d3
commit f10fab21bc
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
api/agent/agent.go
View File

@@ -784,10 +784,17 @@ func (s *hotSlot) dispatch(ctx context.Context, call *call) chan error {
} }
common.Logger(ctx).WithField("resp", resp).Debug("Got resp from UDS socket") common.Logger(ctx).WithField("resp", resp).Debug("Got resp from UDS socket")
// if ctx is canceled/timedout, then we close the body to unlock writeResp() below
defer resp.Body.Close() defer resp.Body.Close()
ioErrChan := make(chan error, 1)
go func() {
ioErrChan <- writeResp(s.cfg.MaxResponseSize, resp, call.w)
}()
select { select {
case errApp <- writeResp(s.cfg.MaxResponseSize, resp, call.w): case ioErr := <-ioErrChan:
errApp <- ioErr
case <-ctx.Done(): case <-ctx.Done():
errApp <- ctx.Err() errApp <- ctx.Err()
} }