From f797cb933f5be63e088cf68b5b7be5a0c80d1eb5 Mon Sep 17 00:00:00 2001 From: Tolga Ceylan Date: Mon, 19 Nov 2018 12:23:59 -0800 Subject: [PATCH] fn: remove error formatting in fireBeforeCall/fireAfterCall (#1317) fmt.Errorf strips API errors in models, we should propagate the error directly. --- api/agent/call.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/api/agent/call.go b/api/agent/call.go index 16ae89a29..7af811520 100644 --- a/api/agent/call.go +++ b/api/agent/call.go @@ -342,12 +342,7 @@ func (c *call) Start(ctx context.Context) error { } } - err := c.ct.fireBeforeCall(ctx, c.Model()) - if err != nil { - return fmt.Errorf("BeforeCall: %v", err) - } - - return nil + return c.ct.fireBeforeCall(ctx, c.Model()) } func (c *call) End(ctx context.Context, errIn error) error { @@ -378,8 +373,7 @@ func (c *call) End(ctx context.Context, errIn error) error { c.stderr.Close() if err := c.ct.fireAfterCall(ctx, c.Model()); err != nil { - return fmt.Errorf("AfterCall: %v", err) + return err } - return errIn // original error, important for use in sync call returns }