mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
Use retry func while trying to ping SQL datastore (#630)
* Use retry func while trying to ping SQL datastore - implements retry func specifically for SQL datastore ping - fmt fixes - using sqlx.Db.PingContext instead of sqlx.Db.Ping - propogate context to SQL datastore * Rely on context from ServerOpt * Consolidate log instances * Cleanup * Fix server usage in API tests
This commit is contained in:
committed by
Reed Allman
parent
4a85806544
commit
faaf5846ce
@@ -4,21 +4,24 @@ import (
|
||||
"fmt"
|
||||
"net/url"
|
||||
|
||||
"context"
|
||||
"github.com/fnproject/fn/api/common"
|
||||
"github.com/fnproject/fn/api/datastore/sql"
|
||||
"github.com/fnproject/fn/api/logs/s3"
|
||||
"github.com/fnproject/fn/api/models"
|
||||
"github.com/sirupsen/logrus"
|
||||
)
|
||||
|
||||
func New(dbURL string) (models.LogStore, error) {
|
||||
func New(ctx context.Context, dbURL string) (models.LogStore, error) {
|
||||
log := common.Logger(ctx)
|
||||
u, err := url.Parse(dbURL)
|
||||
if err != nil {
|
||||
logrus.WithError(err).WithFields(logrus.Fields{"url": dbURL}).Fatal("bad DB URL")
|
||||
log.WithError(err).WithFields(logrus.Fields{"url": dbURL}).Fatal("bad DB URL")
|
||||
}
|
||||
logrus.WithFields(logrus.Fields{"db": u.Scheme}).Debug("creating log store")
|
||||
log.WithFields(logrus.Fields{"db": u.Scheme}).Debug("creating log store")
|
||||
switch u.Scheme {
|
||||
case "sqlite3", "postgres", "mysql":
|
||||
return sql.New(u)
|
||||
return sql.New(ctx, u)
|
||||
case "s3":
|
||||
return s3.New(u)
|
||||
default:
|
||||
|
||||
Reference in New Issue
Block a user