alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

fn: cookie and driver api changes (#1312)

Browse Source 
Now obsoleted driver.PrepareCookie() call handled image and
container creation. In agent, going forward we will need finer
grained control over the timeouts implied by the contexts.
For this reason, with this change, we split PrepareCookie()
into Validate/Pull/Create calls under Cookie interface.
This commit is contained in:
Tolga Ceylan
2018-11-14 16:51:05 -08:00
committed by GitHub
parent 65f3f915be
commit fe2b9fb53d
7 changed files with 239 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
api/agent/drivers/driver.go
View File

@@ -41,6 +41,16 @@ type Cookie interface {
// Unfreeze a frozen container to unpause frozen processes
Unfreeze(ctx context.Context) error
// Validate/Inspect and Authenticate image. Returns true if the image needs
// to be pulled and non-nil error if validation/auth/inspection fails.
ValidateImage(ctx context.Context) (bool, error)
// Pull the image.
PullImage(ctx context.Context) error
// Create container which can be Run() later
CreateContainer(ctx context.Context) error
// Fetch driver specific container configuration. Use this to
// access the container create options. If Driver.Prepare() is not
// yet called with the cookie, then this can be used to modify container
@@ -61,14 +71,7 @@ type Driver interface {
// Callers should Close the cookie regardless of whether they prepare or run it.
CreateCookie(ctx context.Context, task ContainerTask) (Cookie, error)
// PrepareCookie can be used in order to do any preparation that a specific driver
// may need to do before running the task, and can be useful to put
// preparation that the task can recover from into (i.e. if pulling an image
// fails because a registry is down, the task doesn't need to be failed). It
// returns a cookie that can be used to execute the task.
// Callers should Close the cookie regardless of whether they run it.
//
// The returned cookie should respect the task's timeout when it is run.
// Obsoleted. No-Op
PrepareCookie(ctx context.Context, cookie Cookie) error
// close & shutdown the driver