Clean up/make consistent the APIs for registering core components, make Docker an optional component at compile time (#1111)

api/datastore/datastore.go

@@ -44,8 +44,8 @@ type Provider interface {
 
 var providers []Provider
 
-// AddProvider globally registers a data store provider
-func AddProvider(provider Provider) {
-	logrus.Infof("Adding DataStore provider %s", provider)
+// Register globally registers a data store provider
+func Register(provider Provider) {
+	logrus.Infof("Registering data store provider '%s'", provider)
 	providers = append(providers, provider)
 }

api/datastore/sql/dbhelper/dbhelper.go

@@ -10,9 +10,9 @@ import (
 
 var sqlHelpers []Helper
 
-//Add registers a new SQL helper
-func Add(helper Helper) {
-	logrus.Infof("Registering DB helper %s", helper)
+//Register registers a new SQL helper
+func Register(helper Helper) {
+	logrus.Infof("Registering sql helper '%s'", helper)
 	sqlHelpers = append(sqlHelpers, helper)
 }
 

api/datastore/sql/mysql/mysql.go

@@ -57,5 +57,5 @@ func (mysqlHelper) IsDuplicateKeyError(err error) bool {
 }
 
 func init() {
-	dbhelper.Add(mysqlHelper(0))
+	dbhelper.Register(mysqlHelper(0))
 }

api/datastore/sql/postgres/postgres.go

@@ -59,5 +59,5 @@ func (postgresHelper) IsDuplicateKeyError(err error) bool {
 }
 
 func init() {
-	dbhelper.Add(postgresHelper(0))
+	dbhelper.Register(postgresHelper(0))
 }

api/datastore/sql/sql.go

@@ -1443,6 +1443,6 @@ func (ds *SQLStore) Close() error {
 }
 
 func init() {
-	datastore.AddProvider(sqlDsProvider(0))
-	logs.AddProvider(sqlLogsProvider(0))
+	datastore.Register(sqlDsProvider(0))
+	logs.Register(sqlLogsProvider(0))
 }

api/datastore/sql/sqlite/sqlite.go

@@ -70,5 +70,5 @@ func (sqliteHelper) IsDuplicateKeyError(err error) bool {
 }
 
 func init() {
-	dbhelper.Add(sqliteHelper(0))
+	dbhelper.Register(sqliteHelper(0))
 }