15 Commits

Author	SHA1	Message	Date
Reed Allman	c0aed2fbb0	mask errors in api response, log real error ... we had this _almost_ right, in that we were trying, but we weren't masking the error from the user response for any error we don't intend to show. this also adds a stack trace from any internal server errors, so that we might be able to track them down in the future (looking at you, 'context deadline exceeded'). in addition, this adds a new `models.APIError` interface which all of the errors in `models` now implement, and can be caught easily / added to easily. the front end now does no status rewriting based on api errors, now when we get a non-nil error we can call `handleResponse(c, err)` with it and if it's a proper error, return it to the user with the right status code, otherwise log a stack trace and return `internal server error`. this cleans up a lot of the front end code. also rewrites start task ctx deadline exceeded as timeout. with iw we had async tasks so we could start the clock later and it didn't matter, but now with sync tasks time out sometimes just making docker calls, and we want the task status to show up as timed out. we may want to just catch all this above in addition to this, but this seems like the right thing to do. remove squishing together errors. this was weird, now we return the first error for the purposes of using the new err interface. removed a lot of 5xx errors that really should have been 4xx errors. changed some of the 400 errors to 409 errors, since they are from sending in conflicting info and not a malformed request. removed unused errors / useless errors (many were used for logging, and didn't provide any context. now with stack traces we don't need context as much in the logs).	2017-07-14 03:44:16 -07:00
Travis Reeder	86b93e27f7	Updated ctx to MiddlewareContext in various places.	2017-07-12 21:40:16 -07:00
James Jeffrey	55239dbd80	Check both errors	2017-07-06 12:42:09 -07:00
James Jeffrey	7ebf8ab144	No nil errors on error	2017-07-06 12:23:44 -07:00
James Jeffrey	61bd41f9b2	Error apps create not route	2017-07-06 12:22:03 -07:00
James Jeffrey	e5b1bb03ea	Address more comments. Add docs and clean up comments	2017-07-06 12:19:48 -07:00
James Jeffrey	d3fb420be0	Move logging. Remove todo comment	2017-07-06 12:08:17 -07:00
James Jeffrey	77c5d38381	Update docs	2017-07-06 11:46:25 -07:00
James Jeffrey	021bb32a22	Refactor tests to use testRoute case struct. Use one method for tests. Fix logic for when to skipzero	2017-07-06 11:46:25 -07:00
James Jeffrey	3087a12b83	Needs != for this. Do not try to test client for functions go if there	2017-07-06 11:46:25 -07:00
James Jeffrey	7f226bc96b	Assign err. Fixes tests that were not working	2017-07-06 11:46:25 -07:00
James Jeffrey	b4d39c0f3c	Refactor seperate out logic	2017-07-06 11:46:24 -07:00
James Jeffrey	4845ddb1d4	Only use 200 follows what others do. Less switching. Remove defense	2017-07-06 11:46:24 -07:00
James Jeffrey	c66a0d0cc4	Update swagger doc. Indicate to user if updated or created	2017-07-06 11:46:24 -07:00
James Jeffrey	70eb25c873	Change logic behind put post and patch for routes	2017-07-06 11:46:24 -07:00