mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
the mqs are storing a models.Task, which was not incorporating all the fields that are in a task.Config. I would very much like to merge these two things, but expect to do this in a future restructuring as both are used widely and not cordoned off properly (Config has a channel, stdin, stdout, stderr -- and isn't just a 'config', so to speak, as Task is). Since a task.Config is what is used to actually run a container, the result of the aforementioned deficiency was #193 where tasks are improperly configured and ran (namely, memory wrong). async tasks can still not be hot, they will be reverted to default format. would also like to fix this (also part of restructuring). I actually started doing this, hence the changes to those files (the surface area of the change is small and discourages improper future use, so I've left what I've done). this will: closes #193 closes #195 closes #154 removes many unused fields in models.Task, since we have not implemented retries. priority & delay are left, even though they are not used either, the main goal of this is to resolve #193 and both these fields are strongly plumbed into all the mqs, so punting on those two.
20 lines
330 B
Go
20 lines
330 B
Go
package protocol
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/fnproject/fn/api/runner/task"
|
|
)
|
|
|
|
// DefaultProtocol is the protocol used by cold-containers
|
|
type DefaultProtocol struct {
|
|
}
|
|
|
|
func (p *DefaultProtocol) IsStreamable() bool {
|
|
return false
|
|
}
|
|
|
|
func (p *DefaultProtocol) Dispatch(context.Context, *task.Config) error {
|
|
return nil
|
|
}
|