mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
3ab49d4701
closes #317 we could fiddle with this, but we need to at least bound these. this accomplishes that. 1m is picked since that's our default max log size for the time being per call, it also takes a little time to generate that many bytes through logs, typically (i.e. without trying to). I tested with 0, which spiked the i/o rate on my machine because it's constantly deleting the json log file. I also tested with 1k and it was similar (for a task that generated about 1k in logs quickly) -- in testing, this halved my throughput, whereas using 1m did not change the throughput at all. trying the 'none' driver and 'syslog' driver weren't great, 'none' turns off all stderr and 'syslog' blocks every log line (boo). anyway, this option seems to have no affect on the output we get in 'attach', which is what we really care about (i.e. docker is not logically capping this, just swapping out the log file). using 1m for this, e.g. if we have 500 hot containers on a machine we have potentially half a gig of worthless logs laying around. we don't need the docker logs laying around at all really, but short of writing a storage driver ourselves there don't seem to be too many better options. open to idears, but this is likely to hold us over for some time.