mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
9eaf824398
* add jaeger support, link hot container & req span * adds jaeger support now with FN_JAEGER_URL, there's a simple tutorial in the operating/metrics.md file now and it's pretty easy to get up and running. * links a hot request span to a hot container span. when we change this to sample at a lower ratio we'll need to finagle the hot container span to always sample or something, otherwise we'll hide that info. at least, since we're sampling at 100% for now if this is flipped on, can see freeze/unfreeze etc. if they hit. this is useful for debugging. note that zipkin's exporter does not follow the link at all, hence jaeger... and they're backed by the Cloud Empire now (CNCF) so we'll probably use it anyway. * vendor: add thrift for jaeger
Typical usage
thrift.exe --audit <oldFile> <newFile>
Example run
> thrift.exe --audit test.thrift break1.thrift
[Thrift Audit Failure:break1.thrift] New Thrift File has missing function base_function3
[Thrift Audit Warning:break1.thrift] Constant const3 has different value
Problems that the audit tool can catch
Errors
- Removing an enum value
- Changing the type of a struct field
- Changing the required-ness of a struct field
- Removing a struct field
- Adding a required struct field
- Adding a struct field 'in the middle'. This usually indicates an old ID has been recycled
- Struct removed
- Oneway-ness change
- Return type change
- Missing function
- Missing service
- Change in service inheritance
Warnings
- Removing a language namespace declaration
- Changing a namespace
- Changing an enum value's name
- Removing an enum class
- Default value changed
- Struct field name change
- Removed constant
- Type of constant changed
- Value of constant changed