mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
* get rid of old format stuff, utils usage, fix up for fdk2.0 interface * pure agent format removal, TODO remove format field, fix up all tests * shitter's clogged * fix agent tests * start rolling through server tests * tests compile, some failures * remove json / content type detection on invoke/httptrigger, fix up tests * remove hello, fixup system tests the fucking status checker test just hangs and it's testing that it doesn't work so the test passes but the test doesn't pass fuck life it's not worth it * fix migration * meh * make dbhelper shut up about dbhelpers not being used * move fail status at least into main thread, jfc * fix status call to have FN_LISTENER also turns off the stdout/stderr blocking between calls, because it's impossible to debug without that (without syslog), now that stdout and stderr go to the same place (either to host stderr or nowhere) and isn't used for function output this shouldn't be a big fuss really * remove stdin * cleanup/remind: fixed bug where watcher would leak if container dies first * silence system-test logs until fail, fix datastore tests postgres does weird things with constraints when renaming tables, took the easy way out system-tests were loud as fuck and made you download a circleci text file of the logs, made them only yell when they goof * fix fdk-go dep for test image. fun * fix swagger and remove test about format * update all the gopkg files * add back FN_FORMAT for fdks that assert things. pfft * add useful error for functions that exit this error is really confounding because containers can exit for all manner of reason, we're just guessing that this is the most likely cause for now, and this error message should very likely change or be removed from the client path anyway (context.Canceled wasn't all that useful either, but anyway, I'd been hunting for this... so found it). added a test to avoid being publicly shamed for 1 line commits (beware...).
113 lines
3.2 KiB
Go
113 lines
3.2 KiB
Go
package server
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"net/http"
|
|
"strconv"
|
|
"sync"
|
|
|
|
"github.com/fnproject/fn/api"
|
|
"github.com/fnproject/fn/api/agent"
|
|
"github.com/fnproject/fn/api/common"
|
|
"github.com/fnproject/fn/api/models"
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
var (
|
|
bufPool = &sync.Pool{New: func() interface{} { return new(bytes.Buffer) }}
|
|
)
|
|
|
|
// implements http.ResponseWriter
|
|
// this little guy buffers responses from user containers and lets them still
|
|
// set headers and such without us risking writing partial output [as much, the
|
|
// server could still die while we're copying the buffer]. this lets us set
|
|
// content length and content type nicely, as a bonus. it is sad, yes.
|
|
type syncResponseWriter struct {
|
|
headers http.Header
|
|
status int
|
|
*bytes.Buffer
|
|
}
|
|
|
|
var _ http.ResponseWriter = new(syncResponseWriter) // nice compiler errors
|
|
|
|
func (s *syncResponseWriter) Header() http.Header { return s.headers }
|
|
func (s *syncResponseWriter) WriteHeader(code int) { s.status = code }
|
|
|
|
// handleFnInvokeCall executes the function, for router handlers
|
|
func (s *Server) handleFnInvokeCall(c *gin.Context) {
|
|
fnID := c.Param(api.ParamFnID)
|
|
ctx, _ := common.LoggerWithFields(c.Request.Context(), logrus.Fields{"fnID": fnID})
|
|
c.Request = c.Request.WithContext(ctx)
|
|
err := s.handleFnInvokeCall2(c)
|
|
if err != nil {
|
|
handleErrorResponse(c, err)
|
|
}
|
|
}
|
|
|
|
// handleTriggerHTTPFunctionCall2 executes the function and returns an error
|
|
// Requires the following in the context:
|
|
func (s *Server) handleFnInvokeCall2(c *gin.Context) error {
|
|
// log := common.Logger(c.Request.Context())
|
|
|
|
fn, err := s.lbReadAccess.GetFnByID(c, c.Param(api.ParamFnID))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
app, err := s.lbReadAccess.GetAppByID(c, fn.AppID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return s.ServeFnInvoke(c, app, fn)
|
|
}
|
|
|
|
func (s *Server) ServeFnInvoke(c *gin.Context, app *models.App, fn *models.Fn) error {
|
|
return s.fnInvoke(c.Writer, c.Request, app, fn, nil)
|
|
}
|
|
|
|
func (s *Server) fnInvoke(resp http.ResponseWriter, req *http.Request, app *models.App, fn *models.Fn, trig *models.Trigger) error {
|
|
// TODO: we should get rid of the buffers, and stream back (saves memory (+splice), faster (splice), allows streaming, don't have to cap resp size)
|
|
// buffer the response before writing it out to client to prevent partials from trying to stream
|
|
buf := bufPool.Get().(*bytes.Buffer)
|
|
buf.Reset()
|
|
writer := syncResponseWriter{
|
|
headers: resp.Header(),
|
|
status: 200,
|
|
Buffer: buf,
|
|
}
|
|
|
|
opts := []agent.CallOpt{
|
|
agent.WithWriter(&writer), // XXX (reed): order matters [for now]
|
|
agent.FromHTTPFnRequest(app, fn, req),
|
|
}
|
|
if trig != nil {
|
|
opts = append(opts, agent.WithTrigger(trig))
|
|
}
|
|
|
|
call, err := s.agent.GetCall(opts...)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = s.agent.Submit(call)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// because we can...
|
|
writer.Header().Set("Content-Length", strconv.Itoa(int(buf.Len())))
|
|
writer.Header().Add("Fn-Call-Id", call.Model().ID) // XXX(reed): move to before Submit when adding streaming
|
|
|
|
// buffered response writer traps status (so we can add headers), we need to write it still
|
|
if writer.status > 0 {
|
|
resp.WriteHeader(writer.status)
|
|
}
|
|
|
|
io.Copy(resp, buf)
|
|
bufPool.Put(buf) // at this point, submit returned without timing out, so we can re-use this one
|
|
return nil
|
|
}
|