mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
the mqs are storing a models.Task, which was not incorporating all the fields that are in a task.Config. I would very much like to merge these two things, but expect to do this in a future restructuring as both are used widely and not cordoned off properly (Config has a channel, stdin, stdout, stderr -- and isn't just a 'config', so to speak, as Task is). Since a task.Config is what is used to actually run a container, the result of the aforementioned deficiency was #193 where tasks are improperly configured and ran (namely, memory wrong). async tasks can still not be hot, they will be reverted to default format. would also like to fix this (also part of restructuring). I actually started doing this, hence the changes to those files (the surface area of the change is small and discourages improper future use, so I've left what I've done). this will: closes #193 closes #195 closes #154 removes many unused fields in models.Task, since we have not implemented retries. priority & delay are left, even though they are not used either, the main goal of this is to resolve #193 and both these fields are strongly plumbed into all the mqs, so punting on those two.
339 lines
8.0 KiB
Go
339 lines
8.0 KiB
Go
package runner
|
|
|
|
import (
|
|
"bufio"
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"runtime"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
"github.com/fnproject/fn/api/models"
|
|
"github.com/fnproject/fn/api/runner/common"
|
|
"github.com/fnproject/fn/api/runner/drivers"
|
|
"github.com/fnproject/fn/api/runner/drivers/docker"
|
|
"github.com/fnproject/fn/api/runner/drivers/mock"
|
|
"github.com/fnproject/fn/api/runner/task"
|
|
"github.com/opentracing/opentracing-go"
|
|
"github.com/opentracing/opentracing-go/log"
|
|
)
|
|
|
|
// TODO clean all of this up, the exposed API is huge and incohesive,
|
|
// we need 1 thing that runs 1 thing and 1 thing that runs those things;
|
|
// right now this is all the things.
|
|
type Runner struct {
|
|
driver drivers.Driver
|
|
taskQueue chan *containerTask
|
|
flog FuncLogger
|
|
availableMem int64
|
|
usedMem int64
|
|
usedMemMutex sync.RWMutex
|
|
hcmgr htfnmgr
|
|
datastore models.Datastore
|
|
|
|
stats
|
|
}
|
|
|
|
var (
|
|
ErrTimeOutNoMemory = errors.New("Task timed out. No available memory.")
|
|
ErrFullQueue = errors.New("The runner queue is full")
|
|
WaitMemoryTimeout = 10 * time.Second
|
|
)
|
|
|
|
const (
|
|
DefaultTimeout = 30 * time.Second
|
|
DefaultIdleTimeout = 30 * time.Second
|
|
)
|
|
|
|
func New(ctx context.Context, flog FuncLogger, ds models.Datastore) (*Runner, error) {
|
|
// TODO: Is this really required for the container drivers? Can we remove it?
|
|
env := common.NewEnvironment(func(e *common.Environment) {})
|
|
|
|
// TODO: Create drivers.New(runnerConfig)
|
|
driver, err := selectDriver("docker", env, &drivers.Config{})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
r := &Runner{
|
|
driver: driver,
|
|
taskQueue: make(chan *containerTask, 100),
|
|
flog: flog,
|
|
availableMem: getAvailableMemory(),
|
|
usedMem: 0,
|
|
datastore: ds,
|
|
}
|
|
|
|
go r.queueHandler(ctx)
|
|
|
|
return r, nil
|
|
}
|
|
|
|
// This routine checks for available memory;
|
|
// If there's memory then send signal to the task to proceed.
|
|
// If there's not available memory to run the task it waits
|
|
// If the task waits for more than X seconds it timeouts
|
|
func (r *Runner) queueHandler(ctx context.Context) {
|
|
consumeQueue:
|
|
for {
|
|
select {
|
|
case task := <-r.taskQueue:
|
|
r.handleTask(task)
|
|
case <-ctx.Done():
|
|
break consumeQueue
|
|
}
|
|
}
|
|
|
|
// consume remainders
|
|
for len(r.taskQueue) > 0 {
|
|
r.handleTask(<-r.taskQueue)
|
|
}
|
|
}
|
|
|
|
func (r *Runner) handleTask(task *containerTask) {
|
|
waitStart := time.Now()
|
|
|
|
var waitTime time.Duration
|
|
var timedOut bool
|
|
|
|
// Loop waiting for available memory
|
|
for !r.checkRequiredMem(task.cfg.Memory) {
|
|
waitTime = time.Since(waitStart)
|
|
if waitTime > WaitMemoryTimeout {
|
|
timedOut = true
|
|
break
|
|
}
|
|
time.Sleep(time.Microsecond)
|
|
}
|
|
|
|
if timedOut {
|
|
// Send to a signal to this task saying it cannot run
|
|
task.canRun <- false
|
|
return
|
|
}
|
|
|
|
// Send a signal to this task saying it can run
|
|
task.canRun <- true
|
|
}
|
|
|
|
func (r *Runner) hasAsyncAvailableMemory() bool {
|
|
r.usedMemMutex.RLock()
|
|
defer r.usedMemMutex.RUnlock()
|
|
// reserve at least half of the memory for sync
|
|
return (r.availableMem/2)-r.usedMem > 0
|
|
}
|
|
|
|
func (r *Runner) checkRequiredMem(req uint64) bool {
|
|
r.usedMemMutex.RLock()
|
|
defer r.usedMemMutex.RUnlock()
|
|
return r.availableMem-r.usedMem-(int64(req)*1024*1024) > 0
|
|
}
|
|
|
|
func (r *Runner) addUsedMem(used int64) {
|
|
r.usedMemMutex.Lock()
|
|
r.usedMem = r.usedMem + used*1024*1024
|
|
if r.usedMem < 0 {
|
|
r.usedMem = 0
|
|
}
|
|
r.usedMemMutex.Unlock()
|
|
}
|
|
|
|
func (r *Runner) checkMemAndUse(req uint64) bool {
|
|
r.usedMemMutex.Lock()
|
|
defer r.usedMemMutex.Unlock()
|
|
|
|
used := int64(req) * 1024 * 1024
|
|
|
|
if r.availableMem-r.usedMem-used < 0 {
|
|
return false
|
|
}
|
|
|
|
r.usedMem += used
|
|
|
|
return true
|
|
}
|
|
|
|
func (r *Runner) awaitSlot(ctask *containerTask) error {
|
|
span, _ := opentracing.StartSpanFromContext(ctask.ctx, "wait_mem_slot")
|
|
defer span.Finish()
|
|
// Check if has enough available memory
|
|
// If available, use it
|
|
if !r.checkMemAndUse(ctask.cfg.Memory) {
|
|
// If not, try add task to the queue
|
|
select {
|
|
case r.taskQueue <- ctask:
|
|
default:
|
|
span.LogFields(log.Int("queue full", 1))
|
|
// If queue is full, return error
|
|
return ErrFullQueue
|
|
}
|
|
|
|
// If task was added to the queue, wait for permission
|
|
if ok := <-ctask.canRun; !ok {
|
|
span.LogFields(log.Int("memory timeout", 1))
|
|
// This task timed out, not available memory
|
|
return ErrTimeOutNoMemory
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// run is responsible for running 1 instance of a docker container
|
|
func (r *Runner) run(ctx context.Context, cfg *task.Config) (drivers.RunResult, error) {
|
|
span, ctx := opentracing.StartSpanFromContext(ctx, "run_container")
|
|
defer span.Finish()
|
|
|
|
if cfg.Stdout == nil {
|
|
// TODO why? async?
|
|
cfg.Stdout = cfg.Stderr
|
|
}
|
|
|
|
ctask := &containerTask{
|
|
ctx: ctx,
|
|
cfg: cfg,
|
|
canRun: make(chan bool),
|
|
}
|
|
|
|
err := r.awaitSlot(ctask)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer r.addUsedMem(-1 * int64(cfg.Memory))
|
|
|
|
span, pctx := opentracing.StartSpanFromContext(ctx, "prepare")
|
|
cookie, err := r.driver.Prepare(pctx, ctask)
|
|
span.Finish()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer cookie.Close(ctx)
|
|
|
|
select {
|
|
case <-cfg.Ready:
|
|
default:
|
|
close(cfg.Ready)
|
|
}
|
|
|
|
span, rctx := opentracing.StartSpanFromContext(ctx, "run")
|
|
result, err := cookie.Run(rctx)
|
|
span.Finish()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
span.LogFields(log.String("status", result.Status()))
|
|
return result, nil
|
|
}
|
|
|
|
func (r Runner) EnsureImageExists(ctx context.Context, cfg *task.Config) error {
|
|
ctask := &containerTask{
|
|
cfg: cfg,
|
|
}
|
|
|
|
auth, err := ctask.DockerAuth()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
_, err = docker.CheckRegistry(ctx, ctask.Image(), auth)
|
|
return err
|
|
}
|
|
|
|
func selectDriver(driver string, env *common.Environment, conf *drivers.Config) (drivers.Driver, error) {
|
|
switch driver {
|
|
case "docker":
|
|
docker := docker.NewDocker(env, *conf)
|
|
return docker, nil
|
|
case "mock":
|
|
return mock.New(), nil
|
|
}
|
|
return nil, fmt.Errorf("driver %v not found", driver)
|
|
}
|
|
|
|
func getAvailableMemory() int64 {
|
|
const tooBig = 322122547200 // #300GB or 0, biggest aws instance is 244GB
|
|
|
|
var availableMemory uint64 = tooBig
|
|
if runtime.GOOS == "linux" {
|
|
availableMemory, err := checkCgroup()
|
|
if err != nil {
|
|
logrus.WithError(err).Error("Error checking for cgroup memory limits, falling back to host memory available..")
|
|
}
|
|
if availableMemory > tooBig || availableMemory == 0 {
|
|
// Then -m flag probably wasn't set, so use max available on system
|
|
availableMemory, err = checkProc()
|
|
if err != errCantReadMemInfo &&
|
|
(availableMemory > tooBig || availableMemory == 0) {
|
|
logrus.WithError(err).Fatal("Cannot get the proper information to. You must specify the maximum available memory by passing the -m command with docker run when starting the runner via docker, eg: `docker run -m 2G ...`")
|
|
}
|
|
}
|
|
} else {
|
|
// This still lets 10-20 functions execute concurrently assuming a 2GB machine.
|
|
availableMemory = 2 * 1024 * 1024 * 1024
|
|
}
|
|
|
|
return int64(availableMemory)
|
|
}
|
|
|
|
func checkCgroup() (uint64, error) {
|
|
f, err := os.Open("/sys/fs/cgroup/memory/memory.limit_in_bytes")
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
defer f.Close()
|
|
b, err := ioutil.ReadAll(f)
|
|
limBytes := string(b)
|
|
limBytes = strings.TrimSpace(limBytes)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
return strconv.ParseUint(limBytes, 10, 64)
|
|
}
|
|
|
|
var errCantReadMemInfo = errors.New("Didn't find MemAvailable in /proc/meminfo, kernel is probably < 3.14")
|
|
|
|
func checkProc() (uint64, error) {
|
|
f, err := os.Open("/proc/meminfo")
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
defer f.Close()
|
|
|
|
scanner := bufio.NewScanner(f)
|
|
for scanner.Scan() {
|
|
b := scanner.Text()
|
|
if !strings.HasPrefix(b, "MemAvailable") {
|
|
continue
|
|
}
|
|
|
|
// expect form:
|
|
// MemAvailable: 1234567890 kB
|
|
tri := strings.Fields(b)
|
|
if len(tri) != 3 {
|
|
return 0, fmt.Errorf("MemAvailable line has unexpected format: %v", b)
|
|
}
|
|
|
|
c, err := strconv.ParseUint(tri[1], 10, 64)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("Could not parse MemAvailable: %v", b)
|
|
}
|
|
switch tri[2] { // convert units to bytes
|
|
case "kB":
|
|
c *= 1024
|
|
case "MB":
|
|
c *= 1024 * 1024
|
|
default:
|
|
return 0, fmt.Errorf("Unexpected units for MemAvailable in /proc/meminfo, need kB or MB, got: %v", tri[2])
|
|
}
|
|
return c, nil
|
|
}
|
|
|
|
return 0, errCantReadMemInfo
|
|
}
|