mirror of
https://github.com/fnproject/fn.git
synced 2022-10-28 21:29:17 +03:00
d336035678
* Add annotations for creation of triggers and fns along with the test for them fixes #1178 * Log errors and still return created resource for annotation failures
461 lines
16 KiB
Go
461 lines
16 KiB
Go
package server
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/fnproject/fn/api/datastore"
|
|
"github.com/fnproject/fn/api/logs"
|
|
"github.com/fnproject/fn/api/models"
|
|
"github.com/fnproject/fn/api/mqs"
|
|
)
|
|
|
|
const (
|
|
BaseRoute = "/v2/triggers"
|
|
)
|
|
|
|
func TestTriggerCreate(t *testing.T) {
|
|
buf := setLogBuffer()
|
|
defer func() {
|
|
if t.Failed() {
|
|
t.Log(buf.String())
|
|
}
|
|
}()
|
|
|
|
a := &models.App{ID: "appid"}
|
|
|
|
a2 := &models.App{ID: "appid2"}
|
|
|
|
fn := &models.Fn{ID: "fnid", AppID: a.ID}
|
|
fn.SetDefaults()
|
|
commonDS := datastore.NewMockInit([]*models.App{a, a2}, []*models.Fn{fn})
|
|
|
|
for i, test := range []struct {
|
|
mock models.Datastore
|
|
logDB models.LogStore
|
|
path string
|
|
body string
|
|
expectedCode int
|
|
expectedError error
|
|
}{
|
|
// errors
|
|
{commonDS, logs.NewMock(), BaseRoute, ``, http.StatusBadRequest, models.ErrInvalidJSON},
|
|
{commonDS, logs.NewMock(), BaseRoute, `{}`, http.StatusNotFound, models.ErrAppsNotFound},
|
|
{commonDS, logs.NewMock(), BaseRoute, `{"app_id":"appid"}`, http.StatusNotFound, models.ErrFnsNotFound},
|
|
{commonDS, logs.NewMock(), BaseRoute, `{"app_id":"appid", "fn_id":"fnid"}`, http.StatusBadRequest, models.ErrTriggerMissingName},
|
|
|
|
{commonDS, logs.NewMock(), BaseRoute, `{"app_id":"appid", "fn_id":"fnid", "name": "Test" }`, http.StatusBadRequest, models.ErrTriggerTypeUnknown},
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "name": "Test", "app_id": "appid", "fn_id": "fnid", "type":"http"}`, http.StatusBadRequest, models.ErrTriggerMissingSource},
|
|
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "name": "1234567890123456789012345678901", "app_id": "appid", "fn_id": "fnid", "type":"http"}`, http.StatusBadRequest, models.ErrTriggerTooLongName},
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "name": "&&%@!#$#@$","app_id": "appid", "fn_id": "fnid", "type":"http" }`, http.StatusBadRequest, models.ErrTriggerInvalidName},
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "name": "trigger", "app_id": "appid", "fn_id": "fnid", "type": "http", "source": "src", "annotations" : { "":"val" }}`, http.StatusBadRequest, models.ErrInvalidAnnotationKey},
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "id": "asdasca", "name": "trigger", "app_id": "appid", "fn_id": "fnid", "type": "http", "source": "src"}`, http.StatusBadRequest, models.ErrTriggerIDProvided},
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "name": "trigger", "app_id": "appid", "fn_id": "fnid", "type": "unsupported", "source": "src"}`, http.StatusBadRequest, models.ErrTriggerTypeUnknown},
|
|
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "name": "trigger", "app_id": "appid2", "fn_id": "fnid", "type": "http", "source": "src"}`, http.StatusBadRequest, models.ErrTriggerFnIDNotSameApp},
|
|
|
|
// // success
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "name": "trigger", "app_id": "appid", "fn_id": "fnid", "type": "http", "source": "src"}`, http.StatusOK, nil},
|
|
|
|
//repeated name
|
|
{commonDS, logs.NewMock(), BaseRoute, `{ "name": "trigger", "app_id": "appid", "fn_id": "fnid", "type": "http", "source": "src"}`, http.StatusConflict, nil},
|
|
} {
|
|
|
|
rnr, cancel := testRunner(t)
|
|
srv := testServer(test.mock, &mqs.Mock{}, test.logDB, rnr, ServerTypeFull)
|
|
router := srv.Router
|
|
|
|
body := bytes.NewBuffer([]byte(test.body))
|
|
_, rec := routerRequest(t, router, "POST", test.path, body)
|
|
|
|
if rec.Code != test.expectedCode {
|
|
t.Errorf("Test %d: Expected status code to be %d but was %d",
|
|
i, test.expectedCode, rec.Code)
|
|
}
|
|
|
|
if test.expectedError != nil {
|
|
resp := getErrorResponse(t, rec)
|
|
|
|
if !strings.Contains(resp.Message, test.expectedError.Error()) {
|
|
t.Errorf("Test %d: Expected error message to have `%s` but got `%s`",
|
|
i, test.expectedError.Error(), resp.Message)
|
|
}
|
|
}
|
|
|
|
if test.expectedCode == http.StatusOK {
|
|
var trigger models.Trigger
|
|
err := json.NewDecoder(rec.Body).Decode(&trigger)
|
|
if err != nil {
|
|
t.Log(buf.String())
|
|
t.Errorf("Test %d: error decoding body for 'ok' json, it was a lie: %v", i, err)
|
|
}
|
|
|
|
if trigger.ID == "" {
|
|
t.Fatalf("Missing ID ")
|
|
}
|
|
// IsZero() doesn't really work, this ensures it's not unset as long as we're not in 1970
|
|
if time.Time(trigger.CreatedAt).Before(time.Now().Add(-1 * time.Hour)) {
|
|
t.Log(buf.String())
|
|
t.Errorf("Test %d: expected created_at to be set on trigger, it wasn't: %s", i, trigger.CreatedAt)
|
|
}
|
|
if !(time.Time(trigger.CreatedAt)).Equal(time.Time(trigger.UpdatedAt)) {
|
|
t.Log(buf.String())
|
|
t.Errorf("Test %d: expected updated_at to be set and same as created at, it wasn't: %s %s", i, trigger.CreatedAt, trigger.UpdatedAt)
|
|
}
|
|
|
|
_, rec := routerRequest(t, router, "GET", BaseRoute+"/"+trigger.ID, body)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
t.Log(buf.String())
|
|
t.Errorf("Test %d: Expected to be able to GET trigger after successful PUT: %d", i, rec.Code)
|
|
}
|
|
|
|
var triggerGet models.Trigger
|
|
err = json.NewDecoder(rec.Body).Decode(&triggerGet)
|
|
if err != nil {
|
|
t.Log(buf.String())
|
|
t.Errorf("Test %d: error decoding body for GET 'ok' json, it was a lie: %v", i, err)
|
|
}
|
|
|
|
if !trigger.EqualsWithAnnotationSubset(&triggerGet) {
|
|
t.Errorf("Test %d: GET trigger should match result of PUT trigger: %v, %v", i, triggerGet, trigger)
|
|
}
|
|
|
|
cancel()
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestTriggerDelete(t *testing.T) {
|
|
buf := setLogBuffer()
|
|
defer func() {
|
|
if t.Failed() {
|
|
t.Log(buf.String())
|
|
}
|
|
}()
|
|
|
|
trig := &models.Trigger{
|
|
ID: "triggerid",
|
|
}
|
|
ds := datastore.NewMockInit([]*models.Trigger{trig})
|
|
for i, test := range []struct {
|
|
ds models.Datastore
|
|
logDB models.LogStore
|
|
path string
|
|
body string
|
|
expectedCode int
|
|
expectedError error
|
|
}{
|
|
{datastore.NewMock(), logs.NewMock(), BaseRoute + "/triggerid", "", http.StatusNotFound, nil},
|
|
{ds, logs.NewMock(), BaseRoute + "/triggerid", "", http.StatusNoContent, nil},
|
|
} {
|
|
rnr, cancel := testRunner(t)
|
|
srv := testServer(test.ds, &mqs.Mock{}, test.logDB, rnr, ServerTypeFull)
|
|
|
|
_, rec := routerRequest(t, srv.Router, "DELETE", test.path, nil)
|
|
|
|
if rec.Code != test.expectedCode {
|
|
t.Errorf("Test %d: Expected status code to be %d but was %d",
|
|
i, test.expectedCode, rec.Code)
|
|
}
|
|
|
|
if test.expectedError != nil {
|
|
resp := getErrorResponse(t, rec)
|
|
|
|
if !strings.Contains(resp.Message, test.expectedError.Error()) {
|
|
t.Errorf("Test %d: Expected error message to have `%s`",
|
|
i, test.expectedError.Error())
|
|
}
|
|
}
|
|
cancel()
|
|
}
|
|
}
|
|
|
|
func TestTriggerList(t *testing.T) {
|
|
buf := setLogBuffer()
|
|
defer func() {
|
|
if t.Failed() {
|
|
t.Log(buf.String())
|
|
}
|
|
}()
|
|
|
|
rnr, cancel := testRunner(t)
|
|
defer cancel()
|
|
|
|
app1 := &models.App{ID: "app_id1", Name: "myapp1"}
|
|
app2 := &models.App{ID: "app_id2", Name: "myapp2"}
|
|
fn1 := &models.Fn{ID: "fn_id1", Name: "myfn1"}
|
|
fn2 := &models.Fn{ID: "fn_id2", Name: "myfn2"}
|
|
fn3 := &models.Fn{ID: "fn_id3", Name: "myfn3"}
|
|
ds := datastore.NewMockInit(
|
|
[]*models.App{app1, app2},
|
|
[]*models.Fn{fn1, fn2, fn3},
|
|
[]*models.Trigger{
|
|
{ID: "trigger1", AppID: app1.ID, FnID: fn1.ID, Name: "trigger1"},
|
|
{ID: "trigger2", AppID: app1.ID, FnID: fn1.ID, Name: "trigger2"},
|
|
{ID: "trigger3", AppID: app1.ID, FnID: fn1.ID, Name: "trigger3"},
|
|
{ID: "trigger4", AppID: app1.ID, FnID: fn2.ID, Name: "trigger4"},
|
|
{ID: "trigger5", AppID: app2.ID, FnID: fn3.ID, Name: "trigger5"},
|
|
},
|
|
)
|
|
fnl := logs.NewMock()
|
|
srv := testServer(ds, &mqs.Mock{}, fnl, rnr, ServerTypeFull)
|
|
|
|
a1b := base64.RawURLEncoding.EncodeToString([]byte("trigger1"))
|
|
a2b := base64.RawURLEncoding.EncodeToString([]byte("trigger2"))
|
|
a3b := base64.RawURLEncoding.EncodeToString([]byte("trigger3"))
|
|
|
|
for i, test := range []struct {
|
|
path string
|
|
body string
|
|
expectedCode int
|
|
expectedError error
|
|
expectedLen int
|
|
nextCursor string
|
|
}{
|
|
{"/v2/triggers?per_page", "", http.StatusBadRequest, nil, 0, ""},
|
|
{"/v2/triggers?app_id=app_id1", "", http.StatusOK, nil, 4, ""},
|
|
{"/v2/triggers?app_id=app_id2", "", http.StatusOK, nil, 1, ""},
|
|
{"/v2/triggers?app_id=app_id1&name=trigger1", "", http.StatusOK, nil, 1, ""},
|
|
{"/v2/triggers?app_id=app_id1&fn_id=fn_id1", "", http.StatusOK, nil, 3, ""},
|
|
{"/v2/triggers?app_id=app_id1&fn_id=fn_id1&per_page", "", http.StatusOK, nil, 3, ""},
|
|
{"/v2/triggers?app_id=app_id1&fn_id=fn_id1&per_page=1", "", http.StatusOK, nil, 1, a1b},
|
|
{"/v2/triggers?app_id=app_id1&fn_id=fn_id1&per_page=1&cursor=" + a1b, "", http.StatusOK, nil, 1, a2b},
|
|
{"/v2/triggers?app_id=app_id1&fn_id=fn_id1&per_page=1&cursor=" + a2b, "", http.StatusOK, nil, 1, a3b},
|
|
{"/v2/triggers?app_id=app_id1&fn_id=fn_id1&per_page=100&cursor=" + a2b, "", http.StatusOK, nil, 1, ""}, // cursor is empty if per_page > len(results)
|
|
{"/v2/triggers?app_id=app_id1&fn_id=fn_id1&per_page=1&cursor=" + a3b, "", http.StatusOK, nil, 0, ""}, // cursor could point to empty page
|
|
} {
|
|
_, rec := routerRequest(t, srv.Router, "GET", test.path, nil)
|
|
|
|
if rec.Code != test.expectedCode {
|
|
t.Errorf("Test %d: Expected status code to be %d but was %d",
|
|
i, test.expectedCode, rec.Code)
|
|
resp := getErrorResponse(t, rec)
|
|
t.Errorf("Message %s", resp.Message)
|
|
}
|
|
|
|
if test.expectedError != nil {
|
|
resp := getErrorResponse(t, rec)
|
|
|
|
if !strings.Contains(resp.Message, test.expectedError.Error()) {
|
|
t.Errorf("Test %d: Expected error message to have `%s`",
|
|
i, test.expectedError.Error())
|
|
}
|
|
} else {
|
|
// normal path
|
|
|
|
var resp models.TriggerList
|
|
err := json.NewDecoder(rec.Body).Decode(&resp)
|
|
if err != nil {
|
|
t.Errorf("Test %d: Expected response body to be a valid json object. err: %v", i, err)
|
|
}
|
|
if len(resp.Items) != test.expectedLen {
|
|
t.Errorf("Test %d: Expected triggers length to be %d, but got %d", i, test.expectedLen, len(resp.Items))
|
|
}
|
|
if resp.NextCursor != test.nextCursor {
|
|
t.Errorf("Test %d: Expected next_cursor to be %s, but got %s", i, test.nextCursor, resp.NextCursor)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestTriggerGet(t *testing.T) {
|
|
buf := setLogBuffer()
|
|
defer func() {
|
|
if t.Failed() {
|
|
t.Log(buf.String())
|
|
}
|
|
}()
|
|
|
|
a := &models.App{ID: "appid"}
|
|
|
|
fn := &models.Fn{ID: "fnid", AppID: a.ID}
|
|
fn.SetDefaults()
|
|
|
|
trig := &models.Trigger{ID: "triggerid", FnID: fn.ID, AppID: a.ID}
|
|
commonDS := datastore.NewMockInit([]*models.App{a}, []*models.Fn{fn}, []*models.Trigger{trig})
|
|
|
|
for i, test := range []struct {
|
|
mock models.Datastore
|
|
logDB models.LogStore
|
|
path string
|
|
expectedCode int
|
|
}{
|
|
{commonDS, logs.NewMock(), BaseRoute + "/notexist", http.StatusNotFound},
|
|
{commonDS, logs.NewMock(), BaseRoute + "/triggerid", http.StatusOK},
|
|
} {
|
|
rnr, cancel := testRunner(t)
|
|
defer cancel()
|
|
srv := testServer(test.mock, &mqs.Mock{}, test.logDB, rnr, ServerTypeFull)
|
|
router := srv.Router
|
|
|
|
_, rec := routerRequest(t, router, "GET", test.path, bytes.NewBuffer([]byte("")))
|
|
|
|
if rec.Code != test.expectedCode {
|
|
t.Errorf("Test %d: Expected status code to be %d but was %d",
|
|
i, test.expectedCode, rec.Code)
|
|
}
|
|
|
|
var triggerGet models.Trigger
|
|
err := json.NewDecoder(rec.Body).Decode(&triggerGet)
|
|
if err != nil {
|
|
t.Errorf("Test %d: Expected to decode json: %s", i, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestHTTPTriggerEndpointAnnotations(t *testing.T) {
|
|
|
|
a := &models.App{ID: "appid", Name: "myapp"}
|
|
fn := &models.Fn{ID: "fnid", AppID: a.ID}
|
|
fn.SetDefaults()
|
|
trig := &models.Trigger{Name: "thetrigger", FnID: fn.ID, AppID: a.ID, Type: "http", Source: "/myt"}
|
|
commonDS := datastore.NewMockInit([]*models.App{a}, []*models.Fn{fn})
|
|
triggerBody, err := json.Marshal(trig)
|
|
if err != nil {
|
|
t.Fatalf("Failed to marshal triggerbody: %s", err)
|
|
}
|
|
srv := testServer(commonDS, &mqs.Mock{}, logs.NewMock(), nil, ServerTypeAPI)
|
|
|
|
_, createTrigger := routerRequest(t, srv.Router, "POST", BaseRoute, bytes.NewReader(triggerBody))
|
|
|
|
if createTrigger.Code != http.StatusOK {
|
|
t.Fatalf("expected code %d != 200 %s", createTrigger.Code, createTrigger.Body.String())
|
|
}
|
|
|
|
var triggerCreate models.Trigger
|
|
err = json.NewDecoder(createTrigger.Body).Decode(&triggerCreate)
|
|
if err != nil {
|
|
t.Fatalf("Invalid json from server on trigger create: %s", err)
|
|
}
|
|
|
|
const triggerEndpoint = "fnproject.io/trigger/httpEndpoint"
|
|
v, err := triggerCreate.Annotations.GetString(triggerEndpoint)
|
|
if err != nil {
|
|
t.Fatalf("failed to get trigger %s", err)
|
|
}
|
|
if v != "http://127.0.0.1:8080/t/myapp/myt" {
|
|
t.Errorf("unexpected trigger val %s", v)
|
|
}
|
|
|
|
_, rec := routerRequest(t, srv.Router, "GET", "/v2/triggers/"+triggerCreate.ID, bytes.NewBuffer([]byte("")))
|
|
|
|
if rec.Code != http.StatusOK {
|
|
t.Fatalf("expected code %d != 200", rec.Code)
|
|
}
|
|
var triggerGet models.Trigger
|
|
err = json.NewDecoder(rec.Body).Decode(&triggerGet)
|
|
if err != nil {
|
|
t.Fatalf("Invalid json from server %s", err)
|
|
}
|
|
|
|
v, err = triggerGet.Annotations.GetString(triggerEndpoint)
|
|
if err != nil {
|
|
t.Fatalf("failed to get trigger %s", err)
|
|
}
|
|
if v != "http://127.0.0.1:8080/t/myapp/myt" {
|
|
t.Errorf("unexpected trigger val %s", v)
|
|
}
|
|
|
|
_, rec = routerRequest(t, srv.Router, "GET", "/v2/triggers?app_id=appid", bytes.NewBuffer([]byte("")))
|
|
|
|
if rec.Code != http.StatusOK {
|
|
t.Fatalf("expected code %d != 200", rec.Code)
|
|
}
|
|
var triggerList models.TriggerList
|
|
err = json.NewDecoder(rec.Body).Decode(&triggerList)
|
|
if err != nil {
|
|
t.Fatalf("Invalid json from server %s : %s", err, string(rec.Body.Bytes()))
|
|
}
|
|
|
|
if len(triggerList.Items) != 1 {
|
|
t.Fatalf("Unexpected trigger list result")
|
|
}
|
|
|
|
v, err = triggerList.Items[0].Annotations.GetString(triggerEndpoint)
|
|
if v != "http://127.0.0.1:8080/t/myapp/myt" {
|
|
t.Errorf("unexpected trigger val %s", v)
|
|
}
|
|
|
|
}
|
|
|
|
func TestTriggerUpdate(t *testing.T) {
|
|
buf := setLogBuffer()
|
|
defer func() {
|
|
if t.Failed() {
|
|
t.Log(buf.String())
|
|
}
|
|
}()
|
|
|
|
a := &models.App{ID: "appid"}
|
|
fn := &models.Fn{ID: "fnid"}
|
|
fn.SetDefaults()
|
|
|
|
trig := &models.Trigger{ID: "triggerid",
|
|
Name: "Name",
|
|
AppID: "appid",
|
|
FnID: "fnid",
|
|
Type: "http",
|
|
Source: "source"}
|
|
|
|
commonDS := datastore.NewMockInit([]*models.App{a}, []*models.Fn{fn}, []*models.Trigger{trig})
|
|
|
|
for i, test := range []struct {
|
|
mock models.Datastore
|
|
logDB models.LogStore
|
|
path string
|
|
body string
|
|
name string
|
|
expectedCode int
|
|
expectedError error
|
|
}{
|
|
{commonDS, logs.NewMock(), BaseRoute + "/notexist", `{"id": "triggerid", "name":"changed"}`, "", http.StatusBadRequest, nil},
|
|
{commonDS, logs.NewMock(), BaseRoute + "/notexist", `{"id": "notexist", "name":"changed"}`, "", http.StatusNotFound, nil},
|
|
{commonDS, logs.NewMock(), BaseRoute + "/triggerid", `{"id": "nonmatching", "name":"changed}`, "", http.StatusBadRequest, models.ErrTriggerIDMismatch},
|
|
{commonDS, logs.NewMock(), BaseRoute + "/triggerid", `{"id": "triggerid", "name":"changed"}`, "changed", http.StatusOK, nil},
|
|
{commonDS, logs.NewMock(), BaseRoute + "/triggerid", `{"name":"again"}`, "again", http.StatusOK, nil},
|
|
} {
|
|
rnr, cancel := testRunner(t)
|
|
defer cancel()
|
|
srv := testServer(test.mock, &mqs.Mock{}, test.logDB, rnr, ServerTypeFull)
|
|
router := srv.Router
|
|
|
|
body := bytes.NewBuffer([]byte(test.body))
|
|
_, rec := routerRequest(t, router, "PUT", test.path, body)
|
|
|
|
if rec.Code != test.expectedCode {
|
|
t.Errorf("Test %d: Expected status code to be %d but was %d",
|
|
i, test.expectedCode, rec.Code)
|
|
|
|
if test.expectedError != nil {
|
|
resp := getErrorResponse(t, rec)
|
|
if !strings.Contains(resp.Message, test.expectedError.Error()) {
|
|
t.Errorf("Test %d: Expected error message to have `%s` but got `%s`",
|
|
i, test.expectedError.Error(), resp.Message)
|
|
}
|
|
}
|
|
}
|
|
|
|
if rec.Code == http.StatusOK {
|
|
_, rec := routerRequest(t, router, "GET", BaseRoute+"/triggerid", bytes.NewBuffer([]byte("")))
|
|
|
|
var triggerGet models.Trigger
|
|
err := json.NewDecoder(rec.Body).Decode(&triggerGet)
|
|
if err != nil {
|
|
t.Errorf("Test %d: Expected to decode json: %s", i, err)
|
|
}
|
|
|
|
trig.Name = test.name
|
|
if !trig.EqualsWithAnnotationSubset(&triggerGet) {
|
|
t.Errorf("Test%d: trigger should be updated: %v : %v", i, trig, triggerGet)
|
|
}
|
|
}
|
|
}
|
|
}
|