Fix preference not taken into account for odo version (#6415)

* Quick fix

* Test grouping of comands in odo help

* Create a CommandGroup abstraction

* Expect a non-nil Preference Client

Co-authored-by: Armel Soro <armel@rm3l.org>

Co-authored-by: Armel Soro <armel@rm3l.org>

cmd/odo/help_test.go

@@ -0,0 +1,108 @@
+package main
+
+import (
+	"bytes"
+	"context"
+	"strings"
+	"testing"
+
+	"github.com/redhat-developer/odo/pkg/config"
+	envcontext "github.com/redhat-developer/odo/pkg/config/context"
+	"github.com/redhat-developer/odo/pkg/odo/cli"
+	"k8s.io/klog"
+)
+
+var (
+	intro = `Usage:
+  odo [flags]
+  odo [command]
+
+Examples:
+  Initializing your component by taking your pick from multiple languages or frameworks:
+  odo init
+  
+  After creating your initial component, start development with:
+  odo dev
+  
+  Want to deploy after development? See it live with:
+  odo deploy`
+
+	mainCommands = `Main Commands:
+  build-images Build images
+  deploy       Deploy components
+  dev          Deploy component to development cluster
+  init         Init bootstraps a new project
+  logs         Show logs of all containers of the component
+  registry     List all components from the Devfile registry
+
+`
+
+	managementCommands = `Management Commands:
+  add          Add resources to devfile (binding)
+  create       Perform create operation (namespace)
+  delete       Delete resources (component, namespace)
+  describe     Describe resource (binding, component)
+  list         List all components in the current namespace (binding, component, namespace, services)
+  remove       Remove resources from devfile (binding)
+  set          Perform set operation (namespace)
+
+`
+
+	openshiftCommands = `OpenShift Commands:
+  login        Login to cluster 
+  logout       Logout of the cluster`
+
+	utilityCommands = `Utility Commands:
+  analyze      Detect devfile to use based on files present in current directory
+  completion   Add odo completion support to your development environment
+  preference   Modifies preference settings (add, remove, set, unset, view)
+  version      Print the client version information
+
+`
+)
+
+func TestOdoHelp(t *testing.T) {
+	ctx := context.Background()
+	envConfig, err := config.GetConfiguration()
+	if err != nil {
+		t.Fatal(err)
+	}
+	ctx = envcontext.WithEnvConfig(ctx, *envConfig)
+	klog.InitFlags(nil)
+
+	root := cli.NewCmdOdo(ctx, cli.OdoRecommendedName, cli.OdoRecommendedName)
+
+	var stdoutB, stderrB bytes.Buffer
+	root.SetOut(&stdoutB)
+	root.SetErr(&stderrB)
+
+	root.SetArgs([]string{"help"})
+
+	err = root.ExecuteContext(ctx)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	stdout := stdoutB.String()
+	stderr := stderrB.String()
+
+	if stderr != "" {
+		t.Fatal("stderr should be empty")
+	}
+
+	if !strings.Contains(stdout, intro) {
+		t.Fatalf("stdout should contain \n%s\nbut is\n%s\n", intro, stdout)
+	}
+	if !strings.Contains(stdout, mainCommands) {
+		t.Fatalf("stdout should contain \n%s\nbut is\n%s\n", mainCommands, stdout)
+	}
+	if !strings.Contains(stdout, managementCommands) {
+		t.Fatalf("stdout should contain \n%s\nbut is\n%s\n", managementCommands, stdout)
+	}
+	if !strings.Contains(stdout, openshiftCommands) {
+		t.Fatalf("stdout should contain \n%s\nbut is\n%s\n", openshiftCommands, stdout)
+	}
+	if !strings.Contains(stdout, utilityCommands) {
+		t.Fatalf("stdout should contain \n%s\nbut is\n%s\n", utilityCommands, stdout)
+	}
+}