Remove kubeconfig flag (#7017)

* Remove kubeconfig flag

* Do not check file exists from KUBECONFIG, as KUBECONFIG can be a list of files and this is done by clientcmd library

* Fix odo --help

* Add integration test to check flag is not supported
This commit is contained in:
Philippe Martin
2023-08-04 11:52:19 +02:00
committed by GitHub
parent 1c6767ee37
commit 7c976f1bf1
3 changed files with 11 additions and 15 deletions

View File

@@ -2,7 +2,6 @@ package list
import (
"context"
"errors"
"fmt"
"github.com/spf13/cobra"
@@ -24,8 +23,6 @@ import (
"github.com/redhat-developer/odo/pkg/odo/util"
odoutil "github.com/redhat-developer/odo/pkg/odo/util"
dfutil "github.com/devfile/library/v2/pkg/util"
ktemplates "k8s.io/kubectl/pkg/util/templates"
)
@@ -62,15 +59,6 @@ func (o *ListOptions) SetClientset(clientset *clientset.Clientset) {
// Complete ...
func (lo *ListOptions) Complete(ctx context.Context, cmdline cmdline.Cmdline, args []string) (err error) {
// Check to see if KUBECONFIG exists, and if not, error the user that we would not be able to get cluster information
// Do this before anything else, or else we will just error out with the:
// invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
// instead
if !dfutil.CheckKubeConfigExist() {
return errors.New("KUBECONFIG not found. Unable to retrieve cluster information. Please set your Kubernetes configuration via KUBECONFIG env variable or ~/.kube/config")
}
// If the namespace flag has been passed, we will search there.
// if it hasn't, we will search from the default project / namespace.
if lo.namespaceFlag != "" {