Stop testing binding-related code since the Service Binding Operator has been deprecated [1]

Also add warning notes to the corresponding command reference pages.

This section used to cause a bunch of flaky tests,
even if it hasn't seen any changes over the past months/years.

[1] https://redhat-developer.github.io/service-binding-operator/userguide/intro.html
This commit is contained in:
Armel Soro
2024-07-18 00:08:12 +02:00
parent 817faa69fd
commit fc2ffce43a
8 changed files with 43 additions and 4 deletions

View File

@@ -124,7 +124,9 @@ jobs:
fail-fast: false fail-fast: false
matrix: matrix:
k8s_version: [v1.28.0, v1.27.3, v1.26.6] k8s_version: [v1.28.0, v1.27.3, v1.26.6]
service_binding: ["false", "true"] service_binding:
- "false"
# - "true" # Service Binding Operator deprecated as of Feb 2024
name: "K8s Tests (${{ matrix.k8s_version }}/ServiceBinding=${{ matrix.service_binding }})" name: "K8s Tests (${{ matrix.k8s_version }}/ServiceBinding=${{ matrix.service_binding }})"
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: build_odo needs: build_odo

View File

@@ -225,6 +225,14 @@ test-integration-cluster-no-service-binding:
test-integration-cluster-service-binding: test-integration-cluster-service-binding:
$(RUN_GINKGO) $(GINKGO_FLAGS) --junit-report="test-integration.xml" --label-filter="servicebinding" tests/integration $(RUN_GINKGO) $(GINKGO_FLAGS) --junit-report="test-integration.xml" --label-filter="servicebinding" tests/integration
.PHONY: test-integration-openshift-no-service-binding
test-integration-openshift-no-service-binding:
$(RUN_GINKGO) $(GINKGO_FLAGS) --junit-report="test-integration.xml" --label-filter="!unauth && !nocluster && !podman && !servicebinding && !skiponopenshift" tests/integration
.PHONY: test-integration-openshift-service-binding
test-integration-openshift-service-binding:
$(RUN_GINKGO) $(GINKGO_FLAGS) --junit-report="test-integration.xml" --label-filter="!unauth && !nocluster && !podman && servicebinding && !skiponopenshift" tests/integration
.PHONY: test-integration-openshift-unauth .PHONY: test-integration-openshift-unauth
test-integration-openshift-unauth: test-integration-openshift-unauth:
$(RUN_GINKGO) $(GINKGO_FLAGS) --junit-report="test-integration-unauth.xml" --label-filter="unauth" tests/integration $(RUN_GINKGO) $(GINKGO_FLAGS) --junit-report="test-integration-unauth.xml" --label-filter="unauth" tests/integration

View File

@@ -2,6 +2,13 @@
title: odo add binding title: odo add binding
--- ---
:::warning
As of February 2024, the [Service Binding Operator](https://github.com/redhat-developer/service-binding-operator/), which this command relies on, has been deprecated. See [Deprecation Notice](https://redhat-developer.github.io/service-binding-operator/userguide/intro.html).
`odo add binding` may therefore not work as expected.
:::
The `odo add binding` command adds a link between an Operator-backed service and a component. odo uses the [Service Binding Operator](https://github.com/redhat-developer/service-binding-operator/) to create this link. The `odo add binding` command adds a link between an Operator-backed service and a component. odo uses the [Service Binding Operator](https://github.com/redhat-developer/service-binding-operator/) to create this link.
Running this command from a directory containing a Devfile will modify the Devfile, and once pushed (using `odo dev`) to the cluster, it creates an instance of the `ServiceBinding` resource. Running this command from a directory containing a Devfile will modify the Devfile, and once pushed (using `odo dev`) to the cluster, it creates an instance of the `ServiceBinding` resource.

View File

@@ -2,6 +2,13 @@
title: odo describe binding title: odo describe binding
--- ---
:::warning
As of February 2024, the [Service Binding Operator](https://github.com/redhat-developer/service-binding-operator/), which this command relies on, has been deprecated. See [Deprecation Notice](https://redhat-developer.github.io/service-binding-operator/userguide/intro.html).
`odo describe binding` may therefore not work as expected.
:::
`odo describe binding` command is useful for getting information about service bindings. `odo describe binding` command is useful for getting information about service bindings.
This command supports the service bindings added with the command `odo add binding` and bindings added manually to the Devfile, using a `ServiceBinding` resource from one of these apiVersion: This command supports the service bindings added with the command `odo add binding` and bindings added manually to the Devfile, using a `ServiceBinding` resource from one of these apiVersion:

View File

@@ -2,6 +2,12 @@
title: odo list binding title: odo list binding
--- ---
:::warning
As of February 2024, the [Service Binding Operator](https://github.com/redhat-developer/service-binding-operator/), which this command relies on, has been deprecated. See [Deprecation Notice](https://redhat-developer.github.io/service-binding-operator/userguide/intro.html).
`odo list binding` may therefore not work as expected.
:::
You can use `odo list binding` to list all the Service Bindings declared in the current namespace and, if present, You can use `odo list binding` to list all the Service Bindings declared in the current namespace and, if present,
in the Devfile of the current directory. in the Devfile of the current directory.

View File

@@ -2,7 +2,7 @@
title: odo list title: odo list
--- ---
`odo list` command combines the `odo list binding` and `odo list component` commands. `odo list` command combines the [`odo list binding`](./list-binding.md) and [`odo list component`](./list-component.md) commands.
## Running the command ## Running the command

View File

@@ -2,6 +2,13 @@
title: odo remove binding title: odo remove binding
--- ---
:::warning
As of February 2024, the [Service Binding Operator](https://github.com/redhat-developer/service-binding-operator/), which this command relies on, has been deprecated. See [Deprecation Notice](https://redhat-developer.github.io/service-binding-operator/userguide/intro.html).
`odo remove binding` may therefore not work as expected.
:::
## Description ## Description
The `odo remove binding` command removes the link created between the component and a service via Service Binding. The `odo remove binding` command removes the link created between the component and a service via Service Binding.

View File

@@ -37,14 +37,16 @@ oc whoami
source ./scripts/openshiftci-config.sh source ./scripts/openshiftci-config.sh
# Integration tests # Integration tests
make test-integration-openshift || error=true # Service Binding Operator deprecated as of Feb 2024
make test-integration-openshift-no-service-binding || error=true
# Login again (in case the token expires for some reason) # Login again (in case the token expires for some reason)
oc login -u developer -p password@123 --insecure-skip-tls-verify || true oc login -u developer -p password@123 --insecure-skip-tls-verify || true
oc whoami oc whoami
# E2e tests # E2e tests
make test-e2e || error=true # Service Binding Operator deprecated as of Feb 2024
make test-e2e-no-service-binding || error=true
# Fail the build if there is any error while test execution # Fail the build if there is any error while test execution
if [ $error ]; then if [ $error ]; then