* Update 'go.mod' with new location of the Alizer library
* Downgrade and pin conflicting versions of 'github.com/docker/{cli,distributions}'
Pinning it to the version we had before.
Otherwise, there were issues when running 'go mod tidy':
```
$ go mod tidy
go: downloading github.com/operator-framework/api v0.17.6
go: finding module for package github.com/docker/docker/pkg/term
github.com/redhat-developer/odo/pkg/auth imports
github.com/openshift/oc/pkg/cli/login imports
github.com/openshift/oc/pkg/helpers/term imports
github.com/docker/docker/pkg/term: module
github.com/docker/docker@latest found
(v24.0.4+incompatible), but does not contain
package github.com/docker/docker/pkg/term
```
* Fix expected output in quickstart guides doc automation tests
* Bump Alizer to the latest commit at this time [1]
Amongst other things, this fixes an issue when analyzing large projects,
by preventing potential panics when trying to detect application ports.
[1] 14114f066c
* Downgrade and pin the versions of 'sigs.k8s.io/controller-runtime' and 'k8s.io/*' to the previous versions we had
Bumping Alizer bumped these packages to upper versions,
which seems to cause build errors due to Service Binding Operator
libraries not compatible with those new versions.
See the error below.
Since we don't want to update SBO libraries at this time
(as SBO is currently in maintenance mode only),
this makes sure we are using the versions it builds against.
Build error for reference:
```
go install -mod=vendor -ldflags="-X github.com/redhat-developer/odo/pkg/version.GITCOMMIT=cb9c13900" ./cmd/odo/
# github.com/redhat-developer/service-binding-operator/apis/spec/v1alpha3
vendor/github.com/redhat-developer/service-binding-operator/apis/spec/v1alpha3/servicebinding_webhook.go:44:27: cannot use &ServiceBinding{} (value of type *ServiceBinding) as type admission.Validator in variable declaration:
*ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method)
have ValidateCreate() error
want ValidateCreate() (warnings admission.Warnings, err error)
# github.com/redhat-developer/service-binding-operator/apis/binding/v1alpha1
vendor/github.com/redhat-developer/service-binding-operator/apis/binding/v1alpha1/servicebinding_webhook.go:37:27: cannot use &ServiceBinding{} (value of type *ServiceBinding) as type admission.Validator in variable declaration:
*ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method)
have ValidateCreate() error
want ValidateCreate() (warnings admission.Warnings, err error)
make: *** [Makefile:90: install] Error 2
```
* Fix expected output in doc automation tests
* update alizer to ad2d305
* go mod vendor
* add wwhrd exceptions for github.com/pjbgf/sha1cd/
* update go-git to v5.6.1
* go mod vendor
* fixup! go mod vendor
---------
Co-authored-by: Armel Soro <asoro@redhat.com>
* Update odo to use go 1.18
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
* Update golangci-lint version in Makefile
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
* Use go 1.18, not go 1.19
Erroneously I had used go 1.19 at various places.
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
* Rearrange imports; fix golangci-lint errors
Fixed a bunch of golangci-lint errors like below:
`File is not `gofmt`-ed with `-s``
using the command: `golangci-lint run --fix`
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
* Use go install instead of go get
This is because with go 1.18, `go get` behaves as `go get -d` by
default. Which means that it will only download, but not install.
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
* update go version to 1.17
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
* update go version to 1.17 and fix failure
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
* Skeleton for odo dev and a unit test
* Update go mod for fsnotify
* Start method Pushes and then Watches
* More understandable code comments
* Client and interface for watch package
* Mocks for watch package
* Add CLI layer
* Fix infinite watch & push trigger
* Remove context flag from odo dev
* Add integration tests for odo dev
* Add klog to dev.go
* Replace errors.Wrap with fmt.Errorf
* Self review
* Removes `odo watch` command, but the business logic exists as it's
used by odo dev
* Removes integration tests for `odo watch`
* Removes errors.go and types.go from pkg/dev/ since they are empty
* Check if error is not nil
* Use real client in watch unit tests
* Uncomment AfterEach from tests
* Modify the logs printed to stdout
* Changes based on Philippe's review
* Remove unused clients
* Parthvi's PR review and unit test fixes
* Fix gofmt message, remove message to not expect
* Fix lint complains, add mistakenly deleted URL creation logic
* Remove or modify tests that rely on odo push output
* Remove unused variables based on golangci-lint
* Fixes based on Philippe's review
* Initialize first index after first run of odo dev
* Modify odo dev test, and uncomment a mistake
* Add alizer library and test functionality
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:
1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review
Documentation:
If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->
**What type of PR is this:**
<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation
Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind feature
**What does this PR do / why we need it:**
Adds the alizer library from
https://github.com/redhat-developer/alizer/tree/main/go as part of our
implementaion of `odo dev` and `odo init`.
This builds upon @feloy 's PR located here: https://github.com/redhat-developer/odo/pull/5434
**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->
Fixes #
**PR acceptance criteria:**
- [X] Unit test
- [X] Integration test
- [X] Documentation
**How to test changes / Special notes to the reviewer:**
N/A. Only function implementation
* New alizer version
* Use alizer for odo init
* Add integration tests
* Add Alizer to odo deploy
* review
* Ask component name for odo deploy
* Fix unit test
Co-authored-by: Charlie Drage <charlie@charliedrage.com>
* Fetch locale information for Telemetry
* Set locale info in traits
* Continue execution if locale detection fails
* Update pkg/segment/segment.go
Co-authored-by: Philippe Martin <contact@elol.fr>
* Update pkg/segment/segment.go
Co-authored-by: Philippe Martin <contact@elol.fr>
* Use %s instead of %w for logging error
Co-authored-by: Philippe Martin <contact@elol.fr>
* export GOFLAGS=-mod=vendor in Makefile
* use go get instead of go install
for installing test dependencies
* use tools approach to manage testing dependencies
When using this apporoach we can make sure that all dependencies in a
proper version are vendored with the source code.
* go mod vendor
* add wwhrd expection for github.com/hinshun/vt10x
* update to openshift 4.7 and sbo 0.7.0
* use server side apply for updating deployments
* go mod vendor
* use ApplyDeployment instad Patch and Create
* fix login message
* update unit tests to work with ApplyDeployment function
* fall back to Create/Update for k8s older than 1.16
* abstract fieldManager into const
* fix operator-framework imports
* feat: OCI-based registry support
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* refactor: download the whole stack by default
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* fix: invalid folder issue
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* fix: address comments
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* fix: test case and auto migration
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* fix: code issue detected by unit test
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* test: fix unit test
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* Merge branch 'master' of github.com:openshift/odo into odoMigration
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* refactor: adopt the latest devfile library
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* test: fix unit tests
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* test: fix unit tests
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* Merge branch 'master' of github.com:openshift/odo into odoMigration
Signed-off-by: jingfu wang <jingfwan@redhat.com>
* Update go-git
* Add support for specifying branch and tag name
* Fix gosec error
Fix Integration test
* Added warning if commit id is used as revision
Added Integration tests
* fix devfile
* Fix failing test update tag version
* Address review comment 1
* implement new project and starterProject git spec
* fix starter project overriding devfile
- The devfile is first downloaded and parsed in memory
- Starter project is donwloaded into the current directory
- Devfile is saved to the current directory
* perms 0644 for devfile is ok - nosec G306
* fix: not able to create component from local devfile
* fix: allow use of existing devfile
* fix: odo create in a directory with existing devfile
* fix: spinner not ended properly
* create and use ParseFromDataAndValidate
* show warning when someone uses revision
* remove events from parent
Events were removed from parent in Devfile spec.
* remove no longer used variable defaultGithubRef
* update unsuported devfile version message
* go mod tidy
* update vendor (go mod vendor)
* fix tests devfile
* temporary change registry in devfile test spec
* fix: add yaml tags to project git source
* fix: wrongly formated starter project in test devfile
* fix: integration tests
* update registry locations
* delete 2.0.0 types that are no longer used
* remove unused OverideEvents function
* fix: revision warning
* fix: typos
* fix: update GetDefaultSource unit tests
* roll back changes in default devfile registry
* switch to go modules
* update vendor (go mod vendor)
* swithing to go mod: update docs and makefile
* update goget-tools
* use go mod verify to check vendor
* Update goget-tools
- pin goget-tools versions
- update gikgo to 1.14.0
- reset GOFLAGS for goget-tools
- fix ginkgo get for Prow
* go mod: replace github.com/kr/pty with github.com/creack/pty
* update vendor (go mod vendor)
* fix make cross target
-mod=vendor was not used for corss compiling
This commit adds github.com/kubernetes-incubator/service-catalog,
version: v0.1.9 and github.com/satori/go.uuid, version: v1.1.0 (
which is required by service-catalog) to the vendor directory.
The standard procedure of adding the dependencies to glide.yaml
and then running `glide update --strip-vendor` was followed.
