* Removing cli layer and integration tests related to service catalog
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing missing error msg
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing golint errors
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing error for interactive mode
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Moving interactive mode error to top
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing interactive mode error condition
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing some more service related code
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing golint
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing service catalog backend part 1
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating changelogs
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing some more of the service catalog related code
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating as per comments in review
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Update pkg/odo/cli/service/create.go
Co-authored-by: Parthvi Vala <pvala@redhat.com>
* Fixing gofmt
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Adding kube to cli docs
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating changelog as per comments by @dharmit
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing some unnessasary stuff
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating docs based changes as per review
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing test
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Update pkg/odo/cli/catalog/describe/service.go
Co-authored-by: Philippe Martin <contact@elol.fr>
* Update pkg/odo/cli/service/list.go
Co-authored-by: Philippe Martin <contact@elol.fr>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Philippe Martin <contact@elol.fr>
* Do not deploy sbr at `odo link` time, save it in devfile
* Changelog
* Fix remove duplicates
* Do not set owner references again
* Fix wait for pod terminating
* Simplify env vars deduplication
* Add comment
* Dont use oc
* link type
* fix
* Fix spinner
* Fix tests
* Fic error message for link/unlink
* Review
* No spinner
* export GOFLAGS=-mod=vendor in Makefile
* use go get instead of go install
for installing test dependencies
* use tools approach to manage testing dependencies
When using this apporoach we can make sure that all dependencies in a
proper version are vendored with the source code.
* go mod vendor
* add wwhrd expection for github.com/hinshun/vt10x
* implement devfile conversion ( with --now support) on --s2i without --git flag
* fix unit tests
* resolve failing tests
* small fix
* more test fixes
* more failing tests
* fix multiple tests
* forgot to push
* fix debug port error
* fix failures
* resolve no ports error
* more test fixes
* fixing more failures in tests
* fix more tests
* small fix
* changes
* update more tests
* fix more tests
* more tests
* fix more tests
* more test resolved
* add comment on test
* remove and updated tests
* fixed more tests
* removed FIt
* Removed FIt
* fix tests
* fix unit test
* fix more tests
* more tests fixed
* fix some e2e tests
* commented some tests
* add images back
* change --git links
* more images
* comment
* fix comments
* fix e2e images test
* address tests
* add requested test and helpers
* more cleanup
* remove dependence on kubectl
* use different port
Co-authored-by: Tomas Kral <tkral@redhat.com>
* Updating segment varialbe= dev key as default overrideable with ldflags
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Changing const to var
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* #3377 adding odo devfile support test
* #3377 replaced spaces with a Tab
* #3377 updated focus value
* #3377 addressed all Priti's comments in PR
* #3377 addressed additional comments from Priti's comments in PR
* #3377 adding make test-e2e-devfile
* Status support: Event notification support for build and application status for IDE integration for devfile scenarios
* Status support: Event notification support for build and application status for IDE integration for devfile scenarios
* Status support: Event notification support for build and application status for IDE integration for devfile scenarios
* Status support: Event notification support for build and application status for IDE integration for devfile scenarios
* Status support: Event notification support for build and application status for IDE integration for devfile scenarios
* Status support: Event notification support for build and application status for IDE integration for devfile scenarios
* Status support: Event notification support for build and application status for IDE integration for devfile scenarios
* Rebase
* Rebase
* Respond to review comments
* Make gofmt happy
* Add podwatcher unit tests
* Fix go vet
* Fix linter issues
* Rebase
* Fix unit test
* Fix unit test
* Fix unit test
* Respond to review comments
* Make linter happy
* Rebase
* Use latest URL APIs
* Response to API changes
* Fix rebase artifacts
* Fix rebase artifacts
* Respond to API changes
* Remove experimental flag
* Rebase to latest
* Adds app commands for devfile components
* Fixes log messages and comments
* Fixes s2i app test script
* Fixes s2i local config components
* Removes devfile test for help
* Adds unit test cases for List()
* Updates integration tests
* Fixed alias in import
* feat: add GetName and GetNamespace methods to LocalConfigProvider
* refactor: remove redundant resolveProject
This is accomplished by making resolveNamespace take a
LocalConfigProvider instance instead of LocalConfigInfo.
Also record the project/namespace when creating a devfile context.
* refactor: rename and improve resolveComponent, set component on devfile
Renamed to resolveAndSetComponent making it an internalContext method,
taking a LocalConfigProvider instead of LocalConfigInfo. Also now set
the resolved component on the receiver context.
* fix: make describe Complete work with devfiles, simplify
* refactor: make LocalConfigInfo.GetURL return EnvInfoURL
* fix: typo
* feat: add GetDebugPort and GetURL to LocalConfigProvider
* refactor: rename ConfigFileExists & EnvInfoFileExists to Exists
* feat: add Exists method to LocalConfigProvider
* feat: add GetEnv method to LocalConfigProvider & implementations
* fix: revert adding GetEnv because it introduces import cycle
It's impossible to parse a devfile within the envinfo package because
the parser package now depends on the config package which I think it
shouldn't depend on. :(
* feat: first implementation supporting describe for devfiles
* fix: error format
* fix: break from loop as soon as project is found
* fix: properly set namespace of clients
* fix: handle error
* refactor: use map, initialized only once and not per call
* fix: use oc client if k8s client failed
* fix: typos
* fix: allow creating components with invalid namespaces
Not sure why this should be working but that's what the tests say…
* fix: revert resolveProject function
Seems like having a single function to resolve the namespace should be
enough but it gets too complicated too quickly and cleaning up this
mess is not the goal of this PR anyway… :sad:
* fix: properly set project on context
* fix: properly retrieve the state based on deployment availability
* fix: check DC if deployment doesn't exist :(
* fix: no need to return a pointer
* fix: change type to `devile: <component name>`
* feat: export GetLocalDevfileStorage to be able to reuse it
* feat: add URL and storage output to describe for devfiles
* fix: typos
* chore: add integration test
* feat: always set discovery client on fakeclient
* feat: cache result of isResourceSupported
* feat: make it possible to create a client from an existing config
* refactor: simplify validateSourceType
* feat: make ListIngressAndRoute work with an optional LocalConfigProvider
* feat: abstract the cluster representation of the component
* fix: only use devfile name
* fix: sort URLs by name to have consistent output
* fix: use action's name to return proper DC instead of relying on count
* feat: make describe integration test plain k8s only, add pushed test
* fix: use PushedComponent to make describe work on k8s and when pushed
* feat: add make target for devfile describe integration tests
* fix: return an error instead of panicking
* feat: add GetComponentNames to avoid building full components and use it
* fix: utility packages shouldn't depend on cli packages
* feat: make occlient link to kclient to be able to use it when needed
* feat: make PushedComponent return URLs as well
* fix: getRemoteComponentMetadate now retrieves URLs from PushedComponent
* fix: typo
* fix: only retrieve routes if they are supported
* fix: no need to keep pointer to Deployment/DeploymentConfig
* fix: removed unused code
* fix: removed unused code
* fix: stupid mistake
* chore: add doc
[skip ci]
* chore: add doc
[skip ci]
* fix: deal with URLs uniformly between s2i and devfile
* fix: URLs are routes unless otherwise specified
* fix: do not set path by default
* fix: sort component names
* test: check to see if that makes test work better that way…
* TMP: panic on unknown GetPushedComponent error to get a stack
* fix: allow unauthorized and forbidden errors to fall back to DC check
* fix: ignore some errors when trying to get URLs or PushedComponents
* fix: lazy init URLs so that they're only retrieved when needed
* refactor: simplify ListIngressAndRoute signature
* fix: also check cause in case the error is wrapped
* switch to go modules
* update vendor (go mod vendor)
* swithing to go mod: update docs and makefile
* update goget-tools
* use go mod verify to check vendor
* Update goget-tools
- pin goget-tools versions
- update gikgo to 1.14.0
- reset GOFLAGS for goget-tools
- fix ginkgo get for Prow
* go mod: replace github.com/kr/pty with github.com/creack/pty
* update vendor (go mod vendor)
* fix make cross target
-mod=vendor was not used for corss compiling
* Run missing debug command against 4.x cluster
* Updated travis file with respect to the changes
* Fixing job timeout
* Updated test target
* Updated test timeout
* Updated review comment
* clean up
* clean up
* CI time balancing
* CI time balancing and cleanup
* add feature complete odo set and unset
* added json output
* added json output for odo config
* resolved golint
* addressed some comments
* separated out devfile and s2i run sections
* Add example and descriptions
* some spacing
* added integration tests
* only odo injected ports can be managed
* typo resolved and DRYed the config tests
* updated desc and use dns friendly component name
* add devfile config tests to travis
* resolved the panic
* format the help for all config flows
* now a user can remove all ports
* resolved failing tests
* added the format test back
* not pushing in intg test
* added unit tests for devfile config
* unique portname for different protocol
* removed a comment
* Adds storage create and delete commands for devfiles.
* Uses a existing error type and creates a new NotFoundError type
* fixes order of errors while creating volumes
* adds json output for storage delete and adds tests
* fixes capitalization of error messages and comments and uses constants in the code
* Adds support for context flag
* Fixes unit test for devfile writer and updates yaml tags for devfile endpoint fields
* Adds context flag in s2i test
* Adds exec command for devfile components with kube push target
* Adds comments
* Modifies tests to run on kubernetes clusters
* Modifies exec logic to use GetPodUsingComponentName()
* Fixes context directory detection, adds comments and fixes the example
* Updates names of the Travis tests
* Implement odo log for devfile
implement odo log for k8s for run command
Fix color unset for follow
Make common function to display log
* Implemented for docker
* Add debug flag for odo log
Add Integrations test for odo log
* Add Docker Integration tests
* Fix unit test for odo log
* Implemented odo logs for debug
* Rebase and address some review comment
* Address some more review comments
* Address some more review comments
* Update odo log debug test
Add log tests in travis
* Adds debug command for devfiles
* Fixes comments and variable names
* Adds devfile debug test on kubernetes cluster
* Fixes adapter code for debug
Signed-off-by: mik-dass <mrinald7@gmail.com>
* Converts v1 debug test devfile to v2
* Moves container arg and command overriding to a new function
* Simplifies conditions in test
* Modifies execDevfile for kubernetes component adapter
* Simplies error checking logic in TestUpdateContainersWithSupervisord
* Removes unnecessary else if conditions
* Installs socat before running tests on kubernetes cluster
* save non default devfile cmd in env.yaml for push and watch
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* Add and update tests for envinfo
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* Update watch test to incl new watch param
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* watch integration test
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* Display msg when devfile commands are changed via odo push
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* Change Logic for watch flag + feedback 1
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* Update Watch tests with feedback
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* disable watch test on kube since we now use oc
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* Watch test feedback 2
Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com>
* Modify operator hub tests to run in separate namespaces
**What type of PR is this?**
/kind cleanup
/kind failing-test
**What does does this PR do / why we need it**:
This PR ensures that each test spec for operator hub is run in a
separate namespace. This is needed because these tests were written in a
stringent fashion which tied the hands while writing additional tests
for the feature.
This PR should help take the tests out of the "odo test statistics"
dashboard.
**Which issue(s) this PR fixes**:
Fixes#3193
**How to test changes / Special notes to the reviewer**:
CI should pass. Specially for Operator Hub tests under
`tests/integration/operatorhub`
* Changes as per PR review
* Remove createEtcdClusterService function and more separate specs
- Removed the function because it *seemed* to be leading to race
conditions
- Separating specs for the same reason
* Loop for two operators
* Make operator hub tests sequential
We're doing this because parallel run is causing numerous failures in CI
and local. In spite of debugging it for some time, we're not able to fix
it. However, we're on a deadline because operator hub failures are
showing up across the PRs. Hence, for time being, we're making these
tests sequential.
https://github.com/openshift/odo/issues/3244
* clean git history
* fix the bug that hostconfig got overwritten
* fix devfile url test
* Add ports to container
Signed-off-by: John Collier <John.J.Collier@ibm.com>
* fix the bug of container won't restart
* fix ineffectual variable assignments
Co-authored-by: John Collier <John.J.Collier@ibm.com>
* Add docker delete support
* On container delete, add deletion of projects volume
* Delete volumes only after deleting containers
* Update delete volume tests based on review comments
* Update delete volume tests based on review comments
* Rebase with latest from master
* Rebase with latest from master
* Rebase and update dependencies
* Rebase and update dependencies
* Adds delete function for devfiles support.
This PR also adds support for all flag. The all flag deletes the env folder present in the .odo folder.
Signed-off-by: mik-dass <mrinald7@gmail.com>
* Adds integration test for devfile delete
* able to create env folder and file
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* WIP-migrated from poc branch, still need to fix context
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* wip-fix some issues blocking normal odo url create
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* small modification on deleteURL, currently blocked by service
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* able to create service using first container port
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* move serviceSpec creation to generator.go
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* add service test
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* sanitize the port name
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* add secret and port check
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* add unit tests for added functions
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* add make
* able to delete url from env.yaml
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* raname tls-secret and host, make url delete works
* add intergation test for url. still need to work on intergation tests
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* finish integration tests
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* format secrets_test
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* fix unit test
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* fix unittest failure
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* fix indentation
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* update the code based on comments
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* fix build failure
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* fix failure
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* avoid calling list multiple times
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* modify based on comments
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* fix test failure
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* make now flag work
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* try to fix flaky tests
* use existing function to wait for output
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* try to fix namespace mismatch
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
* use project flag instead of namespace flag dor creation
* remove CreateNewDevfileContext since we get the cmpname from env.yaml now
* fix undefined failure
