* Add dependency on operator-lifecycle-manager (release-4.1)
* Add Operator Hub client to kclient package
* Add function to list installed operators
To be more specific, it lists the `ClusterServiceVersions` in the
cluster. But a `ClusterServiceVersion` is available only when
Operator(s) is/are installed by the cluster admin.
* List the CSVs in the cluster using odo commands
* Add dependency on github.com/golang/groupcache
* Removes futile call to get services from catalog
We're already getting services from the catalog in `Complete` function
and storing it in `o.services`.
* List the Operators only if experimental mode is enabled
* Update CI cluster setup script to setup operators
* Add OperatorHub tests to test-cmd-service
* Integration tests for listing operators
* Remove specific CSV version to let it be automatically selected
* Add test suite for OperatorHub tests to run
* Separate PHONY for OperatorHub tests and run it on 4.x cluster
* Use a CRD's kind instead of DisplayName to make service creation simpler in future
* Set environment variable for experimental mode
* Modify cluster setup to install operators on 4.1
* Execute different steps to setup OperatorHub if running on OCP 4.1
* Fix operator setup script for OCP 4.x
* Changes as per the PR review
https://github.com/openshift/odo/pull/2593#pullrequestreview-363449893
* Added klog dependency through `glide update -v`
* Changes as per the PR review
https://github.com/openshift/odo/pull/2593#pullrequestreview-372480988https://github.com/openshift/odo/pull/2593#pullrequestreview-372484636
* run validate with unit tests on OpenShift CI
* goget-tools before validate
* tests on prow: add GOPATH/bin to PATH
* make golangci-lint part of 'make validate' target
* fix golangci-lint download
* set GOLANGCI_LINT_CACHE on OpenShiftCI
* Update openshiftci-presubmit-unittests.sh
* E2E test for every supported images
* Rebase pr
* Added docker hub supported images
* Verify odo commands flow for supported images
* Fixing golint error
* check for registry.redhat.io
* checking particular test
* modified e2e test for supported images
* Waiting for https://github.com/openshift/release/pull/6341 odo-secret to be volume mounted
* Updating review comments
* Modified the file content according to review change request
* PR rebase
**What kind of PR is this?**
<!--
DELETE the kind(s) which are not applicable before opening the PR.
-->
/kind enhancement
**What does does this PR do / why we need it**:
Adds a small script to check for instances of `FIt(` being in the code.
This helps with regards to not merging in tests with FIt in integration.
**Which issue(s) this PR fixes**:
N/A
**How to test changes / Special notes to the reviewer**:
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* What kind of PR is this?
/kind cleanup
What does does this PR do / why we need it:
It adds golangci-lint as a travis job
It also adds the golangci-lint as make target.
It also fixes the current lint errors in our code base.
Which issue(s) this PR fixes:
Fixes#1927
How to test changes / Special notes to the reviewer:
run `golangci-lint run` and check that no errors occur
Signed-off-by: mik-dass <mrinald7@gmail.com>
* Fixes watch test by adding timeout
* Separating out link tests from service catalog dependent tests
* Updated the change requested by @amitkrout
* Changed the naming format of the function setup and removeSetup requested by @amitkrout
This PR:
- Moves versioning information to `pkg/version/version.go` so other
parts of odo is able to use the versioning information (namely
`pkg/component/labels/labels.go`.
- Updates documentation on the versioning move
- Adds `app.kubernetes.io/managed-by-version` label
- Adds `app.kubernetes.io/managed-by` label
See example below of the changes:
```yaml
apiVersion: apps.openshift.io/v1
kind: DeploymentConfig
metadata:
annotations:
app.kubernetes.io/component-source-type: local
app.openshift.io/vcs-uri: file://./
creationTimestamp: 2019-10-10T21:15:55Z
generation: 2
labels:
app: app
app.kubernetes.io/instance: foobar
app.kubernetes.io/managed-by: odo
app.kubernetes.io/managed-by-version: v1.0.0-beta6
app.kubernetes.io/name: nodejs
app.kubernetes.io/part-of: app
app.openshift.io/runtime-version: latest
name: foobar-app
namespace: foo
resourceVersion: "526665225"
selfLink: /apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs/foobar-app
uid: 25e6bf2c-eba3-11e9-98ab-123dee44c1c5
```
Closes https://github.com/openshift/odo/issues/2017
The Makefile was passing slowSpecThreshold=$(SLOW_SPEC_THRESHOLD)
without a leading '-' so was ignoring SLOW_SPEC_THRESHOLD.
Fixed and put common flags in a single variable so they can be changed
in one place. Also you can now say `make VERBOSE=` to turn off -v
output from ginkgo.
* add port-forward code from oc
* added command for debug and experimental
* integrating with odo - in progress
* add build portfoward request in occlient
* resolved all references
* extract the port forwarder into a different package
* some cleanup
* integrating the portforward command in odo cli
* removed i18n
* add debug port support in the config
* use the debug port in portforward cli
* resolved failing unit test
* added debug_port in the env var list
* remove the pod timeout option
* resolved long desc for port forward
* sending corrupt debug port
* better logging
* add tests for odo debug
* minor cleanup
* removed focus
* resolved failing tests
* added comments
* small error in tests
* removed experimental, changed the tests and add warning for tech preview
* added logging for debugging
* added more comments
* removed the port forward interface
* use init:0.12.0 bootstrap image
* made port forwarder more independent and added comment
* major refactor to resolve mrinal's comments
* moved logging
* doc typo
* doc typo
* Setting up rpm spec for odo for rpm build
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing typo
* Printing envs for debugging
* Removing -rpm suffix for rpm target
* Update rpm prepare script to store version information alongside rpmbuild artifacts
* Adding script to create tarball of the source. To be run after rpm-prepare is done
* Fixing dist git tarball generator
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing script from commit as its not yet perfect
* Updating redistributable to use name-redistributable
* Removing version replacement in version.go
* Some minor fixes to spec and script
* Record the need to update version in rpm-prepare script into release process
* Renaming atomic-openshift-odo to openshift-odo
Adds a cross-compiling script rather than having it in the Makefile.
To test:
```sh
github.com/openshift/odo fix-cross ✔ 0m
▶ make cross
./scripts/cross-compile.sh '-X github.com/openshift/odo/pkg/odo/cli/version.GITCOMMIT=91599ec5'
Cross compiling linux-amd64 and placing binary at dist/bin/linux-amd64/
Cross compiling darwin-amd64 and placing binary at dist/bin/darwin-amd64/
Cross compiling windows-amd64 and placing binary at dist/bin/windows-amd64/
```
* Run all integration test in parallel
* Checking how integration all behaves in CI
* Updated preference path
* Fixing error
* Updated preference file as per girish
* Fixing test failure
* Updated travis file
* Fixed test failure
* Fixed some more test failure
* Fixed some more test failure
* Increasing CI timeout
* Updating test
* Separating service catalog tests
* Updated Makefile
* Fixed context dir
* Fixed context dir per spec
* Updated CI files and doc
* Updated doc and Makefile comment
* Review comments are addressed
* Updated preference text
* Updated Makefile
* Updated docs
* Updated as per review comment
* Updated tests
* Updated doc
* Updated Makefile
* Introduce gosec for security checks
gosec does static code analysis and checks for common security issues in
golang codebases.
This PR introduces the tool, and sets it up as a test target in the Makefile.
* Address gosec warnings
This:
* Makes the default directory and file permissions more restrictive.
* Comments out with #nosec a warning that's not relevant, given that
the function is only used for testing.
* Add "sec" to the validate makefile target
This way, security static analysis checks will be ran as part of regular CI.
* Run login scenarios test in parallel
* Updated doc
* Commented odo command in travis file
* Updated .travis file
* Updated .travis CI file
* Updated helper file
* Fixed OpenShift CI file
* Updated OpenShift CI file
* Updated travis and Makefile
* Updated OpenShift CI file
* Made login and logout part of Makefile
* Update login test in sync with other test
* Fixing odo login logout as per review comment
* Updated Makefile comment
* Updated test file
* Updated use of token flag
* Updated doc as per review comments
* Updated test file
* Removed new line
* Decrease the test node to 2
* Updated doc
* This PR adds a file walker for smart odo push.
The file walker walks the entire directory and builds a map of filename as key and it's size and last modified date as value and compares them to find added/deleted/modified/renamed files and folders in the source context directory.
* Adds comments and parallelizes the tests
* Added more checks in push e2e
* Fixed root directory for windows and info message
* Run source test specs in parallel
* Updated doc
* Updated doc
* Commenting e2e test spec due to an open issue
* Commenting e2e test spec due to an open issue
* Updated spec comment
* Adding function to ensure common messaging for push command.
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating push message and listing deleted from config urls
- URLS list now indicate if they are present in config
- Push message is updated accordingly
* Adding comment and fixing push message object.
* Adding url integration tests
* Updating tests scripts to include url int tests.
* Fixing test URLS -> URLs
* Shortening test spec strings to match
* Removing url checks from generic tests
* Adding helper function to be able to provide array to strings to match.
* Updatng url tests to make use of the helper match functions as needed.
* Fixing match for test.
* Moving pushmessage.go to more generic name and renaming func
The function now returns a message, also making it more easy to
test.
* Adding unit tests to printtemplates
* Updating usage of PushMessage template
* Fixing errors introduced during rebase
* Fixing issues after rebase
* Fixing test templates.
* Updating url tests to parallel run.
* Cleaning up tests
* Run storage command test in parallel
* Updated oc helper file
* Updated stotage test file
* Updated doc and Makefile
* Updated CI files
* Updated travis file
* Run app command test in parallel
* Removed similar app test from json_test file
* Added travis and prow config file
* Updated json output
* Updated doc
* Running spec parallelly for clean test template
* Exporting GOPATH
* Installing ginkgo binary
* Removed debug line
* Removed clean test template reference from travis
* Updated test comment in Makefile
* Updated doc changes for env var SPEC_EXEC_METHOD
* Adding more info to test description
* Updated description
* Added TIMEOUT
* Added GLOBALODOCONFIG for global config isolation
* Fixed review comments
* Added test node env var and updated doc
* Added pwd in PATH
* Removed test template form Makefile
* Updated doc
* Documentation and description updated
* Added ginkgo in travis CI
* Made ginkgo installation part of goget-tools
* Added doc for test-integration
* Updated doc and Makefile
* Modifies odo app commands to work outside a directory
* Adds a error message
Signed-off-by: mik-dass <mrinald7@gmail.com>
* Adds e2e test
* Removed unused oc helper in app e2e test
* Splits a e2e test into 2 specs
* Fixed error message
* Moves CheckApplicationName and CheckProjectName to cmd utils
* removes os.exit(1)
* Formats ThrowContextError
* resolved development docs and bump-version.sh script
Currently the Readme.adoc doesn't actually show any version for odo but we still try to update that using the bump-version script and also it has been mentioned in the dev docs. so changed that.
* fixed extension of cli-reference file
* Modifies storage according to the new workflow
Adds test
Signed-off-by: mik-dass <mrinald7@gmail.com>
* Added e2e tests
Signed-off-by: mik-dass <mrinald7@gmail.com>
* Added comments for CreateArgs and DeleteFromConfigurationList
* Rebased the PR
Signed-off-by: mik-dass <mrinald7@gmail.com>
* Mereged storage e2e test with watch test