- This makes it possible to override golang version based on
availability in build system of rpm
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* #4062 Update installing odo on Windows section to fix filename and add additional steps and information required
* #4062 updated to make it generic, got rid of go/bin references
* Incorporated feedback from dharmit
* #4062 made changes to replace tar.gz for .zip for windows installer
* #4062 incorporated feedback from Dharmit
* #4062 Fixed a couple of typos to addres dharmit feedback
* 4062 fix mising dot in .exe
* 4062 fix if sattement
* 4062 fix syntax error
* 4062 fix syntax error
* 4062 fix syntax error
* 4062 fix syntax error
* 4062 fix syntax error
* Fixed statements for when suffix is .exe
* Fixed if syntax
* changed syntax
* Fixed syntax
* fixed zip command syntax
* Removed unnecessary comments and updtaed redistributable filename to add .exe before .zip
* Fixing rpm spec Provides and Obsoletes to be more specific
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing local build script to use dist/rpmbuild and topdir for build
- This prevents polluting users main rpmbuild
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Setting goflags during `make test` and turning off missing buildid
- without goflags, unit tests take a while as they dont use vendor
- providing -mod=vendor does not seem to help
- missing gnu build ids in go binaries can cause warnings
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing GOFLAGS from spec and adding build_flags to test target
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Unsetting any goflags for make test in openshift ci
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing the set +x from local build script
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Adding rpm tests
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing last rm -rf
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Reverting to explicitly setting GOFLAGS for make test
- It appears that while `-mod=vendor` flag is available for `go test`
it is sometimes not respected
- It is therefore, better to just set GOFLAGS only for make test
- More investigation is needed to find better solution, but we should
not break stuff relation to testing and release, where we should not
be pulling from outside world
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Cleaning up rpm-prepare
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing unnessasary newline
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Adding version file to spec for any future automation to have easier time
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
**What type of PR is this?**
/kind bug
**What does does this PR do / why we need it**:
Package name in our internal git repository / brew is changed from
openshift-odo to just `odo`
**Which issue(s) this PR fixes**:
N/A
**PR acceptance criteria**:
N/A
**How to test changes / Special notes to the reviewer**:
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`
/kind bug
**What does does this PR do / why we need it**:
Our internal release system requires all the following variables /
information in the spec in order to do a s390x release. This if
statement has been removed so we may be correctly build our internal
build.
**Which issue(s) this PR fixes**:
N/A
**PR acceptance criteria**:
N/A
**How to test changes / Special notes to the reviewer**:
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Building redistributable only on x86_64
We dont need redistributable package building
on multiple architectures as it is happening right
now (case in point internal scratch build)
Eg:
- openshift-odo-redistributable-1.2.3-1.el8.s390x.rpm
- openshift-odo-redistributable-1.2.3-1.el8.ppc64le.rpm
- openshift-odo-redistributable-1.2.3-1.el8.x86_64.rpm
We only need last one as individual rpms for specific architectures
is fine but not the redistributable ones.
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating golang version to 1.13
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
- Updated rpm spec and rpm-prepare script to template golang version
- Docs now contain a warning about golang version update
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Setting up rpm spec for odo for rpm build
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing typo
* Printing envs for debugging
* Removing -rpm suffix for rpm target
* Update rpm prepare script to store version information alongside rpmbuild artifacts
* Adding script to create tarball of the source. To be run after rpm-prepare is done
* Fixing dist git tarball generator
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing script from commit as its not yet perfect
* Updating redistributable to use name-redistributable
* Removing version replacement in version.go
* Some minor fixes to spec and script
* Record the need to update version in rpm-prepare script into release process
* Renaming atomic-openshift-odo to openshift-odo
