<!--
Thank you for opening a PR! Here are some things you need to know before submitting:
1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline
Documentation:
If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->
**What type of PR is this:**
<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests
/kind documentation
Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind cleanup
**What does this PR do / why we need it:**
Remove all italic output throughout odo with the exception of building
images / pushing images.
Makes all output consistent with `odo dev` and `odo deploy`
**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->
N/A
**PR acceptance criteria:**
- [X] Unit test
- [X] Integration test
- [X] Documentation
**How to test changes / Special notes to the reviewer:**
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* update to openshift 4.7 and sbo 0.7.0
* use server side apply for updating deployments
* go mod vendor
* use ApplyDeployment instad Patch and Create
* fix login message
* update unit tests to work with ApplyDeployment function
* fall back to Create/Update for k8s older than 1.16
* abstract fieldManager into const
* fix operator-framework imports
**What kind of PR is this?**
<!--
DELETE the kind(s) which are not applicable before opening the PR.
-->
/kind code refactorting
/kind docs
/kind enhancement
**What does does this PR do / why we need it**:
This PR:
- Adds italic font when outputting what to "do next". Essentially, when
using log.Info it's for a "bold" or "title" log. When using log.Italic
it's mainly used for when we want to say to the user what to do next,
such as using `odo push` to propagate changes
- Removes random periods which aren't suppose to be there (all output
should not be sentences with periods)
**Which issue(s) this PR fixes**:
N/A
**How to test changes / Special notes to the reviewer**:
Run: `odo create nodejs` or any other similar commands, such as `odo
url create` which have "next steps" in them.
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* What kind of PR is this?
/kind cleanup
What does does this PR do / why we need it:
It adds golangci-lint as a travis job
It also adds the golangci-lint as make target.
It also fixes the current lint errors in our code base.
Which issue(s) this PR fixes:
Fixes#1927
How to test changes / Special notes to the reviewer:
run `golangci-lint run` and check that no errors occur
Signed-off-by: mik-dass <mrinald7@gmail.com>
* Fixes watch test by adding timeout
* Fixes issue of odo login not working correctly
This fixes the issue of `odo login` not working correctly.
In this PR:
- Added logging for before AND after
- Changed stdout / stderror to the correct ones from odolog package
- Fix up success output
- Added Success function to odolog
Closes issue https://github.com/openshift/odo/issues/1643
* Fix error and colouring
* Re-add the color
* Fix other error
* Adds another fix with regards to filtering messages
* Remove color
* Add another filter
* Fix#1400 : Adding prow style OWNERS files
This PR adds OWNERS files to enable prow to ping appropriate people
and decide whose PRs warrant automatic merge
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing kadel from tests
* Fixing #1017: Intercepting login message and printing custom message
- Adding buffer to replace os.Stdout and intercept output of login
- Customizing a message from odo based on what was intercepted,
so if new-project is present in original message, appropriate
addition is done to odo message
- Printing custom message for login success case.
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Changing extra message to more closely immitate openshifts own messaging
* Changing to plan B of string replacement of new-project.
* Replacing "<projectname>" with "<project-name>"
* Splitting replace logic into 2 lines
* Adding tests to odo login
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Reducing wait time for project deletetion
* Altering trigger name for odo login test
* Adding failure case with invalid token login
* Adding odo login e2e tests to travis.
* Removing references of second teat project
* Adding explicit timing
* Increasing wait time
* Replacing explicit time with WaitForCmdOut
What is the purpose of this change? What does it change?
Fixes `odo login` issues
Was the change discussed in an issue?
Solves #992
How to test changes?
`odo login`
