* Add integration test case
Co-authored-by: Anand Kumar Singh <anandrkskd@gmail.com>
Co-authored-by: Philippe Martin <phmartin@redhat.com>
* Add ApplyOpenShift method to handler
* Test openhift component with odo dev
* Rename GetKubernetesComponentsToPush to GetK8sAndOcComponentsToPush and modify if to obtain both k8s and oc components
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Fix unit test failures with delete_test
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* update ListClusterResourcesToDeleteFromDevfile to fetch openshift component,Add ListOpenShiftComponents
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
* fix testcase 'should have deleted the old resource and created the new resource' and add helper function ReplaceStrings
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
* fix debug test to check openshift component
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
* Update GetBindingsFromDevfile to include openshift components
* Update offline tests
* Add openshift component to devfiles
* Update tests
* Fix binding tests
* Fix RemoveBinding unit tests
* Handle OpenShift components when removing binding
* odo describe component displaysOpenShift components
* Remove unused function
---------
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Co-authored-by: Anand Kumar Singh <anandrkskd@gmail.com>
Co-authored-by: Philippe Martin <phmartin@redhat.com>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
* Update the Devfile library
* Add test for container-overrides and pod-overrides attributes
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Attempt at fixing CI failures
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Fix CI failure
* Attempt at fixing OC integration test failures
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Use random name in integration test
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Rebase and fix integration test failure
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Make integration test work for podman
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Temp attempt at fixing podman test for GH
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Another attempt at fixing CI test for podman
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* One more attempt at fixing integration test for podman
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Rename GetK8sManifestWithVariablesSubstituted to GetK8sManifestsWithVariablesSubstituted
* Add GetK8sComponentAsUnstructuredList; add support for multiple manifests in a single k8s component
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Use GetK8sComponentAsUnstructuredList in binding/remove.go
* Use GetK8sComponentAsUnstructuredList in component/component_test.go
* Use GetK8sComponentAsUnstructuredList in libdevfile/component_kubernetes_utils.go
* Use GetK8sComponentAsUnstructuredList in service/service.go
* Use GetK8sComponentAsUnstructuredList in devfile/adapters/kubernetes/component/adapter.go
* Add documentation for GetK8sComponentAsUnstructuredList and remove GetK8sComponentAsUnstructured
* Fix createOrUpdateServiceForComponent to fetch only the service created for the component
* Add integration test for odo deploy
* Add integration test for odo dev
* Attempt at fixing list/describe binding tests; fixes old mishap
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Check for empty list of binding
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Remove Dharmit from OWNERS files across the repo
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
* Remove Dharmit and Charlie from OWNERS
* Adds Tomas to owners
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
* Add integration test
* odo dev deletes remote resources not present in the Devfile
* Delete the servicebinding secret without SBO
* Fix integration tests failure for when SBO is installed
* code Refactor
* Refactor the code
* Fix components_test.go
* add todos to integration tests
* Code review from feloy
* Move secret removal out of UnbindWithLibrary; rename deleteServiceBindingSecrets; add spinner end defer
* Attempt at making resource deletion concurrent
* Temp changes
* temp change
* Use errgroup wg to handle go routines
* Use single spinner for all the resources
* Fix validation failures
* Temp changes
* Optimize the code
* Optimize error messages; remove the unnecessary use of 'Kubernetes'
* List routes/ingresses deployed by odo in the describe output
* Remove ListDyanmicResourcesFromSelector and use ListDyanmicResources instead by add a selector argument to it
Signed-off-by: Parthvi Vala <pvala@redhat.com>
* Update pkg/api/component.go
Co-authored-by: Armel Soro <armel@rm3l.org>
* Replace DyanmicClient for ingress with a kubeclient
* Show ing/route name if *.hosts is empty
* Change API format
* Ignore owned ing/routes
* Add devfile with default backend ingress
* Add tests for named describe command
* mock kclient
* Fix integration test failure
* Fix integration test failure with registry
* Add test for ingress with default backend
* Add unit test for ListRoutesAndIngresses
* Add documentation
* Fix circular dependency and test failures
* Update upstream docs
* Fix integration test and add unit test for owner reference
* DRY the unit test code
* Update pkg/component/component.go
Co-authored-by: Philippe Martin <contact@elol.fr>
* Use context to obtain app
* rm3l's review
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Philippe Martin <contact@elol.fr>
* Create auxialiary functions to find current deployment and pod name
* Create auxialiary function for pushing Kubernetes components to cluster
* Auxiliary function getPushDevfileCommands and remocve RunModeChanged flag as it is not possible anymore with long running dev command
+ move prelimiray tests at the beginning
* Create auxiliary function updatePVCsOwnerReferences + move isMainStorageEphemeral inside aux. function
* Watch for deployments in addition to watching for files during odo dev
* - Check the Deployment Generation to return earlier when generation changed
- Return earlier when pod is not ready
* Push receives a Status that it can update, to indicate the status of the component when the function returns. This status is passed from Start to Watch
* Use status to decide to sync files
* Simplify getting pod
* Status for PostStartEvents
* - Touch .gitignore earlier so it is not synced
- Add devstate.jso file to .gitignore
* Fix the integration tests.
* Make --no-watch work again
* Get smaller volumes for tests
* Quit when fail to exec port forwarding
* Exponential delay after an error
* Fix: get running pod
* Remove testing odo dev stops when the build command fails. odo dev now gives a change to the user to fix the problem
* Fix order or volumes and volume mounts in pod spec
* Use server side apply for updating PVC when supported
* Watch Devfile separately
* Adapt tests for devfile handled separately
* Update forwarded ports when necessary
* Display kubernetes resources created only when created/updated
* Do not set ResourceVersion when patching
* TEMP: Add more logs on failing integrattests
* Tests: select the *running* pod
* Use forward slashes for .gitignore content, even on Windows
* Rename GetOnePodFromSelector to GetRunningPodFromSelector
* Cleanup logs
* Fix 'odo log' integration test
* Add log "Waiting for Kubernetes resources"
* Fail if service bindings are not injected
* Rename sources related watcher, timer
* Fix delay after error
* Display info about Pod
* Disambiguate error messages
* Display events related to components pod
* Remove now unused functions used to wait for Deployment / Pod
* Typos + function renaming
* Do not watch devfile with --no-watch
* Use type switch for Kubernertes watch event
* Do not fail when watching Events is Forbidden
* Do not fail when servicebinding resources are forbidden
* Exit when build command fails on no-watch mode
* Sync devfile.yaml by default, workaround when commands change on devfile
* Rename to warningsWatcher
* Fix comment
* Allow Dynamic Client to list dynamic resources from a specified namespace
If the namespace specified is empty, it works as before
by returning resources from the current namespace.
Listing dynamic resources is used
when listing service binding instances.
* Allow users to select a namespace from which Service Binding Instances are retrieved
For consistency, this supports both interactive and non-interactive modes.
Non-interactive mode is supported via a '--service-namespace' flag.
As before, if this namespace is not specified, we default
to using the current namespace.
This also handles permission errors that might occur while listing namespaces/projects.
On Openshift, listing projects returns all the projects a user
effectively has access to, but this does not behave the same way
in vanilla K8s clusters. If user is allowed to list namespaces/projects,
the list returned is not filtered by any ACL filter [1].
In the case a user is not allowed to list namespaces/projects,
rather than returning an error, we are prompting them to manually
enter a different namespace (or nothing to use the current one).
[1] https://github.com/kubernetes/kubernetes/issues/48537
* Make the "No bindable service instances found" error message more explicit by mentioning the namespace
* Add namespace information to service (with or without Devfile)
* Add namespace information to 'list binding' and 'describe binding' output
* Check SBO availability before user is asked questions
* Set Kind in servicebinding instead or Resource
* odo add binding without Devfile
* Force select at least one operation option
* Change message for selecting operations
* Add Go back when selecting resource name for waorkload
* Doc
* Enable interactive binding tests for Kubernetes
* Add integration tests
* Validate and Test workload flag
* Fix doc about workload flag
* Apply suggestions from code review
Co-authored-by: Parthvi Vala <pvala@redhat.com>
* Review
* Fix interactive test
Co-authored-by: Parthvi Vala <pvala@redhat.com>
* Add integration test highlighting the issue
The devfile used is the same as devfile-deploy.yaml,
except that the the Kubernetes component is referenced via the URI.
This is why the same integration test logic is being reused here.
* Add higher-level function in 'libdevfile' allowing to load component resource manifest and substitute variables
This works with both Inlined or Uri resources.
Notes:
- Ideally, it would make more sense to rely on the same logic used in Devfile to
substitute variables (defined in the 'variables' package),
but this function is not exported;
and the exported ones substitute variables only in the URI name,
not in the content itself (it is not fetched),
which is actually the issue we are trying to solve here.
* Switch to using 'uri' Kubernetes components in test Devfiles
This seems to be a much more realistic case when referencing external
Kubernetes manifests.
Notes:
Some tests, like for `odo deploy`, still test 'Inlined' manifests.
* Pass the component name to 'GetComponentResourceManifestContentWithVariablesResolved'
As suggested in review, this makes more sense
now that we are passing the entire devfile object
* Rename 'GetComponentResourceManifestContentWithVariablesResolved' with 'GetK8sManifestWithVariablesSubstituted'
Previous name was a bit long ^^
* Remove extra parentheses in error string returned by 'ComponentsWithSameNameError#Error', as suggested in review
* Revert "Switch to using 'uri' Kubernetes components in test Devfiles"
This reverts commit df1f19ed959b8c82aa17ac3cf12c343305789149.
This will be done in a separate PR, with ideally
changes that should allow to use the same set of
tests for testing both Inlined and
URI-referenced manifests.
* Document golangci-lint configuration options
* Do not limit the number of issues reported per linter
* Add check preventing the use of the deprecated 'github.com/pkg/errors' package
* Upgrade golangci-lint to 1.37.0, so we can use 'revive' Linter
- revive is a drop-in replacement for the deprecated golint Linter
- revive will allow to check for error strings
Note: We are purposely not using the latest golangci-lint (1.45.0)
but the minimum version from which revive is available.
This is because the latest 1.45.0 reports additional linting issues
(from govet and staticcheck for example). And fixing those side errors
is outside of the scope of this issue.
Also some of those issues are already fixed in #5497 (update to Go 1.17).
* Configure revive to check for error strings
More rules can be added later on if needed
* Fix issues reported by revive's error-strings rule
Some rules are purposely ignored when the
error messages represent top-level errors that are
displayed to be displayed as is to end users
* Fix more error-strings issues
For some reason, those were not reported by revive's error-strings rule,
but only by GoLand inspection tool.
* Fix missing `revive:disable:error-strings` comment directive
Also replace "fmt.Errorf" by "errors.New" when the error message is static
* Change errors.Wrapf
* Replace errors.Wrap
* Dont use pkg/errors (except error.Cause)
* Fix errors on Windows (do not test system underlying message)
* Replace errors.Cause
* Review
* Add Dev and Project labeling / refactoring labeling and annotations
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:
1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline
Documentation:
If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->
**What type of PR is this:**
<!--
Add one of the following kinds:
/kind bug
/kind tests
/kind documentation
Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind feature
/kind cleanup
**What does this PR do / why we need it:**
In this PR we:
* Correctly name all the labels in a more concise manner (ex. Project Type
is an annotation)
* Add Dev and Deploy mode labels to both `odo dev` and `odo deploy`
commands so that we can intuitively retrieve what components are in
deploy or dev mode
* Somewhat refactors how we do labeling
**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->
1/2 of PR's for https://github.com/redhat-developer/odo/issues/5405
**PR acceptance criteria:**
- [X] Unit test
- [X] Integration test
- [X] Documentation
**How to test changes / Special notes to the reviewer:**
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Review update / renaming
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Review changes. Adds tests for generateDeploymentObjectMeta. Changes labels
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Namespace
* Get all resources with selector
* Delete resources
* Display errors
* Add start message
* Set correct labels for odo deploy
* Add unit tests
* Add integration tests
* Delete managed by odo only
* Fix rebase
* Review + small fixes
* AdD/fix logs
* Skeleton for odo dev and a unit test
* Update go mod for fsnotify
* Start method Pushes and then Watches
* More understandable code comments
* Client and interface for watch package
* Mocks for watch package
* Add CLI layer
* Fix infinite watch & push trigger
* Remove context flag from odo dev
* Add integration tests for odo dev
* Add klog to dev.go
* Replace errors.Wrap with fmt.Errorf
* Self review
* Removes `odo watch` command, but the business logic exists as it's
used by odo dev
* Removes integration tests for `odo watch`
* Removes errors.go and types.go from pkg/dev/ since they are empty
* Check if error is not nil
* Use real client in watch unit tests
* Uncomment AfterEach from tests
* Modify the logs printed to stdout
* Changes based on Philippe's review
* Remove unused clients
* Parthvi's PR review and unit test fixes
* Fix gofmt message, remove message to not expect
* Fix lint complains, add mistakenly deleted URL creation logic
* Remove or modify tests that rely on odo push output
* Remove unused variables based on golangci-lint
* Fixes based on Philippe's review
* Initialize first index after first run of odo dev
* Modify odo dev test, and uncomment a mistake
* update vendored sbo to 1.0
* go mod vendor
* update code to work with sbo 1.0
* Re-enable use of operator
* Fix remove link
* Continue when no access to CRDs
* Fix rebase
Co-authored-by: Tomas Kral <tkral@redhat.com>
* Init command
* More tests + check empty dir
* Move function from catalog to service package
* Interactive asks lang + type
* Interactive
* Refactor catalog package with interface
* Add mocks for catalog and init/asker
* Add tests
* Create sub-packages for init + starter project
* Rename files in pkg/catalog
* More validations
* fix
* Logs
* Rollback
* Go back and No starter
* Review
* Use filesystem.Filesystem in pkg/catalog
* Change pull from registry strategy
* More unit tests
* More tests
* Integration tests
* Review
* Use full path to fix problem with Unzip
* Add integration test for devfile with parent URI
* Add prefClient dependence to catalog package
* Move function to pkg/init package
* Review
* Fix rebase
* Review
* Undeploy POC
* Implement undeploy
* Cosmetic changes
* Add more tests
* Add documentation
* Add interface methods for undeploy
* Update docs/website/docs/command-reference/flags.md
Co-authored-by: Philippe Martin <contact@elol.fr>
* Update docs/website/docs/command-reference/flags.md
Co-authored-by: Philippe Martin <contact@elol.fr>
* Update docs/website/docs/command-reference/flags.md
Co-authored-by: Philippe Martin <contact@elol.fr>
* Update docs/website/docs/command-reference/delete.md
Co-authored-by: Philippe Martin <contact@elol.fr>
* Add requested changes
Co-authored-by: Philippe Martin <contact@elol.fr>
* Adds support creating k8s built-in resources
* Fix the failing unit tests
* Add starter project name
* Update docs; set ownerReferences correctly
* Address failing integration tests
* Doc changes based on Philippe's feedback
* Update website/docs/tutorials/create-k8s-resources.md
Co-authored-by: Philippe Martin <contact@elol.fr>
* Move back to client-go v0.21.3
Co-authored-by: Philippe Martin <contact@elol.fr>
* Modifies the usage of service create, link and unlink by using separate files for Kubernetes resources
* Modifies the uri path to include the folder path
* Deletes the files when all flag is used with odo delete
* Fixes the unit test removeDevfileURIContents
* Fixes the problem of non existent uri folder when all flag is used in the delete command
* Fix clusterwide permission issue related to CRD while linking without the SBO
* Initial test work
* Create developer user for minikube
* Add script to create developer user for minikube
* Attempt at fixing failures with minikube setup
* Add debugger statement
* Fix failures
* Fix CI failures
* Add apiGroup for ingress
* Temporary attempt at fixing CI failures
* Remove test
* Add comments, and other requested changes by feloy
* Fix misplaced else logic
* Update comment as suggested by feloy
Co-authored-by: Philippe Martin <contact@elol.fr>
* Add warning
Co-authored-by: Philippe Martin <contact@elol.fr>
* vendor
* go mod
* remove old service structures
* Get parameters information of operator backed services from Kubernetes OpenAPI spec
* Add DisplayName
* Displays required + type
* Add some integration tests
* Unit tests
* Display a warning when no CRD or CSV info is found
* Add unit tests
* Update pkg/odo/cli/catalog/describe/operator_backend.go
Co-authored-by: Dharmit Shah <shahdharmit@gmail.com>
Co-authored-by: Dharmit Shah <shahdharmit@gmail.com>
* Removing cli layer and integration tests related to service catalog
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing missing error msg
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing golint errors
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing error for interactive mode
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Moving interactive mode error to top
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing interactive mode error condition
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing some more service related code
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing golint
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing service catalog backend part 1
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating changelogs
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing some more of the service catalog related code
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating as per comments in review
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Update pkg/odo/cli/service/create.go
Co-authored-by: Parthvi Vala <pvala@redhat.com>
* Fixing gofmt
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Adding kube to cli docs
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating changelog as per comments by @dharmit
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Removing some unnessasary stuff
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Updating docs based changes as per review
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Fixing test
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
* Update pkg/odo/cli/catalog/describe/service.go
Co-authored-by: Philippe Martin <contact@elol.fr>
* Update pkg/odo/cli/service/list.go
Co-authored-by: Philippe Martin <contact@elol.fr>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Philippe Martin <contact@elol.fr>
* Adds support for linking using service binding without the service binding operator
* Uses isLinkResource() to detect the service binding resources
* Updates the success message for operator based links
* Updates the flow to creating the deployment first
* Adds annotations to the Redis CR in devfile-with-link.yaml file
* Updates the flow to create only the services before the deployment.
It also separates the push related code for link and service creation.
* Moves the for loop in setLinksServiceNames() inside the if condition
* Adds and returns a error message when the pipeline throws a forbidden type of error
* Moves the updation of services and pvcs with owner references before attempting creation of links
* Do not deploy sbr at `odo link` time, save it in devfile
* Changelog
* Fix remove duplicates
* Do not set owner references again
* Fix wait for pod terminating
* Simplify env vars deduplication
* Add comment
* Dont use oc
* link type
* fix
* Fix spinner
* Fix tests
* Fic error message for link/unlink
* Review
* No spinner
* initial work towards param based odo service create
* change
* add type data to cr
* add to devfile
* update olm
* remove logs
* towards tests
* init tests
* more test
* fix tests
* fix unit again
* set default service name
* mod fix
* addressed some comments
* add postgres operator in setup and in test
* fix
* fix some tests
* fix helpers
* helper flag
* merge conflicts
* add tests and install operator
* certain cases fix
* fix intg tests
* update scripts
* fix intg test
* changed function name
* changes
* fix comments
* docs update
* link fix
* small fix
* comment
* unit tests
* doc fix
* renamed as per comments
* comment
